You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/11/04 20:12:46 UTC
[I] `PartialEq` of GenericByteViewArray (StringViewArray / ByteViewArray) that compares on equality rather than logical value [arrow-rs]
alamb opened a new issue, #6679:
URL: https://github.com/apache/arrow-rs/issues/6679
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
> Comparing two `GenericByteViewArray` using PartialEq compares by structure
> (the `u128`s) and contents of the buffers, not by logical content. As there
As @tustvold points out on https://github.com/apache/arrow-rs/pull/6673/files#r1827839121 this is inconsistent with how `PartialEq` is implemented for other arrays, which compare based on ArrayData which compares based on equality:
https://github.com/apache/arrow-rs/blob/ebcc4a585136cd1d9696c38c41f71c9ced181f57/arrow-data/src/data.rs#L1777-L1781
**Describe the solution you'd like**
Implement `PartialEq` for `GenericByteViewArray` that compares two arrays on logical value rather than physical representation
**Describe alternatives you've considered**
Add manual impl of `PartialEq` to `GenericByteViewArray`
**Additional context**
<!--
Add any other context or screenshots about the feature request here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `PartialEq` of GenericByteViewArray (StringViewArray / ByteViewArray) that compares on equality rather than logical value [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6679:
URL: https://github.com/apache/arrow-rs/issues/6679#issuecomment-2480597328
`label_issue.py` automatically added labels {'documentation'} from #6673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `PartialEq` of GenericByteViewArray (StringViewArray / ByteViewArray) that compares on equality rather than logical value [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6679:
URL: https://github.com/apache/arrow-rs/issues/6679#issuecomment-2480597342
`label_issue.py` automatically added labels {'arrow'} from #6673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `PartialEq` of GenericByteViewArray (StringViewArray / ByteViewArray) that compares on equality rather than logical value [arrow-rs]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 closed issue #6679: `PartialEq` of GenericByteViewArray (StringViewArray / ByteViewArray) that compares on equality rather than logical value
URL: https://github.com/apache/arrow-rs/issues/6679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `PartialEq` of GenericByteViewArray (StringViewArray / ByteViewArray) that compares on equality rather than logical value [arrow-rs]
Posted by "tlm365 (via GitHub)" <gi...@apache.org>.
tlm365 commented on issue #6679:
URL: https://github.com/apache/arrow-rs/issues/6679#issuecomment-2457756604
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org