[GitHub] spark pull request: [SPARK-7402][ML] JSON SerDe for standard param...

[mengxr <gi...@git.apache.org>]

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9090#discussion_r41831432
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
    @@ -287,6 +422,16 @@ class StringArrayParam(parent: Params, name: String, doc: String, isValid: Array
     
       /** Creates a param pair with a [[java.util.List]] of values (for Java and Python). */
       def w(value: java.util.List[String]): ParamPair[Array[String]] = w(value.asScala.toArray)
    +
    +  override def jsonEncode(value: Array[String]): String = {
    +    import org.json4s.JsonDSL._
    --- End diff --
    
    This is not imported globally because it shadows `++`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org