You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2017/03/15 18:43:45 UTC

Review Request 57658: GEODE-2670: fixing pulse authentication/authorization issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57658/
-----------------------------------------------------------

Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and Patrick Rhomberg.


Repository: geode


Description
-------

GEODE-2670: fixing pulse authentication/authorization issues


Diffs
-----

  geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java PRE-CREATION 
  geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java 432834a314f26e308c1430362355bf250dfb2264 
  geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java 5c30501a2c07e55873b090d7c7d14efcfc48139b 
  geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Repository.java 61e967b7e81511dc2f47b6a641e938c4b31502db 
  geode-pulse/src/main/webapp/DataBrowser.html  
  geode-pulse/src/main/webapp/Login.html  
  geode-pulse/src/main/webapp/MemberDetails.html  
  geode-pulse/src/main/webapp/QueryStatistics.html  
  geode-pulse/src/main/webapp/WEB-INF/spring-security.xml cac6caffe500ff3b93d12b4556bde475a45401ad 
  geode-pulse/src/main/webapp/index.html 74b895430bac774da81332b72017c619c369787d 
  geode-pulse/src/main/webapp/scripts/lib/common.js 0c58922eb82eb760d668c3054a52fa9d654fd598 
  geode-pulse/src/main/webapp/scripts/pulsescript/MemberDetails.js 650f30d2b26e51b24b64c43f974138bf20d30702 
  geode-pulse/src/main/webapp/scripts/pulsescript/PulseCallbacks.js e19ddf4779be8d5567380f19d87dcae5e7840344 
  geode-pulse/src/main/webapp/scripts/pulsescript/clusterDetail.js 3fe49eb57c79e637c8ba4d7e8e972bd078b04212 
  geode-pulse/src/main/webapp/scripts/pulsescript/clusterRGraphMembers.js 94b0538ede779a15269b7bf0e29803704ac1cb7e 
  geode-pulse/src/main/webapp/scripts/pulsescript/common.js 550af7c9ab498413cfae9d988afb92f4e7886695 
  geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowser.js 5bbcd7534864f6cb4d6344adfb2179d049a1f13f 
  geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowserQuery.js 534f5c87baa63de5fcbff9f50593b037ea67cc46 
  geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowserQueryHistory.js 77f939e82f9557c513e41de5fcae255bf957f44b 
  geode-pulse/src/main/webapp/scripts/pulsescript/regionView.js 5ce63007b3be2467c47bd7a936d9eaa1a3b63312 
  geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/WebDriverRule.java ca4646bc41921f3fccee833618bca58ae14df91a 
  geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/ui/PulseAnonymousUserTest.java b37551b565da3eca97dfe92d75b9ebaf1fd2f1f8 


Diff: https://reviews.apache.org/r/57658/diff/1/


Testing
-------

precheckin running


Thanks,

Jinmei Liao


Re: Review Request 57658: GEODE-2670: fixing pulse authentication/authorization issues

Posted by Kevin Duling <kd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57658/#review169041
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Duling


On March 15, 2017, 11:43 a.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57658/
> -----------------------------------------------------------
> 
> (Updated March 15, 2017, 11:43 a.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-2670: fixing pulse authentication/authorization issues
> 
> 
> Diffs
> -----
> 
>   geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java PRE-CREATION 
>   geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Cluster.java 432834a314f26e308c1430362355bf250dfb2264 
>   geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java 5c30501a2c07e55873b090d7c7d14efcfc48139b 
>   geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/Repository.java 61e967b7e81511dc2f47b6a641e938c4b31502db 
>   geode-pulse/src/main/webapp/DataBrowser.html  
>   geode-pulse/src/main/webapp/Login.html  
>   geode-pulse/src/main/webapp/MemberDetails.html  
>   geode-pulse/src/main/webapp/QueryStatistics.html  
>   geode-pulse/src/main/webapp/WEB-INF/spring-security.xml cac6caffe500ff3b93d12b4556bde475a45401ad 
>   geode-pulse/src/main/webapp/index.html 74b895430bac774da81332b72017c619c369787d 
>   geode-pulse/src/main/webapp/scripts/lib/common.js 0c58922eb82eb760d668c3054a52fa9d654fd598 
>   geode-pulse/src/main/webapp/scripts/pulsescript/MemberDetails.js 650f30d2b26e51b24b64c43f974138bf20d30702 
>   geode-pulse/src/main/webapp/scripts/pulsescript/PulseCallbacks.js e19ddf4779be8d5567380f19d87dcae5e7840344 
>   geode-pulse/src/main/webapp/scripts/pulsescript/clusterDetail.js 3fe49eb57c79e637c8ba4d7e8e972bd078b04212 
>   geode-pulse/src/main/webapp/scripts/pulsescript/clusterRGraphMembers.js 94b0538ede779a15269b7bf0e29803704ac1cb7e 
>   geode-pulse/src/main/webapp/scripts/pulsescript/common.js 550af7c9ab498413cfae9d988afb92f4e7886695 
>   geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowser.js 5bbcd7534864f6cb4d6344adfb2179d049a1f13f 
>   geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowserQuery.js 534f5c87baa63de5fcbff9f50593b037ea67cc46 
>   geode-pulse/src/main/webapp/scripts/pulsescript/pages/DataBrowserQueryHistory.js 77f939e82f9557c513e41de5fcae255bf957f44b 
>   geode-pulse/src/main/webapp/scripts/pulsescript/regionView.js 5ce63007b3be2467c47bd7a936d9eaa1a3b63312 
>   geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/WebDriverRule.java ca4646bc41921f3fccee833618bca58ae14df91a 
>   geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/ui/PulseAnonymousUserTest.java b37551b565da3eca97dfe92d75b9ebaf1fd2f1f8 
> 
> 
> Diff: https://reviews.apache.org/r/57658/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>