You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "suman-himanshu (via GitHub)" <gi...@apache.org> on 2025/07/31 10:07:53 UTC
[PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
suman-himanshu opened a new pull request, #53965:
URL: https://github.com/apache/airflow/pull/53965
Added redirects for empty and datetime operators documentation
closes #52643
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #53965:
URL: https://github.com/apache/airflow/pull/53965#issuecomment-3155372308
> Hi @potiuk Didnt got your point, could you pls confirm on the destination redirect?
Try it - in the way I suggested - it redirects to a wrong URL. You can navigate the doc server after building the docs and find the right link it should redirect to by clicking through standard provider's doc. Currently when you follow the original doc it will redirect to another 404 URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #53965:
URL: https://github.com/apache/airflow/pull/53965#issuecomment-3144728862
I think those redirects should also contain the `_api` links - and they do not currentlty.
The way to check it:
```
breeze build-docs apache-airflow standard
```
Start docs server as instructed:
```
./docs/start_doc_server.sh
```
Go to the link that was problematic - but locally served - for example:
```
http://localhost:8000/docs/docs/apache-airflow/stable/_api/airflow/operators/empty/index.html
```
And you should be redirected to the standard provider docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
Posted by "suman-himanshu (via GitHub)" <gi...@apache.org>.
suman-himanshu commented on PR #53965:
URL: https://github.com/apache/airflow/pull/53965#issuecomment-3155364107
Hi @potiuk
Didnt got your point, could you pls confirm on the destination redirect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
Posted by "suman-himanshu (via GitHub)" <gi...@apache.org>.
suman-himanshu commented on PR #53965:
URL: https://github.com/apache/airflow/pull/53965#issuecomment-3155560322
source - http://localhost:8000/docs/apache-airflow/stable/_api/airflow/operators/datetime/index.html
redirects to
destination - http://localhost:8000/docs/apache-airflow-providers-standard/stable/_api/airflow/providers/standard/operators/datetime/index.html
source - http://localhost:8000/docs/apache-airflow/stable/_api/airflow/operators/empty/index.html
redirects to
destination - http://localhost:8000/docs/apache-airflow-providers-standard/stable/_api/airflow/providers/standard/operators/empty/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #53965:
URL: https://github.com/apache/airflow/pull/53965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #53965:
URL: https://github.com/apache/airflow/pull/53965#issuecomment-3155354673
The redirect works - but it still does not redirect to where it should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #53965:
URL: https://github.com/apache/airflow/pull/53965#issuecomment-3155759591
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
Posted by "suman-himanshu (via GitHub)" <gi...@apache.org>.
suman-himanshu commented on PR #53965:
URL: https://github.com/apache/airflow/pull/53965#issuecomment-3155547341
Hi @potiuk
I have fixed the destination path and am able to view the doc for empty and datetime when i go on the problematic url served locally, pls review once. Thank you for the help ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #53965:
URL: https://github.com/apache/airflow/pull/53965#issuecomment-3139325312
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #53965:
URL: https://github.com/apache/airflow/pull/53965#issuecomment-3155758358
> Hi @potiuk
>
> I have fixed the destination path and am able to view the doc for empty and datetime when i go on the problematic url served locally, pls review once. Thank you for the help ;)
My Bad ... Apologies... I have not pulled the latest version when checking it... All good .. It works great :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 404 Not Found for EmptyOperator docs for version 2.7+ #52643 [airflow]
Posted by "suman-himanshu (via GitHub)" <gi...@apache.org>.
suman-himanshu commented on PR #53965:
URL: https://github.com/apache/airflow/pull/53965#issuecomment-3153688618
Hi @potiuk
I have added `_api ` to the paths, Kindly review the PR. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org