You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/20 21:08:01 UTC
[GitHub] [tvm] zxybazh opened a new pull request #9053: [Meta Schedule][M3a] TuneContext
zxybazh opened a new pull request #9053:
URL: https://github.com/apache/tvm/pull/9053
This PR is part of the stage M3a of the meta schedule project (#8473).
The architecture is re-designed by Junru and Xiyou. `TuneContext` contains all the resources, i.e., related classes for a single tuning task. The class can be accessed in both python side and c++ side. No function is designated inside.
More classes would be added to `TuneContext` as we proceed with the upstreaming.
Co-authored-by: Junru Shao <<j...@gmail.com>>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r712574831
##########
File path: python/tvm/meta_schedule/tune_context.py
##########
@@ -0,0 +1,102 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Meta Schedule tuning context."""
+
+from typing import Optional
+
+from tvm import IRModule
+from tvm.runtime import Object
+from tvm.target import Target
+from tvm.meta_schedule.utils import cpu_count
+from tvm._ffi import register_object
+
+from . import _ffi_api
+
+
+@register_object("meta_schedule.TuneContext")
+class TuneContext(Object):
+ """
+ The tune context class is designed to contain all resources for a tuning task.
+
+ Different tuning tasks are separated in different TuneContext classes, but different classes in
+ the same task can interact with each other through tune context. Most classes have a function
+ to initialize with a tune context.
+
+ Parameters
+ ----------
+ mod : Optional[IRModule] = None
+ The workload to be optimized.
+ target : Optional[Target] = None
+ The target to be optimized for.
+ task_name : Optional[str] = None
+ The name of the tuning task.
+ rand_state : int = -1
+ The random state.
+ Need to be in integer in [1, 2^31-1], -1 means using random number.
+ num_threads : int = -1
+ The number of threads to be used, -1 means using the logical cpu count.
+ verbose : int = 0
+ The verbosity level.
+ """
+
+ mod: Optional[IRModule]
+ target: Optional[Target]
+ task_name: Optional[str]
+ rand_state: int
+ num_threads: int
+ verbose: int
+ is_stopped: bool
+
+ def __init__(
+ self,
+ mod: Optional[IRModule] = None,
+ target: Optional[Target] = None,
+ task_name: Optional[str] = None,
+ rand_state: int = -1,
+ num_threads: Optional[int] = -1,
+ verbose: Optional[int] = 0,
Review comment:
Remove verbose given it's not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on a change in pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r712640285
##########
File path: python/tvm/meta_schedule/tune_context.py
##########
@@ -0,0 +1,94 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Meta Schedule tuning context."""
+
+from typing import Optional
+
+from tvm import IRModule
+from tvm.runtime import Object
+from tvm.target import Target
+from tvm.meta_schedule.utils import cpu_count
+from tvm._ffi import register_object
+
+from . import _ffi_api
+
+
+@register_object("meta_schedule.TuneContext")
+class TuneContext(Object):
+ """
+ The tune context class is designed to contain all resources for a tuning task.
+
+ Different tuning tasks are separated in different TuneContext classes, but different classes in
+ the same task can interact with each other through tune context. Most classes have a function
+ to initialize with a tune context.
+
+ Parameters
+ ----------
+ mod : Optional[IRModule] = None
+ The workload to be optimized.
+ target : Optional[Target] = None
+ The target to be optimized for.
+ task_name : Optional[str] = None
+ The name of the tuning task.
+ rand_state : int = -1
+ The random state.
+ Need to be in integer in [1, 2^31-1], -1 means using random number.
+ num_threads : int = None
+ The number of threads to be used, None means using the logical cpu count.
+ """
+
+ mod: Optional[IRModule]
Review comment:
Can you please add comments to clarify why `target` and `mod` can be `Optional`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on a change in pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
zxybazh commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r713253111
##########
File path: python/tvm/meta_schedule/tune_context.py
##########
@@ -0,0 +1,94 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Meta Schedule tuning context."""
+
+from typing import Optional
+
+from tvm import IRModule
+from tvm.runtime import Object
+from tvm.target import Target
+from tvm.meta_schedule.utils import cpu_count
+from tvm._ffi import register_object
+
+from . import _ffi_api
+
+
+@register_object("meta_schedule.TuneContext")
+class TuneContext(Object):
+ """
+ The tune context class is designed to contain all resources for a tuning task.
+
+ Different tuning tasks are separated in different TuneContext classes, but different classes in
+ the same task can interact with each other through tune context. Most classes have a function
+ to initialize with a tune context.
+
+ Parameters
+ ----------
+ mod : Optional[IRModule] = None
+ The workload to be optimized.
+ target : Optional[Target] = None
+ The target to be optimized for.
+ task_name : Optional[str] = None
+ The name of the tuning task.
+ rand_state : int = -1
+ The random state.
+ Need to be in integer in [1, 2^31-1], -1 means using random number.
+ num_threads : int = None
+ The number of threads to be used, None means using the logical cpu count.
+ """
+
+ mod: Optional[IRModule]
Review comment:
Thanks for pointing it out. In most cases the `target` and `mod` should be available. It is `Optional` because all the classes are highly customizable, i.e., you can even leave it empty as long as the `SearchStrategy` could generate valid measure candidates. You will also notice most of the class members are `Optional` in meta schedule for flexibility. Will add some comments here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#issuecomment-924531663
Please merge the PR if no further issues, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9053: [MetaSchedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r793027645
##########
File path: tests/scripts/task_mypy.sh
##########
@@ -29,5 +29,6 @@ mypy --check-untyped-defs python/tvm/tir/analysis/
echo "Checking MyPy Type defs in the transform package."
mypy --check-untyped-defs python/tvm/tir/transform/
-echo "Checking MyPy Type defs in the tvm.relay.backend.contrib.ethosu package."
-mypy --check-untyped-defs python/tvm/relay/backend/contrib/ethosu/
+#TODO(@mikepapadim): This is failing atm
Review comment:
oh actually we reported in this thread: https://github.com/apache/tvm/pull/9050. definitely should submit it as a separate PR though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on a change in pull request #9053: [MetaSchedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r792875204
##########
File path: tests/scripts/task_mypy.sh
##########
@@ -29,5 +29,6 @@ mypy --check-untyped-defs python/tvm/tir/analysis/
echo "Checking MyPy Type defs in the transform package."
mypy --check-untyped-defs python/tvm/tir/transform/
-echo "Checking MyPy Type defs in the tvm.relay.backend.contrib.ethosu package."
-mypy --check-untyped-defs python/tvm/relay/backend/contrib/ethosu/
+#TODO(@mikepapadim): This is failing atm
Review comment:
Please create an issue if things like this happens and possibly ping codeowners please, we were not aware that any of the checked in code was not tested until recently.
cc : @mikepapadim @junrushao1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r713210050
##########
File path: python/tvm/meta_schedule/tune_context.py
##########
@@ -0,0 +1,94 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Meta Schedule tuning context."""
+
+from typing import Optional
+
+from tvm import IRModule
+from tvm.runtime import Object
+from tvm.target import Target
+from tvm.meta_schedule.utils import cpu_count
+from tvm._ffi import register_object
+
+from . import _ffi_api
+
+
+@register_object("meta_schedule.TuneContext")
+class TuneContext(Object):
+ """
+ The tune context class is designed to contain all resources for a tuning task.
+
+ Different tuning tasks are separated in different TuneContext classes, but different classes in
+ the same task can interact with each other through tune context. Most classes have a function
+ to initialize with a tune context.
+
+ Parameters
+ ----------
+ mod : Optional[IRModule] = None
+ The workload to be optimized.
+ target : Optional[Target] = None
+ The target to be optimized for.
+ task_name : Optional[str] = None
+ The name of the tuning task.
+ rand_state : int = -1
+ The random state.
+ Need to be in integer in [1, 2^31-1], -1 means using random number.
+ num_threads : int = None
+ The number of threads to be used, None means using the logical cpu count.
+ """
+
+ mod: Optional[IRModule]
Review comment:
@zxybazh lets add more docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#issuecomment-923423198
Otherwise looks good to me! Thanks @zxybazh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
zxybazh commented on pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#issuecomment-923370791
> Hey you probably need to rebase after #9044 is merged?
Already rebaed : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on a change in pull request #9053: [MetaSchedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r793325592
##########
File path: tests/scripts/task_mypy.sh
##########
@@ -29,5 +29,6 @@ mypy --check-untyped-defs python/tvm/tir/analysis/
echo "Checking MyPy Type defs in the transform package."
mypy --check-untyped-defs python/tvm/tir/transform/
-echo "Checking MyPy Type defs in the tvm.relay.backend.contrib.ethosu package."
-mypy --check-untyped-defs python/tvm/relay/backend/contrib/ethosu/
+#TODO(@mikepapadim): This is failing atm
Review comment:
Yea but that PR was closed saying not needed. Thus, I was under the impression that was never merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r712574633
##########
File path: python/tvm/meta_schedule/tune_context.py
##########
@@ -0,0 +1,102 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Meta Schedule tuning context."""
+
+from typing import Optional
+
+from tvm import IRModule
+from tvm.runtime import Object
+from tvm.target import Target
+from tvm.meta_schedule.utils import cpu_count
+from tvm._ffi import register_object
+
+from . import _ffi_api
+
+
+@register_object("meta_schedule.TuneContext")
+class TuneContext(Object):
+ """
+ The tune context class is designed to contain all resources for a tuning task.
+
+ Different tuning tasks are separated in different TuneContext classes, but different classes in
+ the same task can interact with each other through tune context. Most classes have a function
+ to initialize with a tune context.
+
+ Parameters
+ ----------
+ mod : Optional[IRModule] = None
+ The workload to be optimized.
+ target : Optional[Target] = None
+ The target to be optimized for.
+ task_name : Optional[str] = None
+ The name of the tuning task.
+ rand_state : int = -1
+ The random state.
+ Need to be in integer in [1, 2^31-1], -1 means using random number.
+ num_threads : int = -1
+ The number of threads to be used, -1 means using the logical cpu count.
+ verbose : int = 0
+ The verbosity level.
+ """
+
+ mod: Optional[IRModule]
+ target: Optional[Target]
+ task_name: Optional[str]
+ rand_state: int
+ num_threads: int
+ verbose: int
+ is_stopped: bool
Review comment:
Remove these 2 items given they are not used yet in the current mainline. Let's add them back when needed :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on a change in pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r712550206
##########
File path: CMakeLists.txt
##########
@@ -246,6 +246,7 @@ file(GLOB_RECURSE COMPILER_SRCS
src/arith/*.cc
src/te/*.cc
src/autotvm/*.cc
+ src/meta_schedule/*.cc
Review comment:
Duplicated to L243.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9053:
URL: https://github.com/apache/tvm/pull/9053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r712574746
##########
File path: python/tvm/meta_schedule/tune_context.py
##########
@@ -0,0 +1,102 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Meta Schedule tuning context."""
+
+from typing import Optional
+
+from tvm import IRModule
+from tvm.runtime import Object
+from tvm.target import Target
+from tvm.meta_schedule.utils import cpu_count
+from tvm._ffi import register_object
+
+from . import _ffi_api
+
+
+@register_object("meta_schedule.TuneContext")
+class TuneContext(Object):
+ """
+ The tune context class is designed to contain all resources for a tuning task.
+
+ Different tuning tasks are separated in different TuneContext classes, but different classes in
+ the same task can interact with each other through tune context. Most classes have a function
+ to initialize with a tune context.
+
+ Parameters
+ ----------
+ mod : Optional[IRModule] = None
+ The workload to be optimized.
+ target : Optional[Target] = None
+ The target to be optimized for.
+ task_name : Optional[str] = None
+ The name of the tuning task.
+ rand_state : int = -1
+ The random state.
+ Need to be in integer in [1, 2^31-1], -1 means using random number.
+ num_threads : int = -1
+ The number of threads to be used, -1 means using the logical cpu count.
+ verbose : int = 0
+ The verbosity level.
+ """
+
+ mod: Optional[IRModule]
+ target: Optional[Target]
+ task_name: Optional[str]
+ rand_state: int
+ num_threads: int
+ verbose: int
+ is_stopped: bool
+
+ def __init__(
+ self,
+ mod: Optional[IRModule] = None,
+ target: Optional[Target] = None,
+ task_name: Optional[str] = None,
+ rand_state: int = -1,
+ num_threads: Optional[int] = -1,
Review comment:
```suggestion
num_threads: Optional[int] = None,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r712574157
##########
File path: python/tvm/meta_schedule/__init__.py
##########
@@ -16,3 +16,4 @@
# under the License.
"""Package `tvm.meta_schedule`. The meta schedule infrastructure."""
from . import builder
+from . import tune_context
Review comment:
Making it top-level indexable with `tvm.meta_schedule.TuneContext`
```suggestion
from .tune_context import TuneContext
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #9053: [Meta Schedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#issuecomment-923368475
Hey you probably need to rebase after #9044 is merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9053: [MetaSchedule][M3a] TuneContext
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9053:
URL: https://github.com/apache/tvm/pull/9053#discussion_r792936561
##########
File path: tests/scripts/task_mypy.sh
##########
@@ -29,5 +29,6 @@ mypy --check-untyped-defs python/tvm/tir/analysis/
echo "Checking MyPy Type defs in the transform package."
mypy --check-untyped-defs python/tvm/tir/transform/
-echo "Checking MyPy Type defs in the tvm.relay.backend.contrib.ethosu package."
-mypy --check-untyped-defs python/tvm/relay/backend/contrib/ethosu/
+#TODO(@mikepapadim): This is failing atm
Review comment:
Sure. I thought we did, but it turned out haven't...Please make sure to report in time :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org