You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/01/18 07:35:30 UTC

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2543: make prometheus bind addr can cofigure

eolivelli commented on a change in pull request #2543:
URL: https://github.com/apache/bookkeeper/pull/2543#discussion_r559362456



##########
File path: bookkeeper-stats-providers/prometheus-metrics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java
##########
@@ -63,6 +63,9 @@
     public static final String PROMETHEUS_STATS_HTTP_ENABLE = "prometheusStatsHttpEnable";
     public static final boolean DEFAULT_PROMETHEUS_STATS_HTTP_ENABLE = true;
 
+    public static final String PROMETHEUS_STATS_HTTP_ADDR = "prometheusStatsHttpAddr";

Review comment:
       can we name this 'prometheusStatsHttpAddress' ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org