You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2014/11/14 00:24:14 UTC
[GitHub] spark pull request: [SQL] Minor cleanup of comments, errors and ov...
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/3257
[SQL] Minor cleanup of comments, errors and override.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marmbrus/spark minorCleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3257
----
commit 199fd9810c2c729505f7d2e1cdf7070dad3c2cb4
Author: Michael Armbrust <mi...@databricks.com>
Date: 2014-11-13T23:20:02Z
Fix typo
commit f9fa6cffcfad2857d0ba4f1b72668b413809e07c
Author: Michael Armbrust <mi...@databricks.com>
Date: 2014-11-13T23:21:24Z
Methods in a final class do not also need to be final, use override.
commit 2fdf903d24d4c7320cbb2b76f592082bac321a0c
Author: Michael Armbrust <mi...@databricks.com>
Date: 2014-11-13T23:21:44Z
Better error message when coalesce can't be resolved.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL] Minor cleanup of comments, errors and ov...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3257#issuecomment-63023343
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23353/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL] Minor cleanup of comments, errors and ov...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3257#issuecomment-63023338
[Test build #23353 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23353/consoleFull) for PR 3257 at commit [`d8b5abc`](https://github.com/apache/spark/commit/d8b5abcd61b6f96be23f21c89baaf926fb0cf185).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL] Minor cleanup of comments, errors and ov...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3257#issuecomment-62986132
[Test build #23336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23336/consoleFull) for PR 3257 at commit [`2fdf903`](https://github.com/apache/spark/commit/2fdf903d24d4c7320cbb2b76f592082bac321a0c).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL] Minor cleanup of comments, errors and ov...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3257#issuecomment-63017979
[Test build #23353 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23353/consoleFull) for PR 3257 at commit [`d8b5abc`](https://github.com/apache/spark/commit/d8b5abcd61b6f96be23f21c89baaf926fb0cf185).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL] Minor cleanup of comments, errors and ov...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL] Minor cleanup of comments, errors and ov...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3257#issuecomment-62993455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23336/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SQL] Minor cleanup of comments, errors and ov...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3257#issuecomment-62993447
[Test build #23336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23336/consoleFull) for PR 3257 at commit [`2fdf903`](https://github.com/apache/spark/commit/2fdf903d24d4c7320cbb2b76f592082bac321a0c).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org