You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/28 15:40:42 UTC
[GitHub] [beam] kennknowles commented on a change in pull request #11527: Update error prone plugin
kennknowles commented on a change in pull request #11527:
URL: https://github.com/apache/beam/pull/11527#discussion_r416718191
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -870,8 +867,19 @@ class BeamModulePlugin implements Plugin<Project> {
// Enable errorprone static analysis
project.apply plugin: 'net.ltgt.errorprone'
+ project.dependencies {
+ errorprone("com.google.errorprone:error_prone_core:2.3.1")
+ errorproneJavac("com.google.errorprone:javac:9+181-r4173-1")
Review comment:
This version looks very "interesting". Can you add a comment so someone who sees it can understand what is going on?
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -870,8 +867,19 @@ class BeamModulePlugin implements Plugin<Project> {
// Enable errorprone static analysis
project.apply plugin: 'net.ltgt.errorprone'
+ project.dependencies {
+ errorprone("com.google.errorprone:error_prone_core:2.3.1")
Review comment:
Should core and annotations be the same version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org