You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/29 06:04:55 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2718: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [CloudEventProducer]
Alonexc opened a new issue, #2718:
URL: https://github.com/apache/incubator-eventmesh/issues/2718
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/producer/CloudEventProducer.java line 60
### Describe the solution you'd like
For better code clarity, it is better to just use col.isEmpty().
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] sanskar-thakur commented on issue #2718: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [CloudEventProducer]
Posted by "sanskar-thakur (via GitHub)" <gi...@apache.org>.
sanskar-thakur commented on issue #2718:
URL: https://github.com/apache/incubator-eventmesh/issues/2718#issuecomment-1407583026
@Alonexc Sure, no problem. I'll look for other open issues that I can contribute to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: devnull-unsubscribe@infra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-eventmesh] TheAPratap commented on issue #2718: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [CloudEventProducer]
Posted by GitBox <gi...@apache.org>.
TheAPratap commented on issue #2718:
URL: https://github.com/apache/incubator-eventmesh/issues/2718#issuecomment-1398422792
fix: Method checks the size of a collection against zero rather than using isEmpty() [CloudEventProducer] #2936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc closed issue #2718: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [CloudEventProducer]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc closed issue #2718: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [CloudEventProducer]
URL: https://github.com/apache/incubator-eventmesh/issues/2718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: devnull-unsubscribe@infra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-eventmesh] sanskar-thakur commented on issue #2718: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [CloudEventProducer]
Posted by "sanskar-thakur (via GitHub)" <gi...@apache.org>.
sanskar-thakur commented on issue #2718:
URL: https://github.com/apache/incubator-eventmesh/issues/2718#issuecomment-1406809633
I'm a first timer with respect to contributing to open source projects.
I would like to work on this issue. Please assign it to me.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: devnull-unsubscribe@infra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #2718: [Enhancement] Method checks the size of a collection against zero rather than using isEmpty() [CloudEventProducer]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #2718:
URL: https://github.com/apache/incubator-eventmesh/issues/2718#issuecomment-1407255238
> I'm a first timer with respect to contributing to open source projects. I would like to work on this issue. Please assign it to me. Thanks.
Welcome, this issue has been fixed and I will close it, are you interested in other issues? You are more than welcome to contribute to eventmesh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: devnull-unsubscribe@infra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org