You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/26 14:05:42 UTC
[jira] [Commented] (THRIFT-4136) align is_binary() function with
all other types
[ https://issues.apache.org/jira/browse/THRIFT-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942284#comment-15942284 ]
ASF GitHub Bot commented on THRIFT-4136:
----------------------------------------
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1221
THRIFT-4136
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-4136
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1221
----
commit 6782f1af7687915d43fd778800bba6684a6b2b7b
Author: Jens Geyer <je...@apache.org>
Date: 2014-12-28T23:54:36Z
Setup for VS 2015 + workarounds for some open tickets:
- THRIFT-2913 Ruby Server Thrift::ThreadPoolServer should serve inside a thread --> commented out
- (NO TICKET) gjslint fails with invalid syntax in closure_linter/gjslint.py", line 168 -> commented, need Python 2.7.3
commit 3d940da0bbf01fce779d0a8d437a3ba26f2dc793
Author: Jens Geyer <je...@apache.org>
Date: 2017-03-26T12:52:35Z
THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch
commit b87460c806696d393a5f870d30252e55927212fb
Author: Jens Geyer <je...@apache.org>
Date: 2017-03-26T12:53:00Z
THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch
commit 2f71de6bde1333d3e9da7ae38d2c0a3b13283bdf
Author: Jens Geyer <je...@apache.org>
Date: 2017-03-26T13:54:30Z
THRIFT-4136 align is_binary() function with all other types
Client: Compiler (general)
Patch: Jens Geyer
----
> align is_binary() function with all other types
> -----------------------------------------------
>
> Key: THRIFT-4136
> URL: https://issues.apache.org/jira/browse/THRIFT-4136
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Jens Geyer
> Assignee: Jens Geyer
>
> Similar to {{is_string()}} the {{is_binary()}} method should be virtual and implemented at {{t_type}}. This simplifies the code and reduces possibilities for making technically wrong casts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)