You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/30 19:11:47 UTC
[GitHub] [maven-plugin-tools] kwin opened a new pull request, #183: [MPLUGIN-425] Generate version ranges for automatically detected minimal
kwin opened a new pull request, #183:
URL: https://github.com/apache/maven-plugin-tools/pull/183
java version (derived from class version)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] kwin merged pull request #183: [MPLUGIN-425] Generate version ranges for automatically detected minimal
Posted by GitBox <gi...@apache.org>.
kwin merged PR #183:
URL: https://github.com/apache/maven-plugin-tools/pull/183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #183: [MPLUGIN-425] Generate version ranges for automatically detected minimal
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #183:
URL: https://github.com/apache/maven-plugin-tools/pull/183#discussion_r1036396906
##########
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java:
##########
@@ -448,14 +448,15 @@ private String getRequiredJavaVersion( PluginToolsRequest request )
{
return requiredJavaVersion;
}
- String requiredJavaVersion = request.getRequiredJavaVersion();
- if ( requiredJavaVersion == null )
+ String minRequiredJavaVersion = request.getRequiredJavaVersion();
+ if ( minRequiredJavaVersion == null )
Review Comment:
Can the version given in the request be a range ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org