Modifications to SAAJ API impl.

[Jarek Gawor <ga...@mcs.anl.gov>]

Hi,

Here are my proposed updates the message/ directory. This mainly solves
problems where SOAPBodyElements and SOAPHeaderElements were stored in two
different lists - MessageElement.children and
SOAPBody.bodyElements/SOAPHeader.headers lists. Because of that and
depending on which API you used it, different information was returned about
the number of headers, children, etc. The proposed changes get rid of the
local SOAPBody.bodyElements/SOAPHeader.headers lists and instead now all
that information is stored in the MessageElement.children list. Also some
changes were made to make things more consistent, added better checking for
null values, and formatting.
Only one API change was made: the MessageElement.getChildren() return type
was changed to 'List' instead of 'ArrayList'. Other notable changes:

MessageElement.setDirty() now propagates dirty setting to its parent. Also,
setDirty() is now called when nodes are removed. 

MessageElement.setParent() is a bit smarter now. It ensures addChild() is
called once if setParent() is called twice with the same parent, it calls
removeChild() on the old parent if parent is different from the current one.

Please review the changes if you can and let me know if I should commit this
(all tests pass for me)

Jarek

Re: Modifications to SAAJ API impl.

[Davanum Srinivas <da...@gmail.com>]

go for it...next time for large changes like this one, can you please
minimize the code formatting? makes it easier to review the diff.

thanks,
dims

On Mon, 21 Jun 2004 14:28:28 -0400, Jarek Gawor <ga...@mcs.anl.gov> wrote:
> 
> Hi,
> 
> Here are my proposed updates the message/ directory. This mainly solves
> problems where SOAPBodyElements and SOAPHeaderElements were stored in two
> different lists - MessageElement.children and
> SOAPBody.bodyElements/SOAPHeader.headers lists. Because of that and
> depending on which API you used it, different information was returned about
> the number of headers, children, etc. The proposed changes get rid of the
> local SOAPBody.bodyElements/SOAPHeader.headers lists and instead now all
> that information is stored in the MessageElement.children list. Also some
> changes were made to make things more consistent, added better checking for
> null values, and formatting.
> Only one API change was made: the MessageElement.getChildren() return type
> was changed to 'List' instead of 'ArrayList'. Other notable changes:
> 
> MessageElement.setDirty() now propagates dirty setting to its parent. Also,
> setDirty() is now called when nodes are removed.
> 
> MessageElement.setParent() is a bit smarter now. It ensures addChild() is
> called once if setParent() is called twice with the same parent, it calls
> removeChild() on the old parent if parent is different from the current one.
> 
> Please review the changes if you can and let me know if I should commit this
> (all tests pass for me)
> 
> Jarek
> 
> 
> 
> message.diff - 52K
> 


-- 
Davanum Srinivas - http://webservices.apache.org/~dims/