[GitHub] erisu edited a comment on issue #486: GH-485: (android) Replace deprecated "compile" with "implementation"

[GitBox <gi...@apache.org>]

erisu edited a comment on issue #486: GH-485: (android) Replace deprecated "compile" with "implementation"
URL: https://github.com/apache/cordova-android/pull/486#issuecomment-418975559
 
 
   @janpio 
   #### Initial Questions
   - Do we have a Gradle versions requirement for Cordova projects? 
   - How far back do we support? 
   
   #### Overview
   The later Android Studio should not complain.
   
   `compile` had been deprecated from Gradle since 3.4, but still exists for backwards compatibility.
   
   `implementation` and `api` was introduced to replace `compile`. The key differences is that `implementation` dependencies are identified as internal while `api` are external. 
   
   > implementation configuration should be used to declare dependencies which are internal to the component.
   
   > Dependencies appearing in the api configurations will be transitively exposed to consumers of the library, and as such will appear on the compile classpath of consumers. 
   >
   > Dependencies found in the implementation configuration will, on the other hand, not be exposed to consumers, and therefore not leak into the consumers' compile classpath. 
   
   
   https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_configurations_graph
   
   #### Final Question
   - Should we suppose the ability where the user can identify the framework library as `implementation` or `api`?
   
   In most cases, `implementation` should be enough.
   
   With this in mind, is there any concern for merging this PR or should we improve to support identify the type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org