You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "hang8929201 (via GitHub)" <gi...@apache.org> on 2024/07/16 08:28:56 UTC
[PR] [common] Add some methods to RoaringBitmap32 [paimon]
hang8929201 opened a new pull request, #3760:
URL: https://github.com/apache/paimon/pull/3760
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
Add and/or operation to RoaringBitmap32.
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [common] Add some methods to RoaringBitmap32 [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3760:
URL: https://github.com/apache/paimon/pull/3760#discussion_r1679177577
##########
paimon-common/src/main/java/org/apache/paimon/utils/RoaringBitmap32.java:
##########
@@ -39,6 +40,10 @@ public RoaringBitmap32() {
this.roaringBitmap = new RoaringBitmap();
}
+ public RoaringBitmap32(RoaringBitmap roaringBitmap) {
Review Comment:
We should not support this, `RoaringBitmap` should be hided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [common] Add some methods to RoaringBitmap32 [paimon]
Posted by "hang8929201 (via GitHub)" <gi...@apache.org>.
hang8929201 commented on code in PR #3760:
URL: https://github.com/apache/paimon/pull/3760#discussion_r1679356961
##########
paimon-common/src/main/java/org/apache/paimon/utils/RoaringBitmap32.java:
##########
@@ -39,6 +40,10 @@ public RoaringBitmap32() {
this.roaringBitmap = new RoaringBitmap();
}
+ public RoaringBitmap32(RoaringBitmap roaringBitmap) {
Review Comment:
okay, can I just change it to private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [common] Add some methods to RoaringBitmap32 [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #3760:
URL: https://github.com/apache/paimon/pull/3760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [common] Add and/or operation to RoaringBitmap32 [paimon]
Posted by "hang8929201 (via GitHub)" <gi...@apache.org>.
hang8929201 closed pull request #3760: [common] Add and/or operation to RoaringBitmap32
URL: https://github.com/apache/paimon/pull/3760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [common] Add some methods to RoaringBitmap32 [paimon]
Posted by "hang8929201 (via GitHub)" <gi...@apache.org>.
hang8929201 commented on PR #3760:
URL: https://github.com/apache/paimon/pull/3760#issuecomment-2230319703
add more methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org