You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/05/11 22:48:22 UTC

Review Request 47269: GEODE-1376: remove hydra.Log from DUnitLauncher

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47269/
-----------------------------------------------------------

Review request for geode and Dan Smith.


Bugs: GEODE-1376
    https://issues.apache.org/jira/browse/GEODE-1376


Repository: geode


Description
-------

GEODE-1376: remove hydra.Log from DUnitLauncher

* remove call to Log.createLogWriter to prevent hydra.HydraRuntimeException: Log writer has already been created
* remove use of hydra.Log from HADispatcherDUnitTest
* cleanup imports


Diffs
-----

  geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 4e7095c 
  geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/ha/HADispatcherDUnitTest.java aaf8b6f 

Diff: https://reviews.apache.org/r/47269/diff/


Testing
-------

precheckin


Thanks,

Kirk Lund


Re: Review Request 47269: GEODE-1376: remove hydra.Log from DUnitLauncher

Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47269/#review132920
-----------------------------------------------------------


Ship it!




Ship It!

- Jinmei Liao


On May 11, 2016, 10:48 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47269/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 10:48 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-1376
>     https://issues.apache.org/jira/browse/GEODE-1376
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1376: remove hydra.Log from DUnitLauncher
> 
> * remove call to Log.createLogWriter to prevent hydra.HydraRuntimeException: Log writer has already been created
> * remove use of hydra.Log from HADispatcherDUnitTest
> * cleanup imports
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 4e7095c 
>   geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/ha/HADispatcherDUnitTest.java aaf8b6f 
> 
> Diff: https://reviews.apache.org/r/47269/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Re: Review Request 47269: GEODE-1376: remove hydra.Log from DUnitLauncher

Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47269/#review132787
-----------------------------------------------------------


Ship it!




Ship It!

- Dan Smith


On May 11, 2016, 10:48 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47269/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 10:48 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-1376
>     https://issues.apache.org/jira/browse/GEODE-1376
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1376: remove hydra.Log from DUnitLauncher
> 
> * remove call to Log.createLogWriter to prevent hydra.HydraRuntimeException: Log writer has already been created
> * remove use of hydra.Log from HADispatcherDUnitTest
> * cleanup imports
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 4e7095c 
>   geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/ha/HADispatcherDUnitTest.java aaf8b6f 
> 
> Diff: https://reviews.apache.org/r/47269/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Re: Review Request 47269: GEODE-1376: remove hydra.Log from DUnitLauncher

Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47269/#review132886
-----------------------------------------------------------


Ship it!




Ship It!

- Jens Deppe


On May 11, 2016, 10:48 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47269/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 10:48 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-1376
>     https://issues.apache.org/jira/browse/GEODE-1376
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1376: remove hydra.Log from DUnitLauncher
> 
> * remove call to Log.createLogWriter to prevent hydra.HydraRuntimeException: Log writer has already been created
> * remove use of hydra.Log from HADispatcherDUnitTest
> * cleanup imports
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 4e7095c 
>   geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/ha/HADispatcherDUnitTest.java aaf8b6f 
> 
> Diff: https://reviews.apache.org/r/47269/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>