You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/05 17:05:27 UTC
[GitHub] [flink] StephanEwen opened a new pull request #13953: [FLINK-19384][core] Add common permissive exception signatures to all methods of Source.
StephanEwen opened a new pull request #13953:
URL: https://github.com/apache/flink/pull/13953
## What is the purpose of the change
This makes the exception signatures consistent within the class and with the exception philisophy in other API classes, like transformation functions: Allow users to simply throw or forward any type of checked exceptions.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **yes** - Changes exception signatures on `@PublicEvolving` classes.
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13953: [FLINK-19384][core] Add common permissive exception signatures to all methods of Source.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13953:
URL: https://github.com/apache/flink/pull/13953#issuecomment-722575467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff45572d744da10f64999a4a7be7bab980792904",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ff45572d744da10f64999a4a7be7bab980792904",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff45572d744da10f64999a4a7be7bab980792904 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13953: [FLINK-19384][core] Add common permissive exception signatures to all methods of Source.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13953:
URL: https://github.com/apache/flink/pull/13953#issuecomment-722575467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff45572d744da10f64999a4a7be7bab980792904",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9117",
"triggerID" : "ff45572d744da10f64999a4a7be7bab980792904",
"triggerType" : "PUSH"
}, {
"hash" : "44291cc6c9dc6a8d3457426b428d3d1775a11ddb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9185",
"triggerID" : "44291cc6c9dc6a8d3457426b428d3d1775a11ddb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff45572d744da10f64999a4a7be7bab980792904 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9117)
* 44291cc6c9dc6a8d3457426b428d3d1775a11ddb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9185)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13953: [FLINK-19384][core] Add common permissive exception signatures to all methods of Source.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13953:
URL: https://github.com/apache/flink/pull/13953#issuecomment-722575467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff45572d744da10f64999a4a7be7bab980792904",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9117",
"triggerID" : "ff45572d744da10f64999a4a7be7bab980792904",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff45572d744da10f64999a4a7be7bab980792904 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9117)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13953: [FLINK-19384][core] Add common permissive exception signatures to all methods of Source.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13953:
URL: https://github.com/apache/flink/pull/13953#issuecomment-722510980
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ff45572d744da10f64999a4a7be7bab980792904 (Thu Nov 05 17:08:00 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19384).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13953: [FLINK-19384][core] Add common permissive exception signatures to all methods of Source.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13953:
URL: https://github.com/apache/flink/pull/13953#issuecomment-722575467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff45572d744da10f64999a4a7be7bab980792904",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9117",
"triggerID" : "ff45572d744da10f64999a4a7be7bab980792904",
"triggerType" : "PUSH"
}, {
"hash" : "44291cc6c9dc6a8d3457426b428d3d1775a11ddb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "44291cc6c9dc6a8d3457426b428d3d1775a11ddb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff45572d744da10f64999a4a7be7bab980792904 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9117)
* 44291cc6c9dc6a8d3457426b428d3d1775a11ddb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen closed pull request #13953: [FLINK-19384][core] Add common permissive exception signatures to all methods of Source.
Posted by GitBox <gi...@apache.org>.
StephanEwen closed pull request #13953:
URL: https://github.com/apache/flink/pull/13953
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org