You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andres de la Peña (Jira)" <ji...@apache.org> on 2022/08/23 17:08:00 UTC

[jira] [Comment Edited] (CASSANDRA-17849) Test failure: org.apache.cassandra.tools.StandaloneUpgraderOnSStablesTest.testUpgradeSnapshot

    [ https://issues.apache.org/jira/browse/CASSANDRA-17849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583732#comment-17583732 ] 

Andres de la Peña edited comment on CASSANDRA-17849 at 8/23/22 5:07 PM:
------------------------------------------------------------------------

Git bisect points to CASSANDRA-13010 as the introducer of the test failure.

Its associated commit, [e7c9ac05f99cc8a5ee958169c49326e85ab4b25b|https://github.com/apache/cassandra/commit/e7c9ac05f99cc8a5ee958169c49326e85ab4b25b], consistently breaks CI for the tests, as it can bee seen in [this repeated run|https://app.circleci.com/pipelines/github/adelapena/cassandra/2008/workflows/2233dcbc-f0de-4888-b346-92a5bf1a0649].

Indeed, the pre-commit CI runs provided in CASSANDRA-13010 also hit the failure, [here|https://app.circleci.com/pipelines/github/instaclustr/cassandra/1216/workflows/19d0beb7-310b-4170-8863-608bff7adb40] and [here|https://app.circleci.com/pipelines/github/instaclustr/cassandra/1216/workflows/5ed6064f-f72d-4b44-bd0f-a47885e10de1].

The previous commit, [c4b1c0614e42b4ea2064822d31c28aa5d4f1450a|https://github.com/apache/cassandra/commit/c4b1c0614e42b4ea2064822d31c28aa5d4f1450a], doesn't break CI, as it can bee seen in [this repeated run|https://app.circleci.com/pipelines/github/adelapena/cassandra/2009/workflows/e32acbf3-05e2-4cdb-a60d-154aa4326f78].

The CircleCI config for the repeated runs has been generated with:
{code:java}
.circleci/generate.sh -m \
  -e REPEATED_UTEST_TARGET=testsome \
  -e REPEATED_UTEST_COUNT=100 \
  -e REPEATED_UTEST_CLASS=org.apache.cassandra.tools.StandaloneUpgraderOnSStablesTest \
  -e REPEATED_UTEST_METHODS=testUpgradeSnapshot
{code}
In case someone is curious, the full set of bisect runs can be seen [here|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=flaky-testUpgradeSnapshot-trunk-bisect]. They have been generated with [this script|https://gist.github.com/adelapena/35463e5528873224c13f7e2d44a56922], with these arguments:
{code:java}
git bisect start
git bisect good 39e89fd636ee4343eb2201820da87881cbc749e2
git bisect bad b70fe08eab2ff31efb1fd4b4b2fa05a22b2cde1c
git bisect run ~/bisect.sh \
  -r origin \
  -b flaky-testUpgradeSnapshot-trunk-bisect \
  -m \
  -e REPEATED_UTEST_TARGET=testsome \
  -e REPEATED_UTEST_COUNT=100 \
  -e REPEATED_UTEST_CLASS=org.apache.cassandra.tools.StandaloneUpgraderOnSStablesTest \
  -e REPEATED_UTEST_METHODS=testUpgradeSnapshot
git bisect reset
{code}


was (Author: adelapena):
Git bisect points to CASSANDRA-13010 as the introducer of the test failure.

Its associated commit, [e7c9ac05f99cc8a5ee958169c49326e85ab4b25b|https://github.com/apache/cassandra/commit/e7c9ac05f99cc8a5ee958169c49326e85ab4b25b], consistently breaks CI for the tests, as it can bee seen in [this repeated run|https://app.circleci.com/pipelines/github/adelapena/cassandra/2008/workflows/2233dcbc-f0de-4888-b346-92a5bf1a0649].

Indeed, the pre-commit CI runs provided in CASSANDRA-13010 also hit the failure, [here|https://app.circleci.com/pipelines/github/instaclustr/cassandra/1216/workflows/19d0beb7-310b-4170-8863-608bff7adb40] and [here|https://app.circleci.com/pipelines/github/instaclustr/cassandra/1216/workflows/5ed6064f-f72d-4b44-bd0f-a47885e10de1].

The previous commit, [c4b1c0614e42b4ea2064822d31c28aa5d4f1450a|https://github.com/apache/cassandra/commit/c4b1c0614e42b4ea2064822d31c28aa5d4f1450a], doesn't break CI, as it can bee seen in [this repeated run|https://app.circleci.com/pipelines/github/adelapena/cassandra/2009/workflows/e32acbf3-05e2-4cdb-a60d-154aa4326f78].

The CircleCI config for the repeated runs has been generated with:
{code:java}
.circleci/generate.sh -m \
  -e REPEATED_UTEST_TARGET=testsome \
  -e REPEATED_UTEST_COUNT=100 \
  -e REPEATED_UTEST_CLASS=org.apache.cassandra.tools.StandaloneUpgraderOnSStablesTest \
  -e REPEATED_UTEST_METHODS=testUpgradeSnapshot
{code}
In case someone is curious, the full set of bisect runs can be seen [here|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=flaky-testUpgradeSnapshot-trunk-bisect]. They have been generated with [this script|https://gist.github.com/adelapena/35463e5528873224c13f7e2d44a56922], with these arguments:
{code:java}
git bisect start
git bisect good 39e89fd636ee4343eb2201820da87881cbc749e2
git bisect bad b70fe08eab2ff31efb1fd4b4b2fa05a22b2cde1c
git bisect run ~/bisect.sh -l \
  -e REPEATED_UTEST_TARGET=testsome \
  -e REPEATED_UTEST_COUNT=10 \
  -e REPEATED_UTEST_CLASS=org.apache.cassandra.cql3.PagingTest \
  -e REPEATED_UTEST_METHODS=testPaging
git bisect reset
{code}

> Test failure: org.apache.cassandra.tools.StandaloneUpgraderOnSStablesTest.testUpgradeSnapshot
> ---------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17849
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17849
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Andres de la Peña
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 4.x
>
>
> The test {{org.apache.cassandra.tools.StandaloneUpgraderOnSStablesTest.testUpgradeSnapshot}} is flaky on trunk, [as reported by Butler|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-trunk/failure/org.apache.cassandra.tools/StandaloneUpgraderOnSStablesTest/testUpgradeSnapshot]:
> * https://ci-cassandra.apache.org/job/Cassandra-trunk/1287/testReport/org.apache.cassandra.tools/StandaloneUpgraderOnSStablesTest/testUpgradeSnapshot/
> * https://ci-cassandra.apache.org/job/Cassandra-trunk/1286/testReport/org.apache.cassandra.tools/StandaloneUpgraderOnSStablesTest/testUpgradeSnapshot/
> * https://ci-cassandra.apache.org/job/Cassandra-trunk/1285/testReport/org.apache.cassandra.tools/StandaloneUpgraderOnSStablesTest/testUpgradeSnapshot/
> {code}
> Failed 1 times in the last 27 runs. Flakiness: 3%, Stability: 96%
> Error Message
> Timeout occurred. Please note the time in the report does not reflect the time until the timeout.
> Stacktrace
> junit.framework.AssertionFailedError: Timeout occurred. Please note the time in the report does not reflect the time until the timeout.
> 	at java.util.Vector.forEach(Vector.java:1277)
> 	at java.util.Vector.forEach(Vector.java:1277)
> 	at java.util.Vector.forEach(Vector.java:1277)
> 	at org.apache.cassandra.anttasks.TestHelper.execute(TestHelper.java:53)
> 	at java.util.Vector.forEach(Vector.java:1277)
> {code}
> It seems that the test gets stuck until JUnit timeouts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org