You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2014/05/13 23:18:38 UTC
[jclouds] Updates BaseOpenStackMockTest (#365)
This PR updates the BaseOpenStackMock test to rely on Guava types, and also removes the Content-Type header from MockResponses.
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds fix-openstack-mock
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/365
-- Commit Summary --
* Fix Accept header and removed Content-Type from common headers
-- File Changes --
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/v2_0/internal/BaseOpenStackMockTest.java (4)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/365.patch
https://github.com/jclouds/jclouds/pull/365.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/365
Re: [jclouds] Updates BaseOpenStackMockTest (#365)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #801](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/801/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/365#issuecomment-43021591
Re: [jclouds] Updates BaseOpenStackMockTest (#365)
Posted by Zack Shoylev <no...@github.com>.
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/365#issuecomment-43016101
Re: [jclouds] Updates BaseOpenStackMockTest (#365)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1271](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1271/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/365#issuecomment-43023136
Re: [jclouds] Updates BaseOpenStackMockTest (#365)
Posted by Zack Shoylev <no...@github.com>.
Thanks, @jdaggett
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/365#issuecomment-43796032
Re: [jclouds] Updates BaseOpenStackMockTest (#365)
Posted by Jeremy Daggett <no...@github.com>.
Closed #365.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/365#event-123125254
Re: [jclouds] Updates BaseOpenStackMockTest (#365)
Posted by Jeremy Daggett <no...@github.com>.
@zack-shoylev No, closing since it has been [merged](
https://github.com/jclouds/jclouds/commit/a53438159a114fb2c42faee5b3e82b21000a8665).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/365#issuecomment-43690687
Re: [jclouds] Updates BaseOpenStackMockTest (#365)
Posted by Zack Shoylev <no...@github.com>.
This is still open?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/365#issuecomment-43689871
Re: [jclouds] Updates BaseOpenStackMockTest (#365)
Posted by Andrew Phillips <no...@github.com>.
+1 from me, too. Thanks, @jdaggett!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/365#issuecomment-43036518