You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2017/09/25 12:20:18 UTC
[GitHub] carbondata pull request #1382: [CARBONDATA-1514] Sort Column Property is not...
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/carbondata/pull/1382
[CARBONDATA-1514] Sort Column Property is not getting added in case of alter operation
**Problem:**: Sort Column Property is not getting added in case of alter operation
**Solution**: Need to add sort column if use has added in alter operation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kumarvishal09/incubator-carbondata FixedSortColumnIssueInCaseOfAlter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1382.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1382
----
commit f6474eb28b2232075729f29c64c6772b2ea33d72
Author: kumarvishal <ku...@gmail.com>
Date: 2017-09-25T12:15:10Z
FixedColumnIssueInCaseOfAlter
----
---
[GitHub] carbondata issue #1382: [CARBONDATA-1514] Sort Column Property is not gettin...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1382
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/163/
---
[GitHub] carbondata pull request #1382: [CARBONDATA-1514] Sort Column Property is not...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1382#discussion_r141365644
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ---
@@ -190,6 +190,14 @@ class AlterTableColumnSchemaGenerator(
val LOGGER = LogServiceFactory.getLogService(this.getClass.getName)
+ def checkSortColumn(columnName: String): Boolean = {
+ val sortColumns = alterTableModel.tableProperties.get("sort_columns")
+ if(sortColumns.isDefined) {
+ sortColumns.get.contains(columnName)
+ } else {
+ true
--- End diff --
by default sort column is enabled for all the dimension column, if user is not providing any column property then it is true
---
[GitHub] carbondata issue #1382: [CARBONDATA-1514] Sort Column Property is not gettin...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1382
LGTM
---
[GitHub] carbondata issue #1382: [CARBONDATA-1514] Sort Column Property is not gettin...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1382
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/919/
---
[GitHub] carbondata issue #1382: [CARBONDATA-1514] Sort Column Property is not gettin...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1382
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/287/
---
[GitHub] carbondata pull request #1382: [CARBONDATA-1514] Sort Column Property is not...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1382#discussion_r141363100
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ---
@@ -226,7 +234,7 @@ class AlterTableColumnSchemaGenerator(
-1,
field.precision,
field.scale,
- field.schemaOrdinal + existingColsSize)
+ field.schemaOrdinal + existingColsSize, false)
--- End diff --
each parameter should be in one line
---
[GitHub] carbondata pull request #1382: [CARBONDATA-1514] Sort Column Property is not...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1382#discussion_r141362722
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ---
@@ -209,7 +217,7 @@ class AlterTableColumnSchemaGenerator(
-1,
field.precision,
field.scale,
- field.schemaOrdinal + existingColsSize)
+ field.schemaOrdinal + existingColsSize, checkSortColumn(field.name.getOrElse(field.column)))
--- End diff --
each parameter should be in one line
---
[GitHub] carbondata pull request #1382: [CARBONDATA-1514] Sort Column Property is not...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1382#discussion_r141363530
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ---
@@ -190,6 +190,14 @@ class AlterTableColumnSchemaGenerator(
val LOGGER = LogServiceFactory.getLogService(this.getClass.getName)
+ def checkSortColumn(columnName: String): Boolean = {
+ val sortColumns = alterTableModel.tableProperties.get("sort_columns")
+ if(sortColumns.isDefined) {
+ sortColumns.get.contains(columnName)
+ } else {
+ true
--- End diff --
Shouldn't it be false?
---
[GitHub] carbondata issue #1382: [CARBONDATA-1514] Sort Column Property is not gettin...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1382
@kumarvishal09 SDV testcase is failed, please check
---
[GitHub] carbondata pull request #1382: [CARBONDATA-1514] Sort Column Property is not...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1382
---
[GitHub] carbondata pull request #1382: [CARBONDATA-1514] Sort Column Property is not...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1382#discussion_r141363284
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ---
@@ -190,6 +190,14 @@ class AlterTableColumnSchemaGenerator(
val LOGGER = LogServiceFactory.getLogService(this.getClass.getName)
+ def checkSortColumn(columnName: String): Boolean = {
--- End diff --
change function name to `isSortColumn`
---
[GitHub] carbondata pull request #1382: [CARBONDATA-1514] Sort Column Property is not...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1382#discussion_r141366405
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ---
@@ -226,7 +234,7 @@ class AlterTableColumnSchemaGenerator(
-1,
field.precision,
field.scale,
- field.schemaOrdinal + existingColsSize)
+ field.schemaOrdinal + existingColsSize, false)
--- End diff --
ok
---
[GitHub] carbondata pull request #1382: [CARBONDATA-1514] Sort Column Property is not...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1382#discussion_r141365697
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ---
@@ -190,6 +190,14 @@ class AlterTableColumnSchemaGenerator(
val LOGGER = LogServiceFactory.getLogService(this.getClass.getName)
+ def checkSortColumn(columnName: String): Boolean = {
--- End diff --
ok
---
[GitHub] carbondata issue #1382: [CARBONDATA-1514] Sort Column Property is not gettin...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1382
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/366/
---
[GitHub] carbondata issue #1382: [CARBONDATA-1514] Sort Column Property is not gettin...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1382
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/242/
---
[GitHub] carbondata issue #1382: [CARBONDATA-1514] Sort Column Property is not gettin...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1382
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/994/
---