You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/30 02:09:39 UTC
[GitHub] [shardingsphere] tuichenchuxin commented on a diff in pull request #18006: add create view validator
tuichenchuxin commented on code in PR #18006:
URL: https://github.com/apache/shardingsphere/pull/18006#discussion_r884369944
##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/ddl/impl/ShardingCreateViewStatementValidator.java:
##########
@@ -35,11 +45,56 @@ public final class ShardingCreateViewStatementValidator extends ShardingDDLState
@Override
public void preValidate(final ShardingRule shardingRule, final SQLStatementContext<CreateViewStatement> sqlStatementContext,
final List<Object> parameters, final ShardingSphereDatabase database) {
- // TODO prevent if has need merge select.
+ Optional<SelectStatement> selectStatement = sqlStatementContext.getSqlStatement().getSelect();
+ if (selectStatement.isPresent()) {
Review Comment:
Thank you. Done.
##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/ddl/impl/ShardingCreateViewStatementValidator.java:
##########
@@ -35,11 +45,56 @@ public final class ShardingCreateViewStatementValidator extends ShardingDDLState
@Override
public void preValidate(final ShardingRule shardingRule, final SQLStatementContext<CreateViewStatement> sqlStatementContext,
final List<Object> parameters, final ShardingSphereDatabase database) {
- // TODO prevent if has need merge select.
+ Optional<SelectStatement> selectStatement = sqlStatementContext.getSqlStatement().getSelect();
+ if (selectStatement.isPresent()) {
+ TableExtractor extractor = new TableExtractor();
+ extractor.extractTablesFromSelect(selectStatement.get());
+ Collection<SimpleTableSegment> tableSegments = extractor.getRewriteTables();
+ for (SimpleTableSegment each : tableSegments) {
+ String logicTable = each.getTableName().getIdentifier().getValue();
+ if (shardingRule.isShardingTable(logicTable)) {
+ validateShardingTableAndViewIsBind(shardingRule, sqlStatementContext.getSqlStatement().getView().getTableName().getIdentifier().getValue(), logicTable);
Review Comment:
Thank you. Done.
##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/ddl/impl/ShardingCreateViewStatementValidator.java:
##########
@@ -35,11 +45,56 @@ public final class ShardingCreateViewStatementValidator extends ShardingDDLState
@Override
public void preValidate(final ShardingRule shardingRule, final SQLStatementContext<CreateViewStatement> sqlStatementContext,
final List<Object> parameters, final ShardingSphereDatabase database) {
- // TODO prevent if has need merge select.
+ Optional<SelectStatement> selectStatement = sqlStatementContext.getSqlStatement().getSelect();
+ if (selectStatement.isPresent()) {
+ TableExtractor extractor = new TableExtractor();
+ extractor.extractTablesFromSelect(selectStatement.get());
+ Collection<SimpleTableSegment> tableSegments = extractor.getRewriteTables();
+ for (SimpleTableSegment each : tableSegments) {
+ String logicTable = each.getTableName().getIdentifier().getValue();
+ if (shardingRule.isShardingTable(logicTable)) {
+ validateShardingTableAndViewIsBind(shardingRule, sqlStatementContext.getSqlStatement().getView().getTableName().getIdentifier().getValue(), logicTable);
+ }
+ }
+ }
}
@Override
public void postValidate(final ShardingRule shardingRule, final SQLStatementContext<CreateViewStatement> sqlStatementContext, final List<Object> parameters,
final ShardingSphereDatabase database, final ConfigurationProperties props, final RouteContext routeContext) {
+ Optional<SelectStatement> selectStatement = sqlStatementContext.getSqlStatement().getSelect();
+ selectStatement.ifPresent(statement -> validateNeedsMerge(statement, routeContext));
Review Comment:
Thank you. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org