[GitHub] cckellogg commented on a change in pull request #2560: [proxy][functions] Issue #2154: proxy should be able to forward rest requests to function workers cluster

[GitBox <gi...@apache.org>]

cckellogg commented on a change in pull request #2560: [proxy][functions] Issue #2154: proxy should be able to forward rest requests to function workers cluster
URL: https://github.com/apache/incubator-pulsar/pull/2560#discussion_r216849455
 
 

 ##########
 File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/AdminProxyHandler.java
 ##########
 @@ -122,7 +125,16 @@ protected HttpClient newHttpClient() {
     protected String rewriteTarget(HttpServletRequest request) {
         StringBuilder url = new StringBuilder();
 
-        if (isBlank(brokerWebServiceUrl)) {
+        boolean isFunctionsRestRequest = false;
 
 Review comment:
   maybe move this to a method isFunctionsRequest(HttpServletRequest request)?
   or 
   boolean isFunctionsRestRequest = requestUri.startsWith("/admin/v2/functions") || requestUri.startsWith("/admin/functions");

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services