You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "qijiale76 (via GitHub)" <gi...@apache.org> on 2023/08/07 11:08:41 UTC
[GitHub] [incubator-uniffle] qijiale76 commented on a diff in pull request #1112: [#1051] fix(mr): Ensure configurations in both mapred-site.xml and dynamic_client.conf take effect.
qijiale76 commented on code in PR #1112:
URL: https://github.com/apache/incubator-uniffle/pull/1112#discussion_r1285722049
##########
client-mr/core/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java:
##########
@@ -153,9 +141,13 @@ public Thread newThread(Runnable r) {
}
});
- JobConf extraConf = new JobConf();
+ // set loadDefaults to false, rss_conf.xml should only contain conf of RSS,
+ // Hadoop conf is not necessary.
+ Configuration extraConf = new JobConf(false);
Review Comment:
set `loadDefaults` to false, make rss_conf.xml has only `mapreduce.rss.*` properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org