[I] Cover the computing-unit actions service and result-panel template [texera]

["aglinxinyuan (via GitHub)" <gi...@apache.org>]

aglinxinyuan opened a new issue, #8030:
URL: https://github.com/apache/texera/issues/8030

   ### Task Summary
   
   Two small frontend gaps, and unusually for this stage of the codebase the whole advertised gap is real — no unreachable partials in either file.
   
   | File | Coverage |
   |---|---|
   | `common/service/computing-unit/computing-unit-actions/computing-unit-actions.service.ts` | 90.9% — 0 missed + 3 partial of 33 |
   | `workspace/component/result-panel/result-panel.component.html` | 94.3% — 1 missed + 2 partial of 53 |
   
   **The template is a function-counter case, which is the part worth acting on.** It sits at `FNF 7 / FNH 4` because its existing spec calls `handleEndDrag(...)` and `handleStartDrag()` **directly on the component**, leaving the template's own bindings at `FNDA:0`. They look covered and are not. Driving them through the rendered element is what closes them — and that pattern has now turned up seven times in this codebase, so always report FNF/FNH rather than lines alone.
   
   Traps:
   
   1. **lcov's line and branch records do not always coincide.** In the service, lines 101 and 109 carry `BRDA` records but **no `DA`** record, because v8 attributes the `DA` for the whole `modalService.confirm({...})` statement to line 99. A count restricted to `DA` lines and a `union(DA, BRDA)` count therefore disagree. State which rule you are using, or the arithmetic will not reproduce.
   2. **A pre-existing test can pass an arm-swap on its own.** "Renders the resize handles when the panel is docked" survives a swap of the `nzDirections` arm, because it never distinguishes the two directions. Worth knowing before assuming an existing test constrains what its name suggests.
   3. A fresh worktree has no `frontend/node_modules` — do a **real install** (`node .yarn/releases/yarn-4.14.1.cjs install --immutable --inline-builds`, ~35s off the Berry cache). Do **not** junction it from the main checkout: a later recursive delete follows the junction, empties the main checkout's dependencies, and reaches through yarn's portal link into `frontend/tools/jschardet-stub`.
   4. `ng test --coverage` writes no lcov at all if any test fails; it lands at `frontend/coverage/gui/lcov.info`. `frontend/junit.xml` is regenerated every run and is not gitignored, so it fails the licence-header check if committed.
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Cover the computing-unit actions service and result-panel template [texera]

["aglinxinyuan (via GitHub)" <gi...@apache.org>]

aglinxinyuan closed issue #8030: Cover the computing-unit actions service and result-panel template
URL: https://github.com/apache/texera/issues/8030


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org