You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ch...@apache.org on 2018/05/09 19:05:51 UTC
[4/6] mesos git commit: Removed unnecessary gRPC build flags in
libprocess.
Removed unnecessary gRPC build flags in libprocess.
The `-Wno-deprecated-declarations` and `-Wno-unused-function` flags are
no longer required to build the bundled gRPC 1.10.0.
Review: https://reviews.apache.org/r/67018
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/04313d07
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/04313d07
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/04313d07
Branch: refs/heads/master
Commit: 04313d07807e6986bfe1f1cc83c3f04e0b7f5e33
Parents: 89adbf2
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Authored: Tue May 8 15:27:11 2018 -0700
Committer: Chun-Hung Hsiao <ch...@mesosphere.io>
Committed: Wed May 9 12:05:13 2018 -0700
----------------------------------------------------------------------
3rdparty/libprocess/3rdparty/Makefile.am | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/04313d07/3rdparty/libprocess/3rdparty/Makefile.am
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/Makefile.am b/3rdparty/libprocess/3rdparty/Makefile.am
index 7fb77f8..f7f0bed 100644
--- a/3rdparty/libprocess/3rdparty/Makefile.am
+++ b/3rdparty/libprocess/3rdparty/Makefile.am
@@ -211,18 +211,10 @@ LIB_GRPC = $(GRPC)/libs/opt/libgrpc++.a \
$(LIB_GRPC): $(GRPC)-build-stamp
-# NOTE: The `-Wno-deprecated-declarations` flag is added so that gRPC
-# can be built with OpenSSL 1.1.0. See:
-# https://github.com/grpc/grpc/pull/11496
-# NOTE: The `-Wno-unused-function` flag is added to address errors when
-# compling `src/core/tsi/ssl_transport_security.c`. See:
-# https://github.com/grpc/grpc/pull/11675
$(GRPC)-build-stamp: $(GRPC)-stamp \
$(PROTOBUF)-build-stamp
cd $(GRPC) && \
- CPPFLAGS="-Wno-deprecated-declarations \
- -Wno-unused-function \
- $(PROTOBUF_INCLUDE_FLAGS) \
+ CPPFLAGS="$(PROTOBUF_INCLUDE_FLAGS) \
$(SSL_INCLUDE_FLAGS) \
$(ZLIB_INCLUDE_FLAGS)" \
LDFLAGS="$(PROTOBUF_LINKER_FLAGS) \