You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/11/20 12:21:19 UTC
Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-869
https://issues.apache.org/jira/browse/LENS-869
Repository: lens
Description
-------
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
Diff: https://reviews.apache.org/r/40537/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107580
-----------------------------------------------------------
Ship it!
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 98)
<https://reviews.apache.org/r/40537/#comment166802>
Seems a typo in the constant name.
- Amareshwari Sriramadasu
On Nov. 23, 2015, 12:47 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 12:47 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-869
> https://issues.apache.org/jira/browse/LENS-869
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
> lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 6dcb2d79420b29fa85bd115f375c0c7e42c50834
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
> lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
>
> Diff: https://reviews.apache.org/r/40537/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
> [INFO] Lens .............................................. SUCCESS [2.938s]
> [INFO] Lens API .......................................... SUCCESS [22.467s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
> [INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
> [INFO] Lens DB storage ................................... SUCCESS [22.474s]
> [INFO] Lens Query Library ................................ SUCCESS [16.592s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
> [INFO] Lens Server ....................................... SUCCESS [10:27.398s]
> [INFO] Lens client ....................................... SUCCESS [38.697s]
> [INFO] Lens CLI .......................................... SUCCESS [56.005s]
> [INFO] Lens Examples ..................................... SUCCESS [9.633s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
> [INFO] Lens Distribution ................................. SUCCESS [9.810s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
> [INFO] Lens Regression ................................... SUCCESS [15.502s]
> [INFO] Lens UI ........................................... SUCCESS [32.531s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:48.728s
> [INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
> [INFO] Final Memory: 203M/2051M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 5:03 p.m.)
Review request for lens.
Bugs: LENS-869
https://issues.apache.org/jira/browse/LENS-869
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 40a473ad00560f35ff0b94135877131d234727eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
lens-server-api/src/test/java/org/apache/lens/server/api/LensServerAPITestUtil.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java 62e99548db7cb0d1cecd2a1197538d785dda5892
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java def568321a9a77722c3a322f9cc218b4bc112503
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 49d62f9e7a88b893a3312fd88402347090b9f155
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 3bc692e2728cb2461292593ed94aeb9db2af434e
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 94e8069146dae45834ab88dc08dc7ca881099788
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 987129c84deffe1a5bc4e1ba06cd8385d16160e9
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java 28bed2751c17dce716cebe9c25e40324b8aae75b
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 464533dd78783c8545fe09cd00f74cf713177abe
Diff: https://reviews.apache.org/r/40537/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
[INFO] Lens .............................................. SUCCESS [2.938s]
[INFO] Lens API .......................................... SUCCESS [22.467s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
[INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
[INFO] Lens DB storage ................................... SUCCESS [22.474s]
[INFO] Lens Query Library ................................ SUCCESS [16.592s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
[INFO] Lens Server ....................................... SUCCESS [10:27.398s]
[INFO] Lens client ....................................... SUCCESS [38.697s]
[INFO] Lens CLI .......................................... SUCCESS [56.005s]
[INFO] Lens Examples ..................................... SUCCESS [9.633s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
[INFO] Lens Distribution ................................. SUCCESS [9.810s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
[INFO] Lens Regression ................................... SUCCESS [15.502s]
[INFO] Lens UI ........................................... SUCCESS [32.531s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:48.728s
[INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
[INFO] Final Memory: 203M/2051M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 4:24 p.m.)
Review request for lens.
Bugs: LENS-869
https://issues.apache.org/jira/browse/LENS-869
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 40a473ad00560f35ff0b94135877131d234727eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
lens-server-api/src/test/java/org/apache/lens/server/api/LensServerAPITestUtil.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java 62e99548db7cb0d1cecd2a1197538d785dda5892
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java def568321a9a77722c3a322f9cc218b4bc112503
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 49d62f9e7a88b893a3312fd88402347090b9f155
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5f9f6396954f56fa13914e546ece597c7fdeaa88
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 94e8069146dae45834ab88dc08dc7ca881099788
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 987129c84deffe1a5bc4e1ba06cd8385d16160e9
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java 28bed2751c17dce716cebe9c25e40324b8aae75b
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 464533dd78783c8545fe09cd00f74cf713177abe
Diff: https://reviews.apache.org/r/40537/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
[INFO] Lens .............................................. SUCCESS [2.938s]
[INFO] Lens API .......................................... SUCCESS [22.467s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
[INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
[INFO] Lens DB storage ................................... SUCCESS [22.474s]
[INFO] Lens Query Library ................................ SUCCESS [16.592s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
[INFO] Lens Server ....................................... SUCCESS [10:27.398s]
[INFO] Lens client ....................................... SUCCESS [38.697s]
[INFO] Lens CLI .......................................... SUCCESS [56.005s]
[INFO] Lens Examples ..................................... SUCCESS [9.633s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
[INFO] Lens Distribution ................................. SUCCESS [9.810s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
[INFO] Lens Regression ................................... SUCCESS [15.502s]
[INFO] Lens UI ........................................... SUCCESS [32.531s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:48.728s
[INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
[INFO] Final Memory: 203M/2051M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107952
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Nov. 25, 2015, 9:03 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 9:03 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-869
> https://issues.apache.org/jira/browse/LENS-869
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 40a473ad00560f35ff0b94135877131d234727eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
> lens-server-api/src/test/java/org/apache/lens/server/api/LensServerAPITestUtil.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
> lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
> lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java 62e99548db7cb0d1cecd2a1197538d785dda5892
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java def568321a9a77722c3a322f9cc218b4bc112503
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 49d62f9e7a88b893a3312fd88402347090b9f155
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5f9f6396954f56fa13914e546ece597c7fdeaa88
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 94e8069146dae45834ab88dc08dc7ca881099788
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 987129c84deffe1a5bc4e1ba06cd8385d16160e9
> lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java 28bed2751c17dce716cebe9c25e40324b8aae75b
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 464533dd78783c8545fe09cd00f74cf713177abe
>
> Diff: https://reviews.apache.org/r/40537/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
> [INFO] Lens .............................................. SUCCESS [2.938s]
> [INFO] Lens API .......................................... SUCCESS [22.467s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
> [INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
> [INFO] Lens DB storage ................................... SUCCESS [22.474s]
> [INFO] Lens Query Library ................................ SUCCESS [16.592s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
> [INFO] Lens Server ....................................... SUCCESS [10:27.398s]
> [INFO] Lens client ....................................... SUCCESS [38.697s]
> [INFO] Lens CLI .......................................... SUCCESS [56.005s]
> [INFO] Lens Examples ..................................... SUCCESS [9.633s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
> [INFO] Lens Distribution ................................. SUCCESS [9.810s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
> [INFO] Lens Regression ................................... SUCCESS [15.502s]
> [INFO] Lens UI ........................................... SUCCESS [32.531s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:48.728s
> [INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
> [INFO] Final Memory: 203M/2051M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 2:33 p.m.)
Review request for lens.
Bugs: LENS-869
https://issues.apache.org/jira/browse/LENS-869
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 40a473ad00560f35ff0b94135877131d234727eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
lens-server-api/src/test/java/org/apache/lens/server/api/LensServerAPITestUtil.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java 62e99548db7cb0d1cecd2a1197538d785dda5892
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java def568321a9a77722c3a322f9cc218b4bc112503
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 49d62f9e7a88b893a3312fd88402347090b9f155
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5f9f6396954f56fa13914e546ece597c7fdeaa88
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 94e8069146dae45834ab88dc08dc7ca881099788
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 987129c84deffe1a5bc4e1ba06cd8385d16160e9
lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java 28bed2751c17dce716cebe9c25e40324b8aae75b
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 464533dd78783c8545fe09cd00f74cf713177abe
Diff: https://reviews.apache.org/r/40537/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
[INFO] Lens .............................................. SUCCESS [2.938s]
[INFO] Lens API .......................................... SUCCESS [22.467s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
[INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
[INFO] Lens DB storage ................................... SUCCESS [22.474s]
[INFO] Lens Query Library ................................ SUCCESS [16.592s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
[INFO] Lens Server ....................................... SUCCESS [10:27.398s]
[INFO] Lens client ....................................... SUCCESS [38.697s]
[INFO] Lens CLI .......................................... SUCCESS [56.005s]
[INFO] Lens Examples ..................................... SUCCESS [9.633s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
[INFO] Lens Distribution ................................. SUCCESS [9.810s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
[INFO] Lens Regression ................................... SUCCESS [15.502s]
[INFO] Lens UI ........................................... SUCCESS [32.531s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:48.728s
[INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
[INFO] Final Memory: 203M/2051M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 1:21 p.m.)
Review request for lens.
Bugs: LENS-869
https://issues.apache.org/jira/browse/LENS-869
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 6dcb2d79420b29fa85bd115f375c0c7e42c50834
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
Diff: https://reviews.apache.org/r/40537/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
[INFO] Lens .............................................. SUCCESS [2.938s]
[INFO] Lens API .......................................... SUCCESS [22.467s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
[INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
[INFO] Lens DB storage ................................... SUCCESS [22.474s]
[INFO] Lens Query Library ................................ SUCCESS [16.592s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
[INFO] Lens Server ....................................... SUCCESS [10:27.398s]
[INFO] Lens client ....................................... SUCCESS [38.697s]
[INFO] Lens CLI .......................................... SUCCESS [56.005s]
[INFO] Lens Examples ..................................... SUCCESS [9.633s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
[INFO] Lens Distribution ................................. SUCCESS [9.810s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
[INFO] Lens Regression ................................... SUCCESS [15.502s]
[INFO] Lens UI ........................................... SUCCESS [32.531s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:48.728s
[INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
[INFO] Final Memory: 203M/2051M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107918
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java (line 89)
<https://reviews.apache.org/r/40537/#comment167251>
Also, this should create new Configuration(false)
- Amareshwari Sriramadasu
On Nov. 24, 2015, 6:51 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 6:51 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-869
> https://issues.apache.org/jira/browse/LENS-869
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
> lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 6dcb2d79420b29fa85bd115f375c0c7e42c50834
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
> lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
>
> Diff: https://reviews.apache.org/r/40537/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
> [INFO] Lens .............................................. SUCCESS [2.938s]
> [INFO] Lens API .......................................... SUCCESS [22.467s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
> [INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
> [INFO] Lens DB storage ................................... SUCCESS [22.474s]
> [INFO] Lens Query Library ................................ SUCCESS [16.592s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
> [INFO] Lens Server ....................................... SUCCESS [10:27.398s]
> [INFO] Lens client ....................................... SUCCESS [38.697s]
> [INFO] Lens CLI .......................................... SUCCESS [56.005s]
> [INFO] Lens Examples ..................................... SUCCESS [9.633s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
> [INFO] Lens Distribution ................................. SUCCESS [9.810s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
> [INFO] Lens Regression ................................... SUCCESS [15.502s]
> [INFO] Lens UI ........................................... SUCCESS [32.531s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:48.728s
> [INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
> [INFO] Final Memory: 203M/2051M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Nov. 25, 2015, 10:58 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java, lines 88-97
> > <https://reviews.apache.org/r/40537/diff/6/?file=1138224#file1138224line88>
> >
> > Lets have them in TestLensUtil itself instead of LensUtil.
> >
> > Keeping in general code, will allow use of these methods and i think these methods should not be used in non-test code.
>
> Rajat Khandelwal wrote:
> `TestLensUtil` contained testcases of `LensUtil`, hence I removed it from there.
>
> Amareshwari Sriramadasu wrote:
> We can add one util class in test itself and move them there. These methods being in main code can result many objects being created, if used.
lens-server module has a test util class `LensTestUtil`, I'm renaming that to `LensServerTestUtil` and putting these methods in a new class `LensServerAPITestUtil` inside `lens-server-api` module.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107917
-----------------------------------------------------------
On Nov. 25, 2015, 1:21 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 1:21 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-869
> https://issues.apache.org/jira/browse/LENS-869
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
> lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 6dcb2d79420b29fa85bd115f375c0c7e42c50834
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
> lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
>
> Diff: https://reviews.apache.org/r/40537/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
> [INFO] Lens .............................................. SUCCESS [2.938s]
> [INFO] Lens API .......................................... SUCCESS [22.467s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
> [INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
> [INFO] Lens DB storage ................................... SUCCESS [22.474s]
> [INFO] Lens Query Library ................................ SUCCESS [16.592s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
> [INFO] Lens Server ....................................... SUCCESS [10:27.398s]
> [INFO] Lens client ....................................... SUCCESS [38.697s]
> [INFO] Lens CLI .......................................... SUCCESS [56.005s]
> [INFO] Lens Examples ..................................... SUCCESS [9.633s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
> [INFO] Lens Distribution ................................. SUCCESS [9.810s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
> [INFO] Lens Regression ................................... SUCCESS [15.502s]
> [INFO] Lens UI ........................................... SUCCESS [32.531s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:48.728s
> [INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
> [INFO] Final Memory: 203M/2051M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Nov. 25, 2015, 10:58 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java, lines 88-97
> > <https://reviews.apache.org/r/40537/diff/6/?file=1138224#file1138224line88>
> >
> > Lets have them in TestLensUtil itself instead of LensUtil.
> >
> > Keeping in general code, will allow use of these methods and i think these methods should not be used in non-test code.
`TestLensUtil` contained testcases of `LensUtil`, hence I removed it from there.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107917
-----------------------------------------------------------
On Nov. 24, 2015, 12:21 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 12:21 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-869
> https://issues.apache.org/jira/browse/LENS-869
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
> lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 6dcb2d79420b29fa85bd115f375c0c7e42c50834
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
> lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
>
> Diff: https://reviews.apache.org/r/40537/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
> [INFO] Lens .............................................. SUCCESS [2.938s]
> [INFO] Lens API .......................................... SUCCESS [22.467s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
> [INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
> [INFO] Lens DB storage ................................... SUCCESS [22.474s]
> [INFO] Lens Query Library ................................ SUCCESS [16.592s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
> [INFO] Lens Server ....................................... SUCCESS [10:27.398s]
> [INFO] Lens client ....................................... SUCCESS [38.697s]
> [INFO] Lens CLI .......................................... SUCCESS [56.005s]
> [INFO] Lens Examples ..................................... SUCCESS [9.633s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
> [INFO] Lens Distribution ................................. SUCCESS [9.810s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
> [INFO] Lens Regression ................................... SUCCESS [15.502s]
> [INFO] Lens UI ........................................... SUCCESS [32.531s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:48.728s
> [INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
> [INFO] Final Memory: 203M/2051M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Nov. 25, 2015, 5:28 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java, lines 88-97
> > <https://reviews.apache.org/r/40537/diff/6/?file=1138224#file1138224line88>
> >
> > Lets have them in TestLensUtil itself instead of LensUtil.
> >
> > Keeping in general code, will allow use of these methods and i think these methods should not be used in non-test code.
>
> Rajat Khandelwal wrote:
> `TestLensUtil` contained testcases of `LensUtil`, hence I removed it from there.
We can add one util class in test itself and move them there. These methods being in main code can result many objects being created, if used.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107917
-----------------------------------------------------------
On Nov. 25, 2015, 7:51 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 7:51 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-869
> https://issues.apache.org/jira/browse/LENS-869
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
> lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 6dcb2d79420b29fa85bd115f375c0c7e42c50834
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
> lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
>
> Diff: https://reviews.apache.org/r/40537/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
> [INFO] Lens .............................................. SUCCESS [2.938s]
> [INFO] Lens API .......................................... SUCCESS [22.467s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
> [INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
> [INFO] Lens DB storage ................................... SUCCESS [22.474s]
> [INFO] Lens Query Library ................................ SUCCESS [16.592s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
> [INFO] Lens Server ....................................... SUCCESS [10:27.398s]
> [INFO] Lens client ....................................... SUCCESS [38.697s]
> [INFO] Lens CLI .......................................... SUCCESS [56.005s]
> [INFO] Lens Examples ..................................... SUCCESS [9.633s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
> [INFO] Lens Distribution ................................. SUCCESS [9.810s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
> [INFO] Lens Regression ................................... SUCCESS [15.502s]
> [INFO] Lens UI ........................................... SUCCESS [32.531s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:48.728s
> [INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
> [INFO] Final Memory: 203M/2051M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107917
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java (lines 88 - 97)
<https://reviews.apache.org/r/40537/#comment167250>
Lets have them in TestLensUtil itself instead of LensUtil.
Keeping in general code, will allow use of these methods and i think these methods should not be used in non-test code.
- Amareshwari Sriramadasu
On Nov. 24, 2015, 6:51 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 6:51 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-869
> https://issues.apache.org/jira/browse/LENS-869
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
> lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 6dcb2d79420b29fa85bd115f375c0c7e42c50834
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
> lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
>
> Diff: https://reviews.apache.org/r/40537/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
> [INFO] Lens .............................................. SUCCESS [2.938s]
> [INFO] Lens API .......................................... SUCCESS [22.467s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
> [INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
> [INFO] Lens DB storage ................................... SUCCESS [22.474s]
> [INFO] Lens Query Library ................................ SUCCESS [16.592s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
> [INFO] Lens Server ....................................... SUCCESS [10:27.398s]
> [INFO] Lens client ....................................... SUCCESS [38.697s]
> [INFO] Lens CLI .......................................... SUCCESS [56.005s]
> [INFO] Lens Examples ..................................... SUCCESS [9.633s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
> [INFO] Lens Distribution ................................. SUCCESS [9.810s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
> [INFO] Lens Regression ................................... SUCCESS [15.502s]
> [INFO] Lens UI ........................................... SUCCESS [32.531s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:48.728s
> [INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
> [INFO] Final Memory: 203M/2051M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 12:21 p.m.)
Review request for lens.
Bugs: LENS-869
https://issues.apache.org/jira/browse/LENS-869
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 6dcb2d79420b29fa85bd115f375c0c7e42c50834
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
Diff: https://reviews.apache.org/r/40537/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
[INFO] Lens .............................................. SUCCESS [2.938s]
[INFO] Lens API .......................................... SUCCESS [22.467s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
[INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
[INFO] Lens DB storage ................................... SUCCESS [22.474s]
[INFO] Lens Query Library ................................ SUCCESS [16.592s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
[INFO] Lens Server ....................................... SUCCESS [10:27.398s]
[INFO] Lens client ....................................... SUCCESS [38.697s]
[INFO] Lens CLI .......................................... SUCCESS [56.005s]
[INFO] Lens Examples ..................................... SUCCESS [9.633s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
[INFO] Lens Distribution ................................. SUCCESS [9.810s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
[INFO] Lens Regression ................................... SUCCESS [15.502s]
[INFO] Lens UI ........................................... SUCCESS [32.531s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:48.728s
[INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
[INFO] Final Memory: 203M/2051M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 6:17 p.m.)
Review request for lens.
Bugs: LENS-869
https://issues.apache.org/jira/browse/LENS-869
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 6dcb2d79420b29fa85bd115f375c0c7e42c50834
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
Diff: https://reviews.apache.org/r/40537/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s]
[INFO] Lens .............................................. SUCCESS [2.938s]
[INFO] Lens API .......................................... SUCCESS [22.467s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.336s]
[INFO] Lens Cube ......................................... SUCCESS [6:05.328s]
[INFO] Lens DB storage ................................... SUCCESS [22.474s]
[INFO] Lens Query Library ................................ SUCCESS [16.592s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s]
[INFO] Lens Server ....................................... SUCCESS [10:27.398s]
[INFO] Lens client ....................................... SUCCESS [38.697s]
[INFO] Lens CLI .......................................... SUCCESS [56.005s]
[INFO] Lens Examples ..................................... SUCCESS [9.633s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s]
[INFO] Lens Distribution ................................. SUCCESS [9.810s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s]
[INFO] Lens Regression ................................... SUCCESS [15.502s]
[INFO] Lens UI ........................................... SUCCESS [32.531s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:48.728s
[INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015
[INFO] Final Memory: 203M/2051M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 4:02 p.m.)
Review request for lens.
Bugs: LENS-869
https://issues.apache.org/jira/browse/LENS-869
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 6dcb2d79420b29fa85bd115f375c0c7e42c50834
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java e41f2f447d0d3c9ff49d924456124a7e9e4041b5
lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java 844237a25dd4c305698fc650f97ae5004100b9fd
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java ca24a8baa2a61238a26427d52108eed2a710b7d0
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java ec6fd86af51d9fc77dc420a787f4f9e70e2ac625
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a
Diff: https://reviews.apache.org/r/40537/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/
-----------------------------------------------------------
(Updated Nov. 20, 2015, 6:22 p.m.)
Review request for lens.
Bugs: LENS-869
https://issues.apache.org/jira/browse/LENS-869
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
Diff: https://reviews.apache.org/r/40537/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/
-----------------------------------------------------------
(Updated Nov. 20, 2015, 6:11 p.m.)
Review request for lens.
Bugs: LENS-869
https://issues.apache.org/jira/browse/LENS-869
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
Diff: https://reviews.apache.org/r/40537/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Nov. 20, 2015, 12:30 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 269
> > <https://reviews.apache.org/r/40537/diff/1/?file=1134230#file1134230line269>
> >
> > Why is private removed?
>
> Rajat Khandelwal wrote:
> Acquiring lock in test case to get snapshot of running, queued, waiting queries atomically.
We should not open up locks even for tests. We should add getters if required.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107353
-----------------------------------------------------------
On Nov. 20, 2015, 12:41 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 12:41 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-869
> https://issues.apache.org/jira/browse/LENS-869
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40537/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Nov. 20, 2015, 6 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 269
> > <https://reviews.apache.org/r/40537/diff/1/?file=1134230#file1134230line269>
> >
> > Why is private removed?
>
> Rajat Khandelwal wrote:
> Acquiring lock in test case to get snapshot of running, queued, waiting queries atomically.
>
> Amareshwari Sriramadasu wrote:
> We should not open up locks even for tests. We should add getters if required.
Changed to add a method in query service.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107353
-----------------------------------------------------------
On Nov. 20, 2015, 6:22 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 6:22 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-869
> https://issues.apache.org/jira/browse/LENS-869
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40537/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Nov. 20, 2015, 6 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 269
> > <https://reviews.apache.org/r/40537/diff/1/?file=1134230#file1134230line269>
> >
> > Why is private removed?
Acquiring lock in test case to get snapshot of running, queued, waiting queries atomically.
> On Nov. 20, 2015, 6 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java, line 129
> > <https://reviews.apache.org/r/40537/diff/1/?file=1134232#file1134232line129>
> >
> > Is getServerConf() same as LensServerConf.getHiveConf() ?
`getServerConf` is a hook in `LensJerseyTest` which returns `LensServerConf.getHiveConf`. Individual tests may make a new conf and start the server with a different conf.
> On Nov. 20, 2015, 6 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java, line 76
> > <https://reviews.apache.org/r/40537/diff/1/?file=1134233#file1134233line76>
> >
> > Does it need to extend LensJerseyTest? Seems it is creatin its own drivers, should not be.
Using server end points to submit queries.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107353
-----------------------------------------------------------
On Nov. 20, 2015, 6:11 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 6:11 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-869
> https://issues.apache.org/jira/browse/LENS-869
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java c96ef200f710076e246f8ac2095f398a5b0da985
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40537/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40537: LENS-869: DefaultEstimatedQueryCollection is
removing all queries of a driver
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107353
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 269)
<https://reviews.apache.org/r/40537/#comment166456>
Why is private removed?
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java (line 129)
<https://reviews.apache.org/r/40537/#comment166458>
Is getServerConf() same as LensServerConf.getHiveConf() ?
lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java (line 76)
<https://reviews.apache.org/r/40537/#comment166461>
Does it need to extend LensJerseyTest? Seems it is creatin its own drivers, should not be.
- Amareshwari Sriramadasu
On Nov. 20, 2015, 11:21 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 11:21 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-869
> https://issues.apache.org/jira/browse/LENS-869
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 6db720d0f62425454f6a9e18a0365897c08d1980
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fdc8bfd315e29a3f74232767dc4776f155bb1d22
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 3dad050e255cbb177a46b6a14f49acf33e9a51bd
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40537/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>