You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/13 02:26:17 UTC
[GitHub] [doris] BePPPower opened a new pull request, #15889: [Fix](file system ) Make the constructor of `XxxFileSystem` a private method
BePPPower opened a new pull request, #15889:
URL: https://github.com/apache/doris/pull/15889
# Proposed changes
Issue Number: close #xxx
Since Filesystem inherited `std::enable_shared_from_this` , it is dangerous to create native point of `FileSystem`.
To avoid this behavior, making the constructor of `XxxFileSystem` a private method and using the static method `create(...)` to get a new `FileSystem` object.
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15889: [Fix](file system) Make the constructor of `XxxFileSystem` a private method
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15889:
URL: https://github.com/apache/doris/pull/15889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15889: [Fix](file system) Make the constructor of `XxxFileSystem` a private method
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15889:
URL: https://github.com/apache/doris/pull/15889#issuecomment-1381250843
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15889: [Fix](file system) Make the constructor of `XxxFileSystem` a private method
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15889:
URL: https://github.com/apache/doris/pull/15889#discussion_r1068867778
##########
be/src/io/fs/hdfs_file_system.cpp:
##########
@@ -61,6 +61,11 @@ class HdfsFileSystemCache {
void _clean_oldest();
};
+std::shared_ptr<HdfsFileSystem> HdfsFileSystem::create(const THdfsParams& hdfs_params,
+ const std::string& path) {
Review Comment:
It is better to change the interface like this.
```suggestion
std::unique_ptr<HdfsFileSystem> HdfsFileSystem::create(const THdfsParams& hdfs_params,
const std::string& path) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15889: [Fix](file system) Make the constructor of `XxxFileSystem` a private method
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15889:
URL: https://github.com/apache/doris/pull/15889#issuecomment-1381316880
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.01 seconds
load time: 527 seconds
storage size: 17122633387 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230113050020_clickbench_pr_79341.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15889: [Fix](file system) Make the constructor of `XxxFileSystem` a private method
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15889:
URL: https://github.com/apache/doris/pull/15889#issuecomment-1381250804
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15889: [Fix](file system) Make the constructor of `XxxFileSystem` a private method
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #15889:
URL: https://github.com/apache/doris/pull/15889#discussion_r1068888343
##########
be/test/olap/remote_rowset_gc_test.cpp:
##########
@@ -52,7 +52,7 @@ class RemoteRowsetGcTest : public testing::Test {
s3_conf.region = config::test_s3_region;
Review Comment:
warning: no member named 'test_s3_region' in namespace 'doris::config' [clang-diagnostic-error]
```cpp
s3_conf.region = config::test_s3_region;
^
```
##########
be/test/olap/tablet_cooldown_test.cpp:
##########
@@ -51,7 +51,7 @@
s3_conf.region = config::test_s3_region;
s3_conf.bucket = config::test_s3_bucket;
Review Comment:
warning: no member named 'test_s3_bucket' in namespace 'doris::config' [clang-diagnostic-error]
```cpp
s3_conf.bucket = config::test_s3_bucket;
^
```
##########
be/test/olap/tablet_cooldown_test.cpp:
##########
@@ -51,7 +51,7 @@ class TabletCooldownTest : public testing::Test {
s3_conf.region = config::test_s3_region;
Review Comment:
warning: no member named 'test_s3_region' in namespace 'doris::config' [clang-diagnostic-error]
```cpp
s3_conf.region = config::test_s3_region;
^
```
##########
be/test/olap/remote_rowset_gc_test.cpp:
##########
@@ -52,7 +52,7 @@
s3_conf.region = config::test_s3_region;
s3_conf.bucket = config::test_s3_bucket;
Review Comment:
warning: no member named 'test_s3_bucket' in namespace 'doris::config' [clang-diagnostic-error]
```cpp
s3_conf.bucket = config::test_s3_bucket;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org