You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Gavin (JIRA)" <ji...@apache.org> on 2005/08/28 14:55:04 UTC

[jira] Created: (FOR-652) CSS Style Sheets need cleanup and optimization

CSS Style Sheets need cleanup and optimization
----------------------------------------------

         Key: FOR-652
         URL: http://issues.apache.org/jira/browse/FOR-652
     Project: Forrest
        Type: Improvement
  Components: Skins (general issues)  
    Versions: 0.8-dev    
 Environment: All, Needs to make sure look and feel are the same in multiple browsers, e.g. IE6, Mozilla, Firefox, Camino, Konqeror.
 Reporter: Gavin


The current CSS implementation needs a bit of a cleanup, some tweaking and optimization. It needs to be improved and some styles converted to % in order to cater for different browsers and user resolutions. A more fluid design needs to be the outcome. The overall style and look and feel of the current pelt skin is to largely remain the same where possible whilst implementing these improvements. The style sheets are to remain CSS1 valid and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be achieved.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Created: (FOR-652) CSS Style Sheets need cleanup and optimization

Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
> 
> Ok, default views up and running, am slightly confused where skins/css is 
> supposed to be.
> 
> The page on http://forrest.apache.org/docs_0_80/howto/howto-view-dsl.html
> says :-
> 
> "We will now create a file in {project:skins-dir}{path}/{name}.css. In our 
> case we will save a file called howTo.css in 
> newSeed/src/documentation/skins/css/howTo.css containing only the following 
> css: ..................."
> 
> There is no /skins/ directory in /src/documentation/.

I don't know if this answer is correct, but perhaps:
http://forrest.apache.org/docs_0_80/faq.html#javascript

-David

> There is a /build/site/skin/css/ directory so I copied them there, but I 
> will have to publish each time instead of
> refreshing a localhost of 'forrest run' .
> 
> Is it as simple as creating the /skins/css/ directory below 
> /src/documentation or should it have been there to begin with?
> 
> Also, I will look anyway, but are we using currently in views the files in 
> /css/ or /css/pelt/ or both (from whiteboard)
> 
> Gav...

Re: [jira] Created: (FOR-652) CSS Style Sheets need cleanup and optimization

Posted by Thorsten Scherler <th...@apache.org>.
On Tue, 2005-08-30 at 21:54 +0800, Gav.... wrote:
...
> Ok, default views up and running, am slightly confused where skins/css is 
> supposed to be.
> 
> The page on http://forrest.apache.org/docs_0_80/howto/howto-view-dsl.html
> says :-
> 
> "We will now create a file in {project:skins-dir}{path}/{name}.css. In our 
> case we will save a file called howTo.css in 
> newSeed/src/documentation/skins/css/howTo.css containing only the following 
> css: ..................."
> 
> There is no /skins/ directory in /src/documentation/.
> 

In the original install guide I wrote it done that you need to create
such a directory but then we added it to the fresh seed and now it seems
that it gone again. We assume in this howto that you have the default
setup.

Just go ahead and create one. ;-)

cd src/documentation/
mkdir -p skins/css
cd skins/css

Anyway you can define project.skins-dir in your forrest.properties:
#project.skins-dir=${project.content-dir}/skins

> There is a /build/site/skin/css/ directory so I copied them there, but I 
> will have to publish each time instead of
> refreshing a localhost of 'forrest run' .
> 
> Is it as simple as creating the /skins/css/ directory below 
> /src/documentation or should it have been there to begin with?
> 

see above.

> Also, I will look anyway, but are we using currently in views the files in 
> /css/ or /css/pelt/ or both (from whiteboard)
> 

that depends which theme you have choosen. ;-)

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Re: [jira] Created: (FOR-652) CSS Style Sheets need cleanup and optimization

Posted by "Gav...." <br...@brightontown.com.au>.
From: "Diwaker Gupta" <di...@apache.org>
else.?

> You can either work on files under:
> whiteboard/plugins/org.apache.forrest.plugin.output.viewHelper.xhtml/resources/skin/css

> Or (recommended), just copy them into your project dir skins/css and work 
> on
> that. You can set which css to use in your *.fv files.

Ok, default views up and running, am slightly confused where skins/css is 
supposed to be.

The page on http://forrest.apache.org/docs_0_80/howto/howto-view-dsl.html
says :-

"We will now create a file in {project:skins-dir}{path}/{name}.css. In our 
case we will save a file called howTo.css in 
newSeed/src/documentation/skins/css/howTo.css containing only the following 
css: ..................."

There is no /skins/ directory in /src/documentation/.

There is a /build/site/skin/css/ directory so I copied them there, but I 
will have to publish each time instead of
refreshing a localhost of 'forrest run' .

Is it as simple as creating the /skins/css/ directory below 
/src/documentation or should it have been there to begin with?

Also, I will look anyway, but are we using currently in views the files in 
/css/ or /css/pelt/ or both (from whiteboard)

Gav...




-- 
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.10.17/84 - Release Date: 29/08/2005


Re: [jira] Created: (FOR-652) CSS Style Sheets need cleanup and optimization

Posted by "Gav...." <br...@brightontown.com.au>.
----- Original Message ----- 
From: "Diwaker Gupta" <di...@apache.org>
To: <de...@forrest.apache.org>
Sent: Tuesday, August 30, 2005 3:55 PM
Subject: Re: [jira] Created: (FOR-652) CSS Style Sheets need cleanup and 
optimization


> This will help:
> http://www.reeddesign.co.uk/test/points-pixels.html

Its a good chart and good start, though I think it can
cause confusion for some with regards to px -> em

e.g it says 48px is 3em, true from the top level such as body or main
but when a child div element  inherits from a parent of 48px then 1em is 
48px not 3.
It is also basing its chart on default font size of Medium = 16px = 1em.
I am open to objections on that though :)

Apart from that it is a good reference which I have printed off.

> You can either work on files under:
> whiteboard/plugins/org.apache.forrest.plugin.output.viewHelper.xhtml/resources/skin/css

> Or (recommended), just copy them into your project dir skins/css and work 
> on
> that. You can set which css to use in your *.fv files.

Cool, I can now shut up and get on with it :)

> Please, keep up the good work :-)

You haven't seen it yet ;)

Gav...



-- 
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.10.17/84 - Release Date: 29/08/2005


Re: [jira] Created: (FOR-652) CSS Style Sheets need cleanup and optimization

Posted by Diwaker Gupta <di...@apache.org>.
On Monday 29 August 2005 5:58 am, Gav.... wrote:

[snip lots of good stuff]

> We should use mainly ems for the content side of things, specifically
> font-size.
>
> As a general rule of thumb :

This will help:
http://www.reeddesign.co.uk/test/points-pixels.html

> I agree, I was just having a test using a seed site and pelt to make sure
> there
> wasn't any problems. If we can agree on a way of doing things then I'll
> certainly jump in to CSS on views. Should I be looking at
> /webapp/skins/leather-dev/css for this or somewhere else.?

You can either work on files under:
whiteboard/plugins/org.apache.forrest.plugin.output.viewHelper.xhtml/resources/skin/css

Or (recommended), just copy them into your project dir skins/css and work on 
that. You can set which css to use in your *.fv files.

Please, keep up the good work :-)
-- 
Web/Blog/Gallery: http://floatingsun.net

Re: [jira] Created: (FOR-652) CSS Style Sheets need cleanup and optimization

Posted by "Gav...." <br...@brightontown.com.au>.
----- Original Message ----- 
From: "Diwaker Gupta" <di...@apache.org>

Diwaker said in an attatchment :-

>Lets not rush into %ages. %ages are *not* a good way to create a fluid 
>design.
>The biggest problem with %ages is that they cascade across elements, which
>makes the math slighly difficult. ems and px are both immune to cascading.

I disagree I'm afraid in part anyway. Percentages are an excellent way to 
create
a fluid design if used sensibly and properly. Yes, %ages cascade, though I
wouldn't neccessarily use them that way, but is not a bad thing.

ems are not immune to cascading and work in a similar fashion to %ages.
px is immune I agree, and is also rigid, which is why it is bad to use it in
a fluid design in places.

Your first  link mentions ems with percent base, that is how I would go 
about
things and propose that this same way of doing things is how we should
implement it here.

We should use percent in the body , declaration of initial font-sizes, and 
in
declaration of all divs - that is use % for divs that are used to define the 
structure
of the document. This way, all divs will resize properly and the correct 
proportions
to each other in relation to how the user has their screen resolution set 
and how
big their browser window is.

Currently there is a lot of px being used for div element sizes, and where 
abouts on
the document the div is placed, this is rigid design and does not resize 
well. I really
don't like the idea of 180px as a padding value, but that may just be me :)

We should use mainly ems for the content side of things, specifically 
font-size.

As a general rule of thumb :

1em is 100% of the parent element, if the parent is body then unless 
over-riden, takes its size from
the default browser setting. Default in IE on Windows for example is Medium 
which is 16px.
0.8em is 80% of the parent element.
1.2em is 120% of the parent element.

It is important IMHO to use ems and % to give the user the user the right to 
alter sizes.
A user might set their browser text size to 'larger' for instance, ems and % 
ensure this
is adhered to. We should also use % for padding and ems for margins. Padding 
is for
design layout and margins is for content layout.

Where px can be used, is in those places that must or should have those 
sizes, such as in form
fields and borders.

>For more details, check out:
>o http://css-discuss.incutio.com/?page=UsingFontSize
>o http://alistapart.com/topics/design/typography/

The second link didn't offer me much there, I am a regular of alistapart in 
general however.
The first link actually backs up my previous arguments.

See also http://www.w3.org/TR/REC-CSS2/syndata.html#length-units

I through up a quick page here also, it is a very basic example :-

http://www.minitutorials.com/webdesign/css/css31.shtml

>That said, there _are_ some very good uses for %ages -- for instance, if 
>you
>want to restrict a box's width relative to its parent.

Yep, I agree, that should be the emphasis for the overall layout for divs as 
well
as boxes.

>I've looked at the diff in this issue -- it'll be good if you can describe
>exactly what problem they fix (like a browser screenshot or something).

Sure thing, those changes mainly adjusted some properties for a more fluid
design, they resize better in the browser window and resolution of the user,
however it isn't implemented for all divs on the site and so you don't yet
see the full benefit. One benefit you can see is if MOTD is enabled, the 
MOTD
has been moved further right, its container and parent container and a 
neigbouring
container have been made more fluid and so makes better the current Issue of
MOTD squashing the navigational headlines of the page. I have put up an
example of this at http://www.apache.minitutorials.com/samples/faq.html . 
The
page resizes better already than for example
http://forrest.apache.org/pluginDocs/plugins_0_80/usingPlugins.html

>Also, since we will be moving to the views-based Pelt rewrite, we are 
>probably
>better off focusing our CSS efforts into that CSS rather than the old 
>Pelt's
>CSS :-)

I agree, I was just having a test using a seed site and pelt to make sure 
there
wasn't any problems. If we can agree on a way of doing things then I'll
certainly jump in to CSS on views. Should I be looking at
/webapp/skins/leather-dev/css for this or somewhere else.?

Gav...




-- 
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.10.16/83 - Release Date: 26/08/2005


Re: [jira] Created: (FOR-652) CSS Style Sheets need cleanup and optimization

Posted by Diwaker Gupta <di...@apache.org>.
On Sunday 28 August 2005 5:55 am, Gavin (JIRA) wrote:
> The current CSS implementation needs a bit of a cleanup, some tweaking and
> optimization. It needs to be improved and some styles converted to % in
> order to cater for different browsers and user resolutions. A more fluid
> design needs to be the outcome. The overall style and look and feel of the
> current pelt skin is to largely remain the same where possible whilst
> implementing these improvements. The style sheets are to remain CSS1 valid
> and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be
> achieved.

Lets not rush into %ages. %ages are *not* a good way to create a fluid design. 
The biggest problem with %ages is that they cascade across elements, which 
makes the math slighly difficult. ems and px are both immune to cascading.

For more details, check out:
o http://css-discuss.incutio.com/?page=UsingFontSize
o http://alistapart.com/topics/design/typography/

That said, there _are_ some very good uses for %ages -- for instance, if you 
want to restrict a box's width relative to its parent.

I've looked at the diff in this issue -- it'll be good if you can describe 
exactly what problem they fix (like a browser screenshot or something).

Also, since we will be moving to the views-based Pelt rewrite, we are probably 
better off focusing our CSS efforts into that CSS rather than the old Pelt's 
CSS :-)

Diwaker
-- 
Web/Blog/Gallery: http://floatingsun.net

[jira] Updated: (FOR-652) CSS Style Sheets need cleanup, optimization and better naming of elements

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-652?page=all ]

Thorsten Scherler updated FOR-652:
----------------------------------

    Comment: was deleted

> CSS Style Sheets need cleanup, optimization and better naming of elements
> -------------------------------------------------------------------------
>
>          Key: FOR-652
>          URL: http://issues.apache.org/jira/browse/FOR-652
>      Project: Forrest
>         Type: Improvement
>   Components: Dispatcher (aka views)
>     Versions: 0.8-dev
>  Environment: All, Needs to make sure look and feel are the same in multiple browsers, e.g. IE6, Mozilla, Firefox, Camino, Konqeror.
>     Reporter: Gavin
>  Attachments: screen.css.diff
>
> The current CSS implementation needs a bit of a cleanup, some tweaking and optimization. It needs to be improved and some styles converted to % in order to cater for different browsers and user resolutions. A more fluid design needs to be the outcome. The overall style and look and feel of the current pelt skin is to largely remain the same where possible whilst implementing these improvements. The style sheets are to remain CSS1 valid and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be achieved.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-652) CSS Style Sheets need cleanup, optimization and better naming of elements

Posted by "Sina K. Heshmati (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sina K. Heshmati updated FOR-652:
---------------------------------

    Attachment: pelt-new-markup-200804.xml

Markup generated by the Pelt theme could look like this capture.

> CSS Style Sheets need cleanup, optimization and better naming of elements
> -------------------------------------------------------------------------
>
>                 Key: FOR-652
>                 URL: https://issues.apache.org/jira/browse/FOR-652
>             Project: Forrest
>          Issue Type: Improvement
>          Components: Plugin: internal.dispatcher
>    Affects Versions: 0.8
>         Environment: All, Needs to make sure look and feel are the same in multiple browsers, e.g. IE6, Mozilla, Firefox, Camino, Konqeror.
>            Reporter: Gavin
>            Assignee: Gavin
>         Attachments: pelt-new-markup-200804.xml, screen.css.diff, skins-output-markup-capture-200804.xml, themes-output-markup-capture-200804.xml
>
>
> The current CSS implementation needs a bit of a cleanup, some tweaking and optimization. It needs to be improved and some styles converted to % in order to cater for different browsers and user resolutions. A more fluid design needs to be the outcome. The overall style and look and feel of the current pelt skin is to largely remain the same where possible whilst implementing these improvements. The style sheets are to remain CSS1 valid and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be achieved.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-652) CSS Style Sheets need cleanup, optimization and better naming of elements

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591591#action_12591591 ] 

Thorsten Scherler commented on FOR-652:
---------------------------------------

http://www.oscom.org/events/oscom4/proposals/skins.html
A while ago I did the above presentation about this topic. More or less our container have standard names. A few can be enhanced I have to admit.

http://marc.info/?l=forrest-dev&m=109535294600667&w=2
Is explaining the whole issue as well quite well.

> CSS Style Sheets need cleanup, optimization and better naming of elements
> -------------------------------------------------------------------------
>
>                 Key: FOR-652
>                 URL: https://issues.apache.org/jira/browse/FOR-652
>             Project: Forrest
>          Issue Type: Improvement
>          Components: Plugin: internal.dispatcher
>    Affects Versions: 0.8
>         Environment: All, Needs to make sure look and feel are the same in multiple browsers, e.g. IE6, Mozilla, Firefox, Camino, Konqeror.
>            Reporter: Gavin
>            Assignee: Gavin
>         Attachments: screen.css.diff, skins-output-markup-capture-200804.xml, themes-output-markup-capture-200804.xml
>
>
> The current CSS implementation needs a bit of a cleanup, some tweaking and optimization. It needs to be improved and some styles converted to % in order to cater for different browsers and user resolutions. A more fluid design needs to be the outcome. The overall style and look and feel of the current pelt skin is to largely remain the same where possible whilst implementing these improvements. The style sheets are to remain CSS1 valid and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be achieved.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FOR-652) CSS Style Sheets need cleanup, optimization and better naming of elements

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-652?page=all ]

Thorsten Scherler updated FOR-652:
----------------------------------

    Comment: was deleted

> CSS Style Sheets need cleanup, optimization and better naming of elements
> -------------------------------------------------------------------------
>
>          Key: FOR-652
>          URL: http://issues.apache.org/jira/browse/FOR-652
>      Project: Forrest
>         Type: Improvement
>   Components: Dispatcher (aka views)
>     Versions: 0.8-dev
>  Environment: All, Needs to make sure look and feel are the same in multiple browsers, e.g. IE6, Mozilla, Firefox, Camino, Konqeror.
>     Reporter: Gavin
>  Attachments: screen.css.diff
>
> The current CSS implementation needs a bit of a cleanup, some tweaking and optimization. It needs to be improved and some styles converted to % in order to cater for different browsers and user resolutions. A more fluid design needs to be the outcome. The overall style and look and feel of the current pelt skin is to largely remain the same where possible whilst implementing these improvements. The style sheets are to remain CSS1 valid and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be achieved.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-652) CSS Style Sheets need cleanup and optimization

Posted by "Gavin (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-652?page=all ]

Gavin updated FOR-652:
----------------------

    Attachment: screen.css.diff

A start at making for a more fluid design. Some minor changes to improve fluidity.

> CSS Style Sheets need cleanup and optimization
> ----------------------------------------------
>
>          Key: FOR-652
>          URL: http://issues.apache.org/jira/browse/FOR-652
>      Project: Forrest
>         Type: Improvement
>   Components: Skins (general issues)
>     Versions: 0.8-dev
>  Environment: All, Needs to make sure look and feel are the same in multiple browsers, e.g. IE6, Mozilla, Firefox, Camino, Konqeror.
>     Reporter: Gavin
>  Attachments: screen.css.diff
>
> The current CSS implementation needs a bit of a cleanup, some tweaking and optimization. It needs to be improved and some styles converted to % in order to cater for different browsers and user resolutions. A more fluid design needs to be the outcome. The overall style and look and feel of the current pelt skin is to largely remain the same where possible whilst implementing these improvements. The style sheets are to remain CSS1 valid and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be achieved.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-652) CSS Style Sheets need cleanup, optimization and better naming of elements

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-652?page=all ]

David Crossley updated FOR-652:
-------------------------------

    Other Info: [Patch available]

> CSS Style Sheets need cleanup, optimization and better naming of elements
> -------------------------------------------------------------------------
>
>          Key: FOR-652
>          URL: http://issues.apache.org/jira/browse/FOR-652
>      Project: Forrest
>         Type: Improvement
>   Components: Dispatcher (aka views)
>     Versions: 0.8-dev
>  Environment: All, Needs to make sure look and feel are the same in multiple browsers, e.g. IE6, Mozilla, Firefox, Camino, Konqeror.
>     Reporter: Gavin
>  Attachments: screen.css.diff
>
> The current CSS implementation needs a bit of a cleanup, some tweaking and optimization. It needs to be improved and some styles converted to % in order to cater for different browsers and user resolutions. A more fluid design needs to be the outcome. The overall style and look and feel of the current pelt skin is to largely remain the same where possible whilst implementing these improvements. The style sheets are to remain CSS1 valid and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be achieved.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-652) CSS Style Sheets need cleanup, optimization and better naming of elements

Posted by "Sina K. Heshmati (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sina K. Heshmati updated FOR-652:
---------------------------------

    Attachment: themes-output-markup-capture-200804.xml
                skins-output-markup-capture-200804.xml

In an attempt to produce clean markup, with appropriate 'id' and 'class' names, I've tried to capture the markup generated by the legacy skins and  the dispatcher/structurer in two different XML files. These two files are intended to deliver an image of the output result produced by Forrest. They'll assist the designers through the markup re-design process.

> CSS Style Sheets need cleanup, optimization and better naming of elements
> -------------------------------------------------------------------------
>
>                 Key: FOR-652
>                 URL: https://issues.apache.org/jira/browse/FOR-652
>             Project: Forrest
>          Issue Type: Improvement
>          Components: Plugin: internal.dispatcher
>    Affects Versions: 0.8
>         Environment: All, Needs to make sure look and feel are the same in multiple browsers, e.g. IE6, Mozilla, Firefox, Camino, Konqeror.
>            Reporter: Gavin
>            Assignee: Gavin
>         Attachments: screen.css.diff, skins-output-markup-capture-200804.xml, themes-output-markup-capture-200804.xml
>
>
> The current CSS implementation needs a bit of a cleanup, some tweaking and optimization. It needs to be improved and some styles converted to % in order to cater for different browsers and user resolutions. A more fluid design needs to be the outcome. The overall style and look and feel of the current pelt skin is to largely remain the same where possible whilst implementing these improvements. The style sheets are to remain CSS1 valid and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be achieved.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FOR-652) CSS Style Sheets need cleanup, optimization and better naming of elements

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-652?page=all ]

Thorsten Scherler updated FOR-652:
----------------------------------

    Component: Dispatcher (aka views)
                   (was: Skins (general issues))
      Summary: CSS Style Sheets need cleanup, optimization and better naming of elements  (was: CSS Style Sheets need cleanup and optimization)

http://svn.apache.org/viewcvs.cgi/*checkout*/forrest/events/forrest-friday/20060210-summary.txt
Cheche and Thorsten discussed the horrible CSS in version 0.7 and hoped
that Dispatcher will be better.

http://svn.apache.org/viewcvs.cgi/*checkout*/forrest/events/forrest-friday/20060210-log.txt
[18:50] cheche: I am a bit  sad about forrest...
[18:50] cheche: I was doing a web site for a customer
[18:50] tscherler: why?
[18:50] cheche: http://www.cesarnieto.com/
[18:51] cheche: I did it using forrest v.07
[18:51] cheche: and I ask a css programer to help me with the site
[18:51] cheche: I have got an email yesterday from him
[18:52] tscherler: and?
[18:52] cheche: he said that it was the most complex css code that he ever saw
[18:52] cheche: and he quit for the job :-)
[18:53] tscherler: lol
...
[18:53] tscherler: the css was growing
...
[18:55] cheche: well, that was with the old version
[18:55] cheche: is the dispatcher going to help in this way?
...
[19:00] cheche: I am ok with the new changes.
...
[19:02] cheche: xley: can I add www.cesarnieto.com as en example site?
[19:02] xley: better if they do.
[19:02] xley: sure please do
[19:03] cheche: but It has his own skin and a lot of modifications
[19:03] xley: no problem, it is still an example of what can be done.
[19:03] cheche: ok then
[19:04] tscherler: cheche yes and no
[19:04] tscherler: the css codes is not rewritten for the dispatcher
[19:04] tscherler: but it would make sense
[19:05] tscherler: it makes it way easier for a designer to change everything but still you need to do it ;-)
[19:05] tscherler: k
...

> CSS Style Sheets need cleanup, optimization and better naming of elements
> -------------------------------------------------------------------------
>
>          Key: FOR-652
>          URL: http://issues.apache.org/jira/browse/FOR-652
>      Project: Forrest
>         Type: Improvement
>   Components: Dispatcher (aka views)
>     Versions: 0.8-dev
>  Environment: All, Needs to make sure look and feel are the same in multiple browsers, e.g. IE6, Mozilla, Firefox, Camino, Konqeror.
>     Reporter: Gavin
>  Attachments: screen.css.diff
>
> The current CSS implementation needs a bit of a cleanup, some tweaking and optimization. It needs to be improved and some styles converted to % in order to cater for different browsers and user resolutions. A more fluid design needs to be the outcome. The overall style and look and feel of the current pelt skin is to largely remain the same where possible whilst implementing these improvements. The style sheets are to remain CSS1 valid and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be achieved.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (FOR-652) CSS Style Sheets need cleanup, optimization and better naming of elements

Posted by "Gavin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gavin reassigned FOR-652:
-------------------------

    Assignee: Gavin

> CSS Style Sheets need cleanup, optimization and better naming of elements
> -------------------------------------------------------------------------
>
>                 Key: FOR-652
>                 URL: https://issues.apache.org/jira/browse/FOR-652
>             Project: Forrest
>          Issue Type: Improvement
>          Components: Plugin: internal.dispatcher
>    Affects Versions: 0.8
>         Environment: All, Needs to make sure look and feel are the same in multiple browsers, e.g. IE6, Mozilla, Firefox, Camino, Konqeror.
>            Reporter: Gavin
>            Assignee: Gavin
>         Attachments: screen.css.diff
>
>
> The current CSS implementation needs a bit of a cleanup, some tweaking and optimization. It needs to be improved and some styles converted to % in order to cater for different browsers and user resolutions. A more fluid design needs to be the outcome. The overall style and look and feel of the current pelt skin is to largely remain the same where possible whilst implementing these improvements. The style sheets are to remain CSS1 valid and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be achieved.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-652) CSS Style Sheets need cleanup, optimization and better naming of elements

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-652?page=comments#action_12366120 ] 

Thorsten Scherler commented on FOR-652:
---------------------------------------

We have to fix the css naming for the dispatcher.

http://svn.apache.org/viewcvs.cgi/*checkout*/forrest/events/forrest-friday/20060210-log.txt
[22:50] tscherler: [22:05] _Gav_: What concerns has cheche with this
[22:50] tscherler: he said is way to verbose and I share this concern
...
[22:50] tscherler: pelt has too much css files
...
[22:51] _Gav_: ok, so simplify it to one css file maybe
...
[22:51] tscherler: we should try to have one/two static css and one dynamic css contract
...
[22:52] tscherler: further the naming is sometimes really spacy
[22:52] tscherler: we should follow
...
[22:53] tscherler: http://svn.apache.org/viewcvs.cgi/*checkout*/forrest/trunk/main/webapp/skins/leather-dev/contracts.initial.txt
[22:53] tscherler: when ever possible
[22:53] tscherler: The task involved are:
[22:54] tscherler: 1) reduce css files (merge the files)
...
[22:54] tscherler: 2) rename css elements and the corresponding structurer hooks/contracts

> CSS Style Sheets need cleanup, optimization and better naming of elements
> -------------------------------------------------------------------------
>
>          Key: FOR-652
>          URL: http://issues.apache.org/jira/browse/FOR-652
>      Project: Forrest
>         Type: Improvement
>   Components: Dispatcher (aka views)
>     Versions: 0.8-dev
>  Environment: All, Needs to make sure look and feel are the same in multiple browsers, e.g. IE6, Mozilla, Firefox, Camino, Konqeror.
>     Reporter: Gavin
>  Attachments: screen.css.diff
>
> The current CSS implementation needs a bit of a cleanup, some tweaking and optimization. It needs to be improved and some styles converted to % in order to cater for different browsers and user resolutions. A more fluid design needs to be the outcome. The overall style and look and feel of the current pelt skin is to largely remain the same where possible whilst implementing these improvements. The style sheets are to remain CSS1 valid and aim for CSS2 valid. When XHTML2 is implemented perhaps CSS3 can be achieved.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira