You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/13 00:21:11 UTC
[GitHub] [incubator-superset] adam-stasiak opened a new pull request #11685: chore: V1 charts load cypress tests
adam-stasiak opened a new pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
I added assertion on response from v1 chart request to load.test.js file.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (2eb1f36) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.58% -0.28%
==========================================
Files 889 435 -454
Lines 43054 29043 -14011
Branches 4016 0 -4016
==========================================
- Hits 27064 18178 -8886
+ Misses 15811 10865 -4946
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.58% <ø> (-0.30%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `63.29% <0.00%> (-16.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.56% <0.00%> (-9.42%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.60% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
| [...ws/CRUD/data/savedquery/SavedQueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlQcmV2aWV3TW9kYWwudHN4) | | |
| [.../src/explore/components/MetricDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
| [...src/explore/components/AdhocMetricStaticOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1N0YXRpY09wdGlvbi5qc3g=) | | |
| [...et-frontend/src/components/ConfirmStatusChange.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29uZmlybVN0YXR1c0NoYW5nZS50c3g=) | | |
| ... and [457 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] adam-stasiak commented on a change in pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on a change in pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#discussion_r523051467
##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/load.test.js
##########
@@ -59,12 +64,19 @@ describe('Dashboard load', () => {
requests.map(async xhr => {
expect(xhr.status).to.eq(200);
const responseBody = await readResponseBlob(xhr.response.body);
- expect(responseBody).to.have.property('errors');
- expect(responseBody.errors.length).to.eq(0);
- const sliceId = responseBody.form_data.slice_id;
- cy.get('[data-test="grid-content"]')
- .find(`#chart-id-${sliceId}`)
- .should('be.visible');
+ if (responseBody.result) {
+ responseBody.result.forEach(element => {
+ expect(element).to.have.property('error', null);
+ expect(element).to.have.property('status', 'success');
+ });
+ } else {
+ expect(responseBody).to.have.property('errors');
+ expect(responseBody.errors.length).to.eq(0);
+ const sliceId = responseBody.form_data.slice_id;
+ cy.get('[data-test="grid-content"]')
+ .find(`#chart-id-${sliceId}`)
+ .should('be.visible');
Review comment:
it is done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (1ad2353) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
+ Coverage 62.86% 62.87% +0.01%
==========================================
Files 889 435 -454
Lines 43054 26870 -16184
Branches 4016 0 -4016
==========================================
- Hits 27064 16895 -10169
+ Misses 15811 9975 -5836
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.87% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [...tend/src/dashboard/util/getFilterScopeNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlTm9kZXNUcmVlLmpz) | | |
| [...rontend/src/explore/components/AggregateOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZ2dyZWdhdGVPcHRpb24uanN4) | | |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | | |
| [...hboard/components/gridComponents/new/NewHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdIZWFkZXIuanN4) | | |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | | |
| [superset-frontend/src/logger/actions/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9hY3Rpb25zL2luZGV4Lmpz) | | |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...79ed65e](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] adam-stasiak commented on a change in pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on a change in pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#discussion_r523051605
##########
File path: superset-frontend/cypress-base/cypress/utils/vizPlugins.ts
##########
@@ -21,3 +21,26 @@ const V1_PLUGINS = ['box_plot', 'echarts_timeseries', 'word_cloud', 'pie'];
export function isLegacyChart(vizType: string): boolean {
return !V1_PLUGINS.includes(vizType);
}
+
+export function getChartAliases(slices: any[]): string[] {
+ const aliases: string[] = [];
+ console.log(slices);
+ Array.from(slices).forEach(slice => {
+ const vizType = slice.form_data.viz_type;
+ const isLegacy = isLegacyChart(vizType);
+ if (isLegacy) {
+ const alias = `getJson_${slice.slice_id}`;
+ const formData = `{"slice_id":${slice.slice_id}}`;
+ const route = `/superset/explore_json/?*${formData}*`;
+ cy.route('POST', `${route}`).as(alias);
+ aliases.push(`@${alias}`);
+ } else {
+ const alias = `getJson_v1_${slice.slice_id}`;
+ const route = `/api/v1/chart/data?*`;
+ cy.route('POST', `${route}`).as(alias);
+ aliases.push(`@${alias}`);
+ }
+ });
+ console.log(aliases);
+ return aliases;
+}
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (2eb1f36) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **increase** coverage by `3.85%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
+ Coverage 62.86% 66.71% +3.85%
==========================================
Files 889 889
Lines 43054 45235 +2181
Branches 4016 4015 -1
==========================================
+ Hits 27064 30177 +3113
+ Misses 15811 14956 -855
+ Partials 179 102 -77
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.00% <100.00%> (?)` | |
| javascript | `62.82% <100.00%> (+0.01%)` | :arrow_up: |
| python | `62.77% <ø> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `79.23% <100.00%> (+30.06%)` | :arrow_up: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `63.29% <0.00%> (-16.71%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `89.36% <0.00%> (-1.95%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `74.24% <0.00%> (-1.15%)` | :arrow_down: |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `77.17% <0.00%> (-0.85%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `73.03% <0.00%> (-0.83%)` | :arrow_down: |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `58.62% <0.00%> (-0.69%)` | :arrow_down: |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `66.14% <0.00%> (-0.53%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
| ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (2eb1f36) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.53% -0.33%
==========================================
Files 889 435 -454
Lines 43054 29042 -14012
Branches 4016 0 -4016
==========================================
- Hits 27064 18161 -8903
+ Misses 15811 10881 -4930
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.53% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `63.29% <0.00%> (-16.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.56% <0.00%> (-9.42%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.11% <0.00%> (-1.86%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.21% <0.00%> (-0.62%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.61% <0.00%> (-0.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.20% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [462 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (1ad2353) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
+ Coverage 62.86% 62.88% +0.02%
==========================================
Files 889 435 -454
Lines 43054 26870 -16184
Branches 4016 0 -4016
==========================================
- Hits 27064 16898 -10166
+ Misses 15811 9972 -5839
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.88% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/gridComponents/Row.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1Jvdy5qc3g=) | | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | | |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | | |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | | |
| [...ntend/src/dashboard/util/getRevertedFilterScope.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFJldmVydGVkRmlsdGVyU2NvcGUudHM=) | | |
| [superset-frontend/src/components/RefreshLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsLmpzeA==) | | |
| [...end/src/visualizations/TimeTable/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS90cmFuc2Zvcm1Qcm9wcy5qcw==) | | |
| [...uperset-frontend/src/components/AsyncAceEditor.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IudHN4) | | |
| ... and [444 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...79ed65e](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (2eb1f36) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.56% -0.30%
==========================================
Files 889 435 -454
Lines 43054 26868 -16186
Branches 4016 0 -4016
==========================================
- Hits 27064 16810 -10254
+ Misses 15811 10058 -5753
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.56% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.56% <0.00%> (-3.30%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.83% <0.00%> (-3.00%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.65% <0.00%> (-2.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.60% <0.00%> (-1.87%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.11% <0.00%> (-1.86%)` | :arrow_down: |
| ... and [460 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (2eb1f36) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.07% -0.80%
==========================================
Files 889 435 -454
Lines 43054 26868 -16186
Branches 4016 0 -4016
==========================================
- Hits 27064 16677 -10387
+ Misses 15811 10191 -5620
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.07% <ø> (-0.82%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.10% <0.00%> (-25.33%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.53% <0.00%> (-6.94%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.46% <0.00%> (-3.75%)` | :arrow_down: |
| ... and [465 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (2eb1f36) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.56% -0.30%
==========================================
Files 889 435 -454
Lines 43054 26870 -16184
Branches 4016 0 -4016
==========================================
- Hits 27064 16812 -10252
+ Misses 15811 10058 -5753
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.56% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.56% <0.00%> (-3.30%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.83% <0.00%> (-3.00%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.65% <0.00%> (-2.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.60% <0.00%> (-1.87%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.11% <0.00%> (-1.86%)` | :arrow_down: |
| ... and [458 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (8afc3cb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.75% -0.11%
==========================================
Files 889 889
Lines 43054 43054
Branches 4016 4016
==========================================
- Hits 27064 27018 -46
- Misses 15811 15857 +46
Partials 179 179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.81% <ø> (ø)` | |
| python | `62.71% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.77% <0.00%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...8afc3cb](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (1ad2353) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.30%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.55% -0.31%
==========================================
Files 889 435 -454
Lines 43054 26870 -16184
Branches 4016 0 -4016
==========================================
- Hits 27064 16809 -10255
+ Misses 15811 10061 -5750
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.55% <ø> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.56% <0.00%> (-3.30%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.83% <0.00%> (-3.00%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.65% <0.00%> (-2.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.60% <0.00%> (-1.87%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.11% <0.00%> (-1.86%)` | :arrow_down: |
| ... and [460 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...79ed65e](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#discussion_r522997410
##########
File path: superset-frontend/cypress-base/cypress/utils/vizPlugins.ts
##########
@@ -21,3 +21,26 @@ const V1_PLUGINS = ['box_plot', 'echarts_timeseries', 'word_cloud', 'pie'];
export function isLegacyChart(vizType: string): boolean {
return !V1_PLUGINS.includes(vizType);
}
+
+export function getChartAliases(slices: any[]): string[] {
+ const aliases: string[] = [];
+ console.log(slices);
+ Array.from(slices).forEach(slice => {
+ const vizType = slice.form_data.viz_type;
+ const isLegacy = isLegacyChart(vizType);
+ if (isLegacy) {
+ const alias = `getJson_${slice.slice_id}`;
+ const formData = `{"slice_id":${slice.slice_id}}`;
+ const route = `/superset/explore_json/?*${formData}*`;
+ cy.route('POST', `${route}`).as(alias);
+ aliases.push(`@${alias}`);
+ } else {
+ const alias = `getJson_v1_${slice.slice_id}`;
+ const route = `/api/v1/chart/data?*`;
+ cy.route('POST', `${route}`).as(alias);
+ aliases.push(`@${alias}`);
+ }
+ });
+ console.log(aliases);
+ return aliases;
+}
Review comment:
You can probably simplify this slightly by doing something similar to this:
```suggestion
export function getChartAliases(slices: any[]): string[] {
return slices.map(slice => {
const vizType = slice.form_data.viz_type;
const isLegacy = isLegacyChart(vizType);
if (isLegacy) {
const alias = `getJson_${slice.slice_id}`;
const formData = `{"slice_id":${slice.slice_id}}`;
const route = `/superset/explore_json/?*${formData}*`;
cy.route('POST', `${route}`).as(alias);
return `@${alias}`;
} else {
const alias = `getJson_v1_${slice.slice_id}`;
const route = `/api/v1/chart/data?*`;
cy.route('POST', `${route}`).as(alias);
return `@${alias}`;
}
});
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (2eb1f36) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.79% -0.07%
==========================================
Files 889 889
Lines 43054 45227 +2173
Branches 4016 4015 -1
==========================================
+ Hits 27064 28401 +1337
- Misses 15811 16648 +837
+ Partials 179 178 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.82% <100.00%> (+0.01%)` | :arrow_up: |
| python | `62.77% <ø> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.27% <100.00%> (+1.10%)` | :arrow_up: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `63.29% <0.00%> (-16.71%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `63.63% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/dashboard/util/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbnN0YW50cy50cw==) | `100.00% <0.00%> (ø)` | |
| [...ws/CRUD/data/savedquery/SavedQueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlQcmV2aWV3TW9kYWwudHN4) | `85.45% <0.00%> (+0.26%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.18% <0.00%> (+0.27%)` | :arrow_up: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.50% <0.00%> (+0.37%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.58% <0.00%> (+0.75%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (8afc3cb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.46% -0.40%
==========================================
Files 889 889
Lines 43054 43054
Branches 4016 4016
==========================================
- Hits 27064 26895 -169
- Misses 15811 15980 +169
Partials 179 179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.81% <ø> (ø)` | |
| python | `62.25% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.01% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.77% <0.00%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...8afc3cb](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (8afc3cb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.25% -0.61%
==========================================
Files 889 435 -454
Lines 43054 26870 -16184
Branches 4016 0 -4016
==========================================
- Hits 27064 16729 -10335
+ Misses 15811 10141 -5670
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.25% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.01% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.77% <0.00%> (-0.14%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | | |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...8afc3cb](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (2eb1f36) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.79% -0.07%
==========================================
Files 889 889
Lines 43054 45227 +2173
Branches 4016 4015 -1
==========================================
+ Hits 27064 28400 +1336
- Misses 15811 16649 +838
+ Partials 179 178 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.82% <100.00%> (+0.01%)` | :arrow_up: |
| python | `62.77% <ø> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.27% <100.00%> (+1.10%)` | :arrow_up: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `63.29% <0.00%> (-16.71%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `63.63% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/dashboard/util/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbnN0YW50cy50cw==) | `100.00% <0.00%> (ø)` | |
| [...ws/CRUD/data/savedquery/SavedQueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlQcmV2aWV3TW9kYWwudHN4) | `85.45% <0.00%> (+0.26%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.18% <0.00%> (+0.27%)` | :arrow_up: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.50% <0.00%> (+0.37%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.39% <0.00%> (+0.56%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (1ad2353) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.30%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.55% -0.31%
==========================================
Files 889 435 -454
Lines 43054 26870 -16184
Branches 4016 0 -4016
==========================================
- Hits 27064 16809 -10255
+ Misses 15811 10061 -5750
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.55% <ø> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.56% <0.00%> (-3.30%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.83% <0.00%> (-3.00%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.65% <0.00%> (-2.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.60% <0.00%> (-1.87%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.11% <0.00%> (-1.86%)` | :arrow_down: |
| ... and [460 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...79ed65e](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (8afc3cb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 61.90% -0.96%
==========================================
Files 889 435 -454
Lines 43054 26859 -16195
Branches 4016 0 -4016
==========================================
- Hits 27064 16627 -10437
+ Misses 15811 10232 -5579
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `61.90% <ø> (-0.99%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.94% <0.00%> (-6.02%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [472 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...8afc3cb](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (8afc3cb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.59%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.26% -0.60%
==========================================
Files 889 435 -454
Lines 43054 26859 -16195
Branches 4016 0 -4016
==========================================
- Hits 27064 16724 -10340
+ Misses 15811 10135 -5676
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.26% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.01% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.61% <0.00%> (-0.48%)` | :arrow_down: |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...8afc3cb](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (2eb1f36) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **increase** coverage by `3.72%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
+ Coverage 62.86% 66.58% +3.72%
==========================================
Files 889 889
Lines 43054 45235 +2181
Branches 4016 4015 -1
==========================================
+ Hits 27064 30121 +3057
+ Misses 15811 15008 -803
+ Partials 179 106 -73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.39% <100.00%> (?)` | |
| javascript | `62.82% <100.00%> (+0.01%)` | :arrow_up: |
| python | `62.77% <ø> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `79.23% <100.00%> (+30.06%)` | :arrow_up: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `63.29% <0.00%> (-16.71%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `89.36% <0.00%> (-1.95%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `74.24% <0.00%> (-1.15%)` | :arrow_down: |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `77.17% <0.00%> (-0.85%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `73.03% <0.00%> (-0.83%)` | :arrow_down: |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `58.62% <0.00%> (-0.69%)` | :arrow_down: |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `66.14% <0.00%> (-0.53%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
| ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (1ad2353) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
+ Coverage 62.86% 62.87% +0.01%
==========================================
Files 889 435 -454
Lines 43054 26870 -16184
Branches 4016 0 -4016
==========================================
- Hits 27064 16895 -10169
+ Misses 15811 9975 -5836
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.87% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | | |
| [superset-frontend/src/explore/dateFilterUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZGF0ZUZpbHRlclV0aWxzLnRz) | | |
| [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | | |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | | |
| [superset-frontend/src/components/ListView/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvaW5kZXgudHM=) | | |
| [.../src/explore/components/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9GaWx0ZXJEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
| [superset-frontend/src/views/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2luZGV4LnRzeA==) | | |
| [superset-frontend/src/dashboard/util/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbnN0YW50cy50cw==) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...79ed65e](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (8afc3cb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
=======================================
Coverage 62.86% 62.86%
=======================================
Files 889 889
Lines 43054 43054
Branches 4016 4016
=======================================
Hits 27064 27064
Misses 15811 15811
Partials 179 179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.81% <ø> (ø)` | |
| python | `62.88% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...8afc3cb](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (1ad2353) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.84% -0.02%
==========================================
Files 889 435 -454
Lines 43054 26870 -16184
Branches 4016 0 -4016
==========================================
- Hits 27064 16886 -10178
+ Misses 15811 9984 -5827
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.84% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.61% <0.00%> (-0.48%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.63% <0.00%> (-0.28%)` | :arrow_down: |
| [superset-frontend/src/components/FlashProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmxhc2hQcm92aWRlci50c3g=) | | |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | | |
| [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | | |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | | |
| ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...79ed65e](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#discussion_r522720221
##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/load.test.js
##########
@@ -43,14 +43,19 @@ describe('Dashboard load', () => {
slices.forEach(slice => {
const vizType = slice.form_data.viz_type;
const isLegacy = isLegacyChart(vizType);
- // TODO(villebro): enable V1 charts
if (isLegacy) {
const alias = `getJson_${slice.slice_id}`;
const formData = `{"slice_id":${slice.slice_id}}`;
const route = `/superset/explore_json/?*${formData}*`;
cy.route('POST', `${route}`).as(alias);
aliases.push(`@${alias}`);
}
+ else {
+ const alias = `getV1ChartJson`;
+ const route = `/api/v1/chart/data?*`;
+ cy.route('POST', `${route}`).as(alias);
+ aliases.push(`@${alias}`);
+ }
Review comment:
As the legacy/V1 routes are always the same, I wonder if it would make sense to add a function to get the route to the `vizPlugins.ts` utility?
##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/load.test.js
##########
@@ -59,12 +64,19 @@ describe('Dashboard load', () => {
requests.map(async xhr => {
expect(xhr.status).to.eq(200);
const responseBody = await readResponseBlob(xhr.response.body);
- expect(responseBody).to.have.property('errors');
- expect(responseBody.errors.length).to.eq(0);
- const sliceId = responseBody.form_data.slice_id;
- cy.get('[data-test="grid-content"]')
- .find(`#chart-id-${sliceId}`)
- .should('be.visible');
+ if (responseBody.result) {
+ responseBody.result.forEach(element => {
+ expect(element).to.have.property('error', null);
+ expect(element).to.have.property('status', 'success');
+ });
+ } else {
+ expect(responseBody).to.have.property('errors');
+ expect(responseBody.errors.length).to.eq(0);
+ const sliceId = responseBody.form_data.slice_id;
+ cy.get('[data-test="grid-content"]')
+ .find(`#chart-id-${sliceId}`)
+ .should('be.visible');
Review comment:
I assume this assertion should be possible to do for V1 requests if we have `slice_id` readily available? If so, perhaps we should add it to the V1 request so the request params are the same for V1 and legacy requests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (1ad2353) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
+ Coverage 62.86% 62.87% +0.01%
==========================================
Files 889 435 -454
Lines 43054 26870 -16184
Branches 4016 0 -4016
==========================================
- Hits 27064 16895 -10169
+ Misses 15811 9975 -5836
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.87% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/components/FormRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybVJvdy5qc3g=) | | |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | | |
| [...rc/explore/components/controls/TextAreaControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0QXJlYUNvbnRyb2wuanN4) | | |
| [...set-frontend/src/dashboard/util/injectCustomCss.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2luamVjdEN1c3RvbUNzcy5qcw==) | | |
| [...end/src/visualizations/TimeTable/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS90cmFuc2Zvcm1Qcm9wcy5qcw==) | | |
| [...nd/src/dashboard/components/gridComponents/Row.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1Jvdy5qc3g=) | | |
| [...-frontend/src/dashboard/util/getDragDropManager.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyYWdEcm9wTWFuYWdlci5qcw==) | | |
| [...end/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnRHJvcHBhYmxlLmpzeA==) | | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...79ed65e](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro closed pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
villebro closed pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (1ad2353) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
=======================================
Coverage 62.86% 62.86%
=======================================
Files 889 889
Lines 43054 43054
Branches 4016 4016
=======================================
Hits 27064 27064
Misses 15811 15811
Partials 179 179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.81% <ø> (ø)` | |
| python | `62.88% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...79ed65e](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (cb58c1b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
=======================================
Coverage 62.86% 62.86%
=======================================
Files 889 889
Lines 43054 43056 +2
Branches 4016 4015 -1
=======================================
+ Hits 27064 27067 +3
+ Misses 15811 15810 -1
Partials 179 179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.82% <100.00%> (+0.01%)` | :arrow_up: |
| python | `62.88% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.27% <100.00%> (+1.10%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (8afc3cb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.85% -0.01%
==========================================
Files 889 889
Lines 43054 43054
Branches 4016 4016
==========================================
- Hits 27064 27061 -3
- Misses 15811 15814 +3
Partials 179 179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.81% <ø> (ø)` | |
| python | `62.87% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...8afc3cb](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (1ad2353) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
+ Coverage 62.86% 62.87% +0.01%
==========================================
Files 889 435 -454
Lines 43054 26870 -16184
Branches 4016 0 -4016
==========================================
- Hits 27064 16895 -10169
+ Misses 15811 9975 -5836
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.87% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | | |
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQWN0aW9uc0Jhci50c3g=) | | |
| [.../src/explore/components/MetricDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | | |
| [.../dashboard/util/logging/findNonTabChildChartIds.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZE5vblRhYkNoaWxkQ2hhcnRJZHMuanM=) | | |
| [...d/util/logging/getLoadStatsPerTopLevelComponent.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZ2V0TG9hZFN0YXRzUGVyVG9wTGV2ZWxDb21wb25lbnQuanM=) | | |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | | |
| [...c/components/ListViewCard/ListViewCard.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0xpc3RWaWV3Q2FyZC5zdG9yaWVzLnRzeA==) | | |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | | |
| ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...79ed65e](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (2eb1f36) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.63% -0.23%
==========================================
Files 889 435 -454
Lines 43054 29043 -14011
Branches 4016 0 -4016
==========================================
- Hits 27064 18192 -8872
+ Misses 15811 10851 -4960
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.63% <ø> (-0.25%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `63.29% <0.00%> (-16.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.56% <0.00%> (-9.42%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/profile/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvaW5kZXgudHN4) | | |
| [...d/src/visualizations/TimeTable/FormattedNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9Gb3JtYXR0ZWROdW1iZXIuanN4) | | |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | | |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | | |
| [superset-frontend/src/components/ChartIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnRJY29uLnRzeA==) | | |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | | |
| ... and [456 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] adam-stasiak commented on a change in pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on a change in pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#discussion_r522844201
##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/load.test.js
##########
@@ -43,14 +43,19 @@ describe('Dashboard load', () => {
slices.forEach(slice => {
const vizType = slice.form_data.viz_type;
const isLegacy = isLegacyChart(vizType);
- // TODO(villebro): enable V1 charts
if (isLegacy) {
const alias = `getJson_${slice.slice_id}`;
const formData = `{"slice_id":${slice.slice_id}}`;
const route = `/superset/explore_json/?*${formData}*`;
cy.route('POST', `${route}`).as(alias);
aliases.push(`@${alias}`);
}
+ else {
+ const alias = `getV1ChartJson`;
+ const route = `/api/v1/chart/data?*`;
+ cy.route('POST', `${route}`).as(alias);
+ aliases.push(`@${alias}`);
+ }
Review comment:
If it is always the same and i put * at the end of the route -> I see benefit in suggested solution :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (1ad2353) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
+ Coverage 62.86% 62.87% +0.01%
==========================================
Files 889 435 -454
Lines 43054 26870 -16184
Branches 4016 0 -4016
==========================================
- Hits 27064 16894 -10170
+ Misses 15811 9976 -5835
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `62.87% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.64% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.61% <0.00%> (-0.48%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | | |
| [superset-frontend/src/utils/hostNamesConfig.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2hvc3ROYW1lc0NvbmZpZy5qcw==) | | |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | | |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | | |
| [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | | |
| [...rontend/src/dashboard/containers/DashboardGrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEdyaWQuanN4) | | |
| [...end/src/dashboard/util/findFirstParentContainer.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRGaXJzdFBhcmVudENvbnRhaW5lci5qcw==) | | |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | | |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...79ed65e](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11685: chore: V1 charts load cypress tests
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11685:
URL: https://github.com/apache/incubator-superset/pull/11685#issuecomment-726435242
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=h1) Report
> Merging [#11685](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=desc) (2eb1f36) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ec8ccd4cf14f20b86b9a088d6ffce00aad6f4be0?el=desc) (ec8ccd4) will **decrease** coverage by `0.15%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11685 +/- ##
==========================================
- Coverage 62.86% 62.70% -0.16%
==========================================
Files 889 889
Lines 43054 45227 +2173
Branches 4016 4015 -1
==========================================
+ Hits 27064 28360 +1296
- Misses 15811 16689 +878
+ Partials 179 178 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.82% <100.00%> (+0.01%)` | :arrow_up: |
| python | `62.63% <ø> (-0.25%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.27% <100.00%> (+1.10%)` | :arrow_up: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `63.29% <0.00%> (-16.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.56% <0.00%> (-9.42%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `63.63% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/dashboard/util/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbnN0YW50cy50cw==) | `100.00% <0.00%> (ø)` | |
| [...ws/CRUD/data/savedquery/SavedQueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlQcmV2aWV3TW9kYWwudHN4) | `85.45% <0.00%> (+0.26%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.18% <0.00%> (+0.27%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.19% <0.00%> (+0.36%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/11685/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=footer). Last update [ec8ccd4...2eb1f36](https://codecov.io/gh/apache/incubator-superset/pull/11685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org