You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/28 21:03:03 UTC

[GitHub] [incubator-nuttx-apps] patacongo opened a new pull request #696: apps/netutils/dhcpc/Kconfig: Auto-select CONFIG_NET_UDP_BINDTODEVICE

patacongo opened a new pull request #696:
URL: https://github.com/apache/incubator-nuttx-apps/pull/696


   ## Summary
   
   DHCPC depends on CONFIG_NET_UDP_BINDTODEVICE in many cases.  Safest thing is to just auto-select it whenever DHCPC is selected.
   
   ## Impact
   
   There may be circumstances where CONFIG_NET_UDP_BINDTODEVICE is not needed.
   
       $ find boards/ -name defconfig | xargs grep -l CONFIG_NETUTILS_DHCPC | xargs grep -l CONFIG_NET_UDP=y | wc -
            26      26    1496 -
   
       $ find boards/ -name defconfig | xargs grep -l CONFIG_NETUTILS_DHCPC | xargs grep -l CONFIG_NET_UDP=y | xargs grep -l BINDTODEVICE | wc -
             6       6     323 -
   
   ## Testing
   
   Only successful configuration and build was verified.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #696: apps/netutils/dhcpc/Kconfig: Auto-select CONFIG_NET_UDP_BINDTODEVICE

Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #696:
URL: https://github.com/apache/incubator-nuttx-apps/pull/696#issuecomment-828784256


   This change requires update to some DHCPC defconfig files that explicitly set CONFIG_NET_UDP_BINDTODEVICE.  This should be fixed with incubator-nuttx PR 3625


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #696: apps/netutils/dhcpc/Kconfig: Auto-select CONFIG_NET_UDP_BINDTODEVICE

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #696:
URL: https://github.com/apache/incubator-nuttx-apps/pull/696


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #696: apps/netutils/dhcpc/Kconfig: Auto-select CONFIG_NET_UDP_BINDTODEVICE

Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #696:
URL: https://github.com/apache/incubator-nuttx-apps/pull/696#issuecomment-828784256


   This change requires update to some DHCPC defconfig files that explicitly set CONFIG_NET_UDP_BINDTODEVICE.  Otherwise, the CI runs fail because the before and after defconfig files are not this same.  This CI probleml should be fixed with incubator-nuttx PR 3625
   
   Perhaps a better solution would be to remove CONFIG_NET_UDP_BINDTODEVICE altogether and just keep the feature enabled in all configurations?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #696: apps/netutils/dhcpc/Kconfig: Auto-select CONFIG_NET_UDP_BINDTODEVICE

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #696:
URL: https://github.com/apache/incubator-nuttx-apps/pull/696#issuecomment-828935845


   I found how to fix the issue with spresense:wifi
   I will send a separate PR later.
   
   ```
   diff --git a/netutils/dhcpc/Kconfig b/netutils/dhcpc/Kconfig 
   index 4b0f3df0..8c2cf4c7 100644 
   --- a/netutils/dhcpc/Kconfig 
   +++ b/netutils/dhcpc/Kconfig 
   @@ -7,7 +7,7 @@ config NETUTILS_DHCPC 
           bool "DHCP client" 
           default n 
           depends on NET_UDP && NET_BROADCAST && NET_IPv4 
   - select NET_UDP_BINDTODEVICE 
   + select NET_UDP_BINDTODEVICE if !NET_UDP_NO_STACK 
           ---help--- 
                   Enable support for the DHCP client. 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #696: apps/netutils/dhcpc/Kconfig: Auto-select CONFIG_NET_UDP_BINDTODEVICE

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #696:
URL: https://github.com/apache/incubator-nuttx-apps/pull/696#issuecomment-828930765


   Hmm, spresene:wifi now fails.
   
   ```
   nsh> renew wlan0
   ERROR: dhcpc_open() for 'wlan0' failed
   ```
   
   ```
   $ make savedefconfig 
   make[1]: Entering directory '/mnt/m2ssd/opensource/RTOS/nuttx/nuttx/libs/libxx'
   make[1]: Nothing to be done for 'dirlinks'.
   make[1]: Leaving directory '/mnt/m2ssd/opensource/RTOS/nuttx/nuttx/libs/libxx'
   make[1]: Entering directory '/mnt/m2ssd/opensource/RTOS/nuttx/nuttx/boards'
   make[1]: Nothing to be done for 'dirlinks'.
   make[1]: Leaving directory '/mnt/m2ssd/opensource/RTOS/nuttx/nuttx/boards'
   make[1]: Entering directory '/mnt/m2ssd/opensource/RTOS/nuttx/nuttx/openamp'
   make[1]: Nothing to be done for 'dirlinks'.
   make[1]: Leaving directory '/mnt/m2ssd/opensource/RTOS/nuttx/nuttx/openamp'
   make[1]: Entering directory '/mnt/m2ssd/opensource/RTOS/nuttx/apps'
   make[2]: Entering directory '/mnt/m2ssd/opensource/RTOS/nuttx/apps/platform'
   LN: platform/board to /mnt/m2ssd/opensource/RTOS/nuttx/apps/platform/dummy
   make[2]: Leaving directory '/mnt/m2ssd/opensource/RTOS/nuttx/apps/platform'
   make[1]: Leaving directory '/mnt/m2ssd/opensource/RTOS/nuttx/apps'
   make[1]: Entering directory '/mnt/m2ssd/opensource/RTOS/nuttx/apps'
   make[1]: Nothing to be done for 'preconfig'.
   make[1]: Leaving directory '/mnt/m2ssd/opensource/RTOS/nuttx/apps'
   warning: (NETUTILS_DHCPC) selects NET_UDP_BINDTODEVICE which has unmet direct dependencies (NET && NET_UDP && !NET_UDP_NO_STACK)
   warning: (NETUTILS_DHCPC) selects NET_UDP_BINDTODEVICE which has unmet direct dependencies (NET && NET_UDP && !NET_UDP_NO_STACK)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #696: apps/netutils/dhcpc/Kconfig: Auto-select CONFIG_NET_UDP_BINDTODEVICE

Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #696:
URL: https://github.com/apache/incubator-nuttx-apps/pull/696#issuecomment-828784256


   This change requires update to some DHCPC defconfig files that explicitly set CONFIG_NET_UDP_BINDTODEVICE.  This should be fixed with incubator-nuttx PR 3625
   
   Perhaps a better solution would be to remove CONFIG_NET_UDP_BINDTODEVICE altogether and just keep the feature enabled in all configurations?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #696: apps/netutils/dhcpc/Kconfig: Auto-select CONFIG_NET_UDP_BINDTODEVICE

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #696:
URL: https://github.com/apache/incubator-nuttx-apps/pull/696#issuecomment-828784256


   This change requires update to some DHCPC defconfig files that explicitly set CONFIG_NET_UDP_BINDTODEVICE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org