You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Stevan Malesevic (JIRA)" <de...@myfaces.apache.org> on 2007/12/28 19:55:43 UTC
[jira] Created: (TRINIDAD-883) RenderKitDecorator.getRenderKit
should not call getFactory on every call
RenderKitDecorator.getRenderKit should not call getFactory on every call
------------------------------------------------------------------------
Key: TRINIDAD-883
URL: https://issues.apache.org/jira/browse/TRINIDAD-883
Project: MyFaces Trinidad
Issue Type: Bug
Affects Versions: 1.2.4-core
Reporter: Stevan Malesevic
org.apache.myfaces.trinidadinternal.renderkit.RenderKitDecorator.getRenderKit() tries to get a instance of RenderKitFactory on every call. The problem is that getFactory call results in locking. Since, according to documentation, RenderKitFactory::getFactory returns a per-web-application instance of the appropriate implementation class for the specified JavaServer Faces factory class, RenderKitDecorator.getRenderKit() should just used cached RenderKitFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-883) RenderKitDecorator.getRenderKit
should not call getFactory on every call
Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gabrielle Crawford resolved TRINIDAD-883.
-----------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.7-core
1.0.7-core
> RenderKitDecorator.getRenderKit should not call getFactory on every call
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-883
> URL: https://issues.apache.org/jira/browse/TRINIDAD-883
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.4-core
> Reporter: Stevan Malesevic
> Assignee: Gabrielle Crawford
> Fix For: 1.0.7-core, 1.2.7-core
>
>
> org.apache.myfaces.trinidadinternal.renderkit.RenderKitDecorator.getRenderKit() tries to get a instance of RenderKitFactory on every call. The problem is that getFactory call results in locking. Since, according to documentation, RenderKitFactory::getFactory returns a per-web-application instance of the appropriate implementation class for the specified JavaServer Faces factory class, RenderKitDecorator.getRenderKit() should just used cached RenderKitFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-883) RenderKitDecorator.getRenderKit
should not call getFactory on every call
Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562749#action_12562749 ]
Gabrielle Crawford commented on TRINIDAD-883:
---------------------------------------------
It's not clear why the RI is locking in FactoryFinder.getFactory. Have filed.
https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=688
> RenderKitDecorator.getRenderKit should not call getFactory on every call
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-883
> URL: https://issues.apache.org/jira/browse/TRINIDAD-883
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.4-core
> Reporter: Stevan Malesevic
> Assignee: Gabrielle Crawford
>
> org.apache.myfaces.trinidadinternal.renderkit.RenderKitDecorator.getRenderKit() tries to get a instance of RenderKitFactory on every call. The problem is that getFactory call results in locking. Since, according to documentation, RenderKitFactory::getFactory returns a per-web-application instance of the appropriate implementation class for the specified JavaServer Faces factory class, RenderKitDecorator.getRenderKit() should just used cached RenderKitFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-883) RenderKitDecorator.getRenderKit
should not call getFactory on every call
Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571191#action_12571191 ]
Gabrielle Crawford commented on TRINIDAD-883:
---------------------------------------------
The RI cannot remove the locking. Fix in RenderKitDecorator is to save off the renderkitFactory on the applicationScopeConcurrentMap in order to avoid locking issues from FactoryFinder.getFactory
> RenderKitDecorator.getRenderKit should not call getFactory on every call
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-883
> URL: https://issues.apache.org/jira/browse/TRINIDAD-883
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.4-core
> Reporter: Stevan Malesevic
> Assignee: Gabrielle Crawford
>
> org.apache.myfaces.trinidadinternal.renderkit.RenderKitDecorator.getRenderKit() tries to get a instance of RenderKitFactory on every call. The problem is that getFactory call results in locking. Since, according to documentation, RenderKitFactory::getFactory returns a per-web-application instance of the appropriate implementation class for the specified JavaServer Faces factory class, RenderKitDecorator.getRenderKit() should just used cached RenderKitFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-883) RenderKitDecorator.getRenderKit
should not call getFactory on every call
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571286#action_12571286 ]
Matthias Weßendorf commented on TRINIDAD-883:
---------------------------------------------
why can't the RI remove locking?
This is potential an issue for MyFaces as well..
> RenderKitDecorator.getRenderKit should not call getFactory on every call
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-883
> URL: https://issues.apache.org/jira/browse/TRINIDAD-883
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.4-core
> Reporter: Stevan Malesevic
> Assignee: Gabrielle Crawford
> Fix For: 1.0.7-core, 1.2.7-core
>
>
> org.apache.myfaces.trinidadinternal.renderkit.RenderKitDecorator.getRenderKit() tries to get a instance of RenderKitFactory on every call. The problem is that getFactory call results in locking. Since, according to documentation, RenderKitFactory::getFactory returns a per-web-application instance of the appropriate implementation class for the specified JavaServer Faces factory class, RenderKitDecorator.getRenderKit() should just used cached RenderKitFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-883) RenderKitDecorator.getRenderKit
should not call getFactory on every call
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562849#action_12562849 ]
Matthias Weßendorf commented on TRINIDAD-883:
---------------------------------------------
Gabrielle,
what is myfaces doing?
> RenderKitDecorator.getRenderKit should not call getFactory on every call
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-883
> URL: https://issues.apache.org/jira/browse/TRINIDAD-883
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.4-core
> Reporter: Stevan Malesevic
> Assignee: Gabrielle Crawford
>
> org.apache.myfaces.trinidadinternal.renderkit.RenderKitDecorator.getRenderKit() tries to get a instance of RenderKitFactory on every call. The problem is that getFactory call results in locking. Since, according to documentation, RenderKitFactory::getFactory returns a per-web-application instance of the appropriate implementation class for the specified JavaServer Faces factory class, RenderKitDecorator.getRenderKit() should just used cached RenderKitFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-883) RenderKitDecorator.getRenderKit
should not call getFactory on every call
Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571522#action_12571522 ]
Gabrielle Crawford commented on TRINIDAD-883:
---------------------------------------------
The get and set in FactoryFinder are using/updating a list. See:
https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=688
> RenderKitDecorator.getRenderKit should not call getFactory on every call
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-883
> URL: https://issues.apache.org/jira/browse/TRINIDAD-883
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.4-core
> Reporter: Stevan Malesevic
> Assignee: Gabrielle Crawford
> Fix For: 1.0.7-core, 1.2.7-core
>
>
> org.apache.myfaces.trinidadinternal.renderkit.RenderKitDecorator.getRenderKit() tries to get a instance of RenderKitFactory on every call. The problem is that getFactory call results in locking. Since, according to documentation, RenderKitFactory::getFactory returns a per-web-application instance of the appropriate implementation class for the specified JavaServer Faces factory class, RenderKitDecorator.getRenderKit() should just used cached RenderKitFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-883) RenderKitDecorator.getRenderKit
should not call getFactory on every call
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562862#action_12562862 ]
Matthias Weßendorf commented on TRINIDAD-883:
---------------------------------------------
looks similar
> RenderKitDecorator.getRenderKit should not call getFactory on every call
> ------------------------------------------------------------------------
>
> Key: TRINIDAD-883
> URL: https://issues.apache.org/jira/browse/TRINIDAD-883
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.4-core
> Reporter: Stevan Malesevic
> Assignee: Gabrielle Crawford
>
> org.apache.myfaces.trinidadinternal.renderkit.RenderKitDecorator.getRenderKit() tries to get a instance of RenderKitFactory on every call. The problem is that getFactory call results in locking. Since, according to documentation, RenderKitFactory::getFactory returns a per-web-application instance of the appropriate implementation class for the specified JavaServer Faces factory class, RenderKitDecorator.getRenderKit() should just used cached RenderKitFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.