You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2023/04/04 14:58:05 UTC
[GitHub] [incubator-pekko-http] raboof opened a new pull request, #130: Scala 3 support
raboof opened a new pull request, #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130
Fixes #17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #130: Scala 3 support
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#issuecomment-1497195372
Thanks for bringing the Scala 3 branch up to the latest version, @raboof. Since we do not want to squash this branch but merge it, would it be possible to clean the commits up a bit? I'm not super concerned about all those little merges but maybe the cleanup/format commits could be squashed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #130: Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#issuecomment-1510233192
Incase people are not aware, we are discussing merging this branch for the initial release on the mailing list (https://lists.apache.org/thread/pcyfs9wqsd81od20mk3jtd0w04bf0lm6). As you can tell, there is overall agreement that this is a good idea.
@raboof From what I can tell the only thing that is necessary is to cleanup the commits, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #130: Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#issuecomment-1560933824
Closed in favour of https://github.com/apache/incubator-pekko-http/pull/150 which has the PR history cleaned up by @jrudolph and merged with latest `main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #130: Scala 3 support
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#discussion_r1179077650
##########
http-core/src/test/scala/org/apache/pekko/http/impl/model/parser/HttpHeaderSpec.scala:
##########
@@ -377,7 +377,10 @@ class HttpHeaderSpec extends AnyFreeSpec with Matchers {
"If-Match dispatching" in {
Review Comment:
We can also just remove the test which is probably not relevant any more.
##########
docs/src/test/scala/docs/http/scaladsl/server/directives/MiscDirectivesExamplesSpec.scala:
##########
@@ -131,7 +132,7 @@ class MiscDirectivesExamplesSpec extends RoutingSpec with CompileOnlySpec {
// tests:
def entityOfSize(size: Int) =
- HttpEntity(ContentTypes.`text/plain(UTF-8)`, "0" * size)
+ HttpEntity(ContentTypes.`text/plain(UTF-8)`, List.fill(size)('0').mkString)
Review Comment:
A bit ugly but what can you do... It's related to a conflict where `NameReceptacle` also adds an `*` extension method that seems to be more nicely resolved in Scala 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on pull request #130: Scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#issuecomment-1497540374
@raboof now that https://github.com/apache/incubator-pekko/pull/273 is merged, can you upgrade the scala 3 version to 3.2.2? - jackson 2.14.2 uses Scala v3.2 as the minimum supported version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich closed pull request #130: Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed pull request #130: Scala 3 support
URL: https://github.com/apache/incubator-pekko-http/pull/130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #130: Scala 3 support
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#discussion_r1179096906
##########
http-tests/src/test/scala-2.13-/src/main/org/apache/pekko/http/ccompat/ImplicitUtils.scala:
##########
@@ -0,0 +1,16 @@
+/*
Review Comment:
The source file paths are messed up here (can be cleaned up later).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] raboof commented on pull request #130: Scala 3 support
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#issuecomment-1510248577
> @raboof From what I can tell the only thing that is necessary is to cleanup the commits, correct?
I'd say it's cleaned up. *ideally* we'd rebase to fix 62afca7 where it was introduced instead of in a separate commit, but that goes back quite far and is tedious/error-prone, so I propose we just leave it where it is now.
Some more reviewing and testing would be good (I haven't tested in depth since a number of complicated rebases, so a mistake could have slipped in), otherwise I think this is probably good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on pull request #130: Scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#issuecomment-1560842945
@raboof could you update to Scala 3.3.0? Pekko core now uses that version (Scala 3.3.0 was released yesterday).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #130: Scala 3 support
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#discussion_r1179096207
##########
docs/src/test/scala/docs/http/scaladsl/server/directives/MiscDirectivesExamplesSpec.scala:
##########
@@ -131,7 +132,7 @@ class MiscDirectivesExamplesSpec extends RoutingSpec with CompileOnlySpec {
// tests:
def entityOfSize(size: Int) =
- HttpEntity(ContentTypes.`text/plain(UTF-8)`, "0" * size)
+ HttpEntity(ContentTypes.`text/plain(UTF-8)`, List.fill(size)('0').mkString)
Review Comment:
We've got `ImplicitUtils` in http-test which seems as if it could help with resolving this problem locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] raboof commented on pull request #130: Scala 3 support
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#issuecomment-1498664972
> would it be possible to clean the commits up a bit? I'm not super concerned about all those little merges but maybe the cleanup/format commits could be squashed?
Yes, done! (I forgot what a PITA rebasing merges was, even with `--rebase-merges` and `rerere` :laughing:)
> now that https://github.com/apache/incubator-pekko/pull/273 is merged, can you upgrade the scala 3 version to 3.2.2? - jackson 2.14.2 uses Scala v3.2 as the minimum supported version
Jup, done - I kinda had to since the build takes the latest Pekko snapshot by default, and that now indeed requires 3.2.2 for Scala 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #130: Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #130:
URL: https://github.com/apache/incubator-pekko-http/pull/130#issuecomment-1560844323
@pjfanning @raboof
@jrudolph Set up a cleaned up version of this branch with all of the merge conflicts removed, let me find it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org