You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Magyar <am...@hortonworks.com> on 2017/07/03 08:42:10 UTC

Review Request 60588: stackadvisor error during cluster creation, getOldValue is not defined

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60588/
-----------------------------------------------------------

Review request for Ambari, Laszlo Puskas, Sebastian Toader, and Vitalyi Brodetskyi.


Repository: ambari


Description
-------

self is missing in the python code


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 82656aa 


Diff: https://reviews.apache.org/r/60588/diff/1/


Testing
-------

- manually during cluster creation


Thanks,

Attila Magyar


Re: Review Request 60588: stackadvisor error during cluster creation, getOldValue is not defined

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60588/#review179496
-----------------------------------------------------------


Ship it!




Ship It!

- Attila Doroszlai


On July 3, 2017, 10:42 a.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60588/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 10:42 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Sebastian Toader, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21393
>     https://issues.apache.org/jira/browse/AMBARI-21393
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> self is missing in the python code
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 82656aa 
> 
> 
> Diff: https://reviews.apache.org/r/60588/diff/1/
> 
> 
> Testing
> -------
> 
> - manually during cluster creation
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>


Re: Review Request 60588: stackadvisor error during cluster creation, getOldValue is not defined

Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60588/#review179492
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On July 3, 2017, 10:42 a.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60588/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 10:42 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Sebastian Toader, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21393
>     https://issues.apache.org/jira/browse/AMBARI-21393
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> self is missing in the python code
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 82656aa 
> 
> 
> Diff: https://reviews.apache.org/r/60588/diff/1/
> 
> 
> Testing
> -------
> 
> - manually during cluster creation
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>


Re: Review Request 60588: stackadvisor error during cluster creation, getOldValue is not defined

Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60588/#review179485
-----------------------------------------------------------


Ship it!




Ship It!

- Laszlo Puskas


On July 3, 2017, 8:42 a.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60588/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 8:42 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Sebastian Toader, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21393
>     https://issues.apache.org/jira/browse/AMBARI-21393
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> self is missing in the python code
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 82656aa 
> 
> 
> Diff: https://reviews.apache.org/r/60588/diff/1/
> 
> 
> Testing
> -------
> 
> - manually during cluster creation
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>