[jira] [Commented] (ACCUMULO-1618) No ability to disable trash for root tablet & WAL

["John Vines (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738805#comment-13738805 ] 

John Vines commented on ACCUMULO-1618:
--------------------------------------

That isn't an adequate fix, IMO, due to HDFS-8689. With that, the server's configuration of fs.trash.interval takes precedent and can't be overridden by the client configuration. HDFS-4683 provides a tldr explanation in it by Doug Cutting as the top comment.

I believe the only satisfactory way to do it is to scope out all instances of fs.moveToTrash and put the appropriate config checks in place around them like we do in the SimpleGarbageCollector. Ideally we want the config's to be loaded more than once per server so it can be changed without a full system restart because the gc is light enough to get away with that but tservers aren't.
                
> No ability to disable trash for root tablet & WAL
> -------------------------------------------------
>
>                 Key: ACCUMULO-1618
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1618
>             Project: Accumulo
>          Issue Type: Bug
>          Components: tserver
>    Affects Versions: 1.5.0
>            Reporter: John Vines
>             Fix For: 1.5.1, 1.6.0
>
>         Attachments: ACCUMULO-1618.patch
>
>
> In 1.5 we changed the check in the garbage collector from a flag that gets passed in into a system setting. However, there are a few other places in the code where we want to provide the ability to bypass the trash. At least one is in the Tablet.java#bringMajorCompactionOnline. There is another case in the WALs, but the errors don't have stack traces.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira