[jira] [Comment Edited] (OAK-3794) The Cold Standby should expect loops in the segment graph

["Alex Parvulescu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058111#comment-15058111 ] 

Alex Parvulescu edited comment on OAK-3794 at 12/15/15 2:31 PM:
----------------------------------------------------------------

hmm, are you sure this is the case? there's some builtin protection against loops already [0].

[edit] right, read the latest on OAK-1828, seems like this is very much possible because of the way segments are scheduled for synchronization, if you get a dependency cycle, it might not be able to exit this loop.

[0] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-tarmk-standby/src/main/java/org/apache/jackrabbit/oak/plugins/segment/standby/store/StandbyStore.java#L93


was (Author: alex.parvulescu):
hmm, are you sure this is the case? there's some builtin protection against loops already [0].

[0] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-tarmk-standby/src/main/java/org/apache/jackrabbit/oak/plugins/segment/standby/store/StandbyStore.java#L93

> The Cold Standby should expect loops in the segment graph
> ---------------------------------------------------------
>
>                 Key: OAK-3794
>                 URL: https://issues.apache.org/jira/browse/OAK-3794
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: tarmk-standby
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: 1.4
>
>
> The fix for OAK-1828 introduces the possibility of loops in the segment graph. The Cold Standby client currently traverses the segment graph without keeping track of the visited segments. This makes the Cold Standby prone to infinite loops during one transfer operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)