You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/11 08:38:40 UTC

[GitHub] [arrow-datafusion] ygf11 opened a new issue, #4870: Port other sql_integration test cases to sqllogictest

ygf11 opened a new issue, #4870:
URL: https://github.com/apache/arrow-datafusion/issues/4870

**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**

As @jackwener suggested in https://github.com/apache/arrow-datafusion/pull/4826#discussion_r1064277025, we can port the other part of `sql_integration` to `sqllogictest` now.
The `sql_integration` tests are in `datafusion/core/tests/sql`:
```
aggregates.rs
avro.rs
cast.rs
create_drop.rs
decimal.rs
errors.rs
explain_analyze.rs
...
```

The difference:
* `sql_integration` will ensure the correctness of logical and physical plan.
* `sqllogictest` will ensure the result is correct.

For the test cases, if we want to ensure the correctness of the plan, the test should be reserved in `sql_integration`.

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #4870: Port other sql_integration test cases to sqllogictest

Posted by "alamb (via GitHub)" <gi...@apache.org>.

alamb commented on issue #4870:
URL: https://github.com/apache/arrow-datafusion/issues/4870#issuecomment-1520555265

   Yes, I agree -- thank you @aprimadi  - closing in favor of https://github.com/apache/arrow-datafusion/issues/4495


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] aprimadi commented on issue #4870: Port other sql_integration test cases to sqllogictest

Posted by "aprimadi (via GitHub)" <gi...@apache.org>.

aprimadi commented on issue #4870:
URL: https://github.com/apache/arrow-datafusion/issues/4870#issuecomment-1519104997

   Isn't this a duplicate of [4495](https://github.com/apache/arrow-datafusion/issues/4495)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #4870: Port other sql_integration test cases to sqllogictest

Posted by "alamb (via GitHub)" <gi...@apache.org>.

alamb closed issue #4870: Port other sql_integration test cases to sqllogictest
URL: https://github.com/apache/arrow-datafusion/issues/4870


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #4870: Port other sql_integration test cases to sqllogictest

Posted by GitBox <gi...@apache.org>.

alamb commented on issue #4870:
URL: https://github.com/apache/arrow-datafusion/issues/4870#issuecomment-1379485205

   Captured on https://github.com/apache/arrow-datafusion/issues/4460 where I have been collecting other related tickets


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org