You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/06 03:29:09 UTC
[GitHub] [incubator-gobblin] sv2000 opened a new pull request #3190: GOBBLIN-1351: Ensure KafkaStreamingExtractor shutdown is invoked on task shutdown
sv2000 opened a new pull request #3190:
URL: https://github.com/apache/incubator-gobblin/pull/3190
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1351
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
KafkaStreamingExtractor extends InstrumentedExtractorBase which currently does not invoke the shutdown() method when a task shutdown is requested.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Existing tests.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io commented on pull request #3190: GOBBLIN-1351: Ensure KafkaStreamingExtractor shutdown is invoked on task shutdown
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3190:
URL: https://github.com/apache/incubator-gobblin/pull/3190#issuecomment-755140299
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=h1) Report
> Merging [#3190](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=desc) (c4d2945) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/b1006b4da3f036cffdb81978faf3f26f3e577f76?el=desc) (b1006b4) will **decrease** coverage by `37.06%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3190 +/- ##
============================================
- Coverage 46.18% 9.11% -37.07%
+ Complexity 9753 1727 -8026
============================================
Files 2014 2014
Lines 77095 77138 +43
Branches 8559 8566 +7
============================================
- Hits 35606 7033 -28573
- Misses 38182 69419 +31237
+ Partials 3307 686 -2621
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...trumented/extractor/InstrumentedExtractorBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vaW5zdHJ1bWVudGVkL2V4dHJhY3Rvci9JbnN0cnVtZW50ZWRFeHRyYWN0b3JCYXNlLmphdmE=) | `0.00% <0.00%> (-48.15%)` | `0.00 <0.00> (-14.00)` | |
| [...tractor/extract/kafka/KafkaStreamingExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVN0cmVhbWluZ0V4dHJhY3Rvci5qYXZh) | `0.00% <0.00%> (-60.49%)` | `0.00 <0.00> (-20.00)` | |
| [...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...n/java/org/apache/gobblin/salesforce/SfConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2ZDb25maWcuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../org/apache/gobblin/yarn/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1061 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=footer). Last update [b1006b4...c4d2945](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3190: GOBBLIN-1351: Ensure KafkaStreamingExtractor shutdown is invoked on task shutdown
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3190:
URL: https://github.com/apache/incubator-gobblin/pull/3190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on pull request #3190: GOBBLIN-1351: Ensure KafkaStreamingExtractor shutdown is invoked on task shutdown
Posted by GitBox <gi...@apache.org>.
sv2000 commented on pull request #3190:
URL: https://github.com/apache/incubator-gobblin/pull/3190#issuecomment-755054474
@htran1 Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3190: GOBBLIN-1351: Ensure KafkaStreamingExtractor shutdown is invoked on task shutdown
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3190:
URL: https://github.com/apache/incubator-gobblin/pull/3190#issuecomment-755140299
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=h1) Report
> Merging [#3190](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=desc) (c4d2945) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/b1006b4da3f036cffdb81978faf3f26f3e577f76?el=desc) (b1006b4) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3190 +/- ##
============================================
+ Coverage 46.18% 46.20% +0.02%
- Complexity 9753 9769 +16
============================================
Files 2014 2016 +2
Lines 77095 77165 +70
Branches 8559 8568 +9
============================================
+ Hits 35606 35657 +51
- Misses 38182 38200 +18
- Partials 3307 3308 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...trumented/extractor/InstrumentedExtractorBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vaW5zdHJ1bWVudGVkL2V4dHJhY3Rvci9JbnN0cnVtZW50ZWRFeHRyYWN0b3JCYXNlLmphdmE=) | `46.42% <0.00%> (-1.72%)` | `14.00 <0.00> (ø)` | |
| [...tractor/extract/kafka/KafkaStreamingExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVN0cmVhbWluZ0V4dHJhY3Rvci5qYXZh) | `58.82% <0.00%> (-1.67%)` | `20.00 <0.00> (ø)` | |
| [...he/gobblin/source/PartitionAwareFileRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9QYXJ0aXRpb25Bd2FyZUZpbGVSZXRyaWV2ZXIuamF2YQ==) | `48.14% <0.00%> (-7.41%)` | `0.00% <0.00%> (ø%)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0.00%> (-1.43%)` | `4.00% <0.00%> (ø%)` | |
| [...g/apache/gobblin/writer/PartitionedDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9QYXJ0aXRpb25lZERhdGFXcml0ZXIuamF2YQ==) | `63.05% <0.00%> (-0.59%)` | `34.00% <0.00%> (ø%)` | |
| [...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh) | `10.24% <0.00%> (-0.04%)` | `5.00% <0.00%> (ø%)` | |
| [...e/gobblin/converter/KafkaSchemaChangeInjector.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9LYWZrYVNjaGVtYUNoYW5nZUluamVjdG9yLmphdmE=) | `87.50% <0.00%> (ø)` | `8.00% <0.00%> (?%)` | |
| [...r/GenericRecordBasedKafkaSchemaChangeInjector.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9HZW5lcmljUmVjb3JkQmFzZWRLYWZrYVNjaGVtYUNoYW5nZUluamVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...a/management/copy/publisher/CopyDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHVibGlzaGVyL0NvcHlEYXRhUHVibGlzaGVyLmphdmE=) | `75.33% <0.00%> (+1.33%)` | `32.00% <0.00%> (+1.00%)` | |
| [...n/java/org/apache/gobblin/writer/FsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Gc0RhdGFXcml0ZXIuamF2YQ==) | `76.10% <0.00%> (+6.38%)` | `15.00% <0.00%> (+1.00%)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=footer). Last update [b1006b4...c4d2945](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 closed pull request #3190: GOBBLIN-1351: Ensure KafkaStreamingExtractor shutdown is invoked on task shutdown
Posted by GitBox <gi...@apache.org>.
sv2000 closed pull request #3190:
URL: https://github.com/apache/incubator-gobblin/pull/3190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3190: GOBBLIN-1351: Ensure KafkaStreamingExtractor shutdown is invoked on task shutdown
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3190:
URL: https://github.com/apache/incubator-gobblin/pull/3190#issuecomment-755140299
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=h1) Report
> Merging [#3190](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=desc) (c4d2945) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/b1006b4da3f036cffdb81978faf3f26f3e577f76?el=desc) (b1006b4) will **decrease** coverage by `37.05%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3190 +/- ##
============================================
- Coverage 46.18% 9.12% -37.06%
+ Complexity 9753 1729 -8024
============================================
Files 2014 2016 +2
Lines 77095 77165 +70
Branches 8559 8568 +9
============================================
- Hits 35606 7044 -28562
- Misses 38182 69436 +31254
+ Partials 3307 685 -2622
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...trumented/extractor/InstrumentedExtractorBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vaW5zdHJ1bWVudGVkL2V4dHJhY3Rvci9JbnN0cnVtZW50ZWRFeHRyYWN0b3JCYXNlLmphdmE=) | `0.00% <0.00%> (-48.15%)` | `0.00 <0.00> (-14.00)` | |
| [...tractor/extract/kafka/KafkaStreamingExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVN0cmVhbWluZ0V4dHJhY3Rvci5qYXZh) | `0.00% <0.00%> (-60.49%)` | `0.00 <0.00> (-20.00)` | |
| [...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...n/java/org/apache/gobblin/salesforce/SfConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2ZDb25maWcuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../org/apache/gobblin/yarn/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1062 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3190/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=footer). Last update [b1006b4...c4d2945](https://codecov.io/gh/apache/incubator-gobblin/pull/3190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org