You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jonkeane (via GitHub)" <gi...@apache.org> on 2025/01/04 14:40:43 UTC
[PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
jonkeane opened a new pull request, #45173:
URL: https://github.com/apache/arrow/pull/45173
This is minor and a non-official release to get past a GCC 15 error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571329554
Revision: 133303e2704061f571afbaa2c37dfdc46b42b225
Submitted crossbow builds: [ursacomputing/crossbow @ actions-e6592b6365](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e6592b6365)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/12611510367/job/35147249284)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.1 [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571371591
> release 18.1.0.1, use the released 18.1.0 binaries everywhere, but include the patch in the source code (which is what CRAN will build + check with GCC15).
Yes this. As there is no actual change to the binaries (we don't build them with GCC 15) we can just update the source tarball used for cran so we pass on an unreleased compiler version (... :facepalm:).
Thanks for getting this ready and a happy new year!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571343357
Revision: 62552289888639e4db0f9b517e02ee2d82aca614
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5e529189a9](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5e529189a9)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/12611872354/job/35147993793)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571322583
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571684816
Thanks, all! I've got everything prepared and will submit on the seventh when CRAN is back open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571342759
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.1 [arrow]
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571420525
Agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane closed pull request #45173: WIP: [R] Verify CRAN release 18.1.0.1
URL: https://github.com/apache/arrow/pull/45173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571323333
Revision: cc4e0f31dc18c7b57846295936ee3172dd967674
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0533803ddb](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0533803ddb)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361531/job/35146938335)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361505/job/35146934404)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361412/job/35146934081)|
|test-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361476/job/35146934248)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/35146934456)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361479/job/35146934288)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361498/job/35146934299)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361406/job/35146934093)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361601/job/35146934672)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361438/job/35146934117)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361441/job/35146934127)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361506/job/35146934381)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361524/job/35146934528)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361525/job/35146934678)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361407/job/35146934040)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361456/job/35146934177)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361427/job/35146934039)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/35146934675)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361547/job/35146934524)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/35146934452)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/35146934542)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/35146934576)|
|test-r-rhub-ubuntu-release-latest|[](https://github.com/ursacomputing/crossbow/runs/35146934578)|
|test-r-rocker-r-ver-latest|[](https://github.com/ursacomputing/crossbow/runs/35146934798)|
|test-r-rstudio-r-base-4.1-opensuse155|[](https://github.com/ursacomputing/crossbow/runs/35146934703)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/35146934664)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361584/job/35146934606)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361464/job/35146934336)|
|test-ubuntu-r-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/12611361623/job/35146934738)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.1 [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571454825
+1 to the simpler approach given the reason we're doing it. Thanks @jonkeane!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571329031
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571353624
Revision: cdd0b79b30204bc5f8f4313bb001144c82483917
Submitted crossbow builds: [ursacomputing/crossbow @ actions-68bea26e94](https://github.com/ursacomputing/crossbow/branches/all?query=actions-68bea26e94)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/12612151649/job/35148592983)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571322843
@github-actions crossbow submit --group r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.0.1 [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571353141
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.1 [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571367234
I'm trying to get a release ready to send to CRAN before our 14 January deadline. The only operative change that this branch has is https://github.com/apache/arrow/pull/45173/commits/cc4e0f31dc18c7b57846295936ee3172dd967674 (I also had to backport @amoeba 's CI fixes thanks for those!).
The binary job runs, but I don't actually know the process to get the binaries that are created in the CI job to the jfrog repository. @amoeba @assignUser any thoughts about what to do here? Is this a manual step (with key signing and all of that)?
I wanted to make the version 18.1.0.1 (that's why the branch is named such) since it's just this one patch to a dependency, but our version number + binary finder only looks at the first three version components https://github.com/apache/arrow/blob/3752109d64e3a02eaaa636a037141a51fae46819/r/tools/nixlibs.R#L967 Or maybe we could exploit this fact slightly and release 18.1.0.1, use the released 18.1.0 binaries everywhere, but include the patch in the source code (which is what CRAN will build + check with GCC15). That's a little bit funny because the binary folks are using is slightly different from the source version, but I'm pretty sure that would work. cc @nealrichardson and @thisisnic here too if there are 🚨 that that would be a bad plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [R] Verify CRAN release 18.1.1 [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #45173:
URL: https://github.com/apache/arrow/pull/45173#issuecomment-2571375697
Thanks for working on this @jonkeane. Shipping the patch in the source tarball seems like the best approach to me too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org