You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by si...@apache.org on 2012/10/27 23:09:50 UTC
svn commit: r1402871 - in /lucene/dev/branches/LUCENE-2878/lucene: join/src/java/org/apache/lucene/search/join/ queries/src/java/org/apache/lucene/queries/function/

Author: simonw
Date: Sat Oct 27 21:09:49 2012
New Revision: 1402871

URL: http://svn.apache.org/viewvc?rev=1402871&view=rev
Log:
remove nocommits

Modified:
    lucene/dev/branches/LUCENE-2878/lucene/join/src/java/org/apache/lucene/search/join/ToChildBlockJoinQuery.java
    lucene/dev/branches/LUCENE-2878/lucene/queries/src/java/org/apache/lucene/queries/function/FunctionQuery.java
    lucene/dev/branches/LUCENE-2878/lucene/queries/src/java/org/apache/lucene/queries/function/ValueSourceScorer.java

Modified: lucene/dev/branches/LUCENE-2878/lucene/join/src/java/org/apache/lucene/search/join/ToChildBlockJoinQuery.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/LUCENE-2878/lucene/join/src/java/org/apache/lucene/search/join/ToChildBlockJoinQuery.java?rev=1402871&r1=1402870&r2=1402871&view=diff
==============================================================================
--- lucene/dev/branches/LUCENE-2878/lucene/join/src/java/org/apache/lucene/search/join/ToChildBlockJoinQuery.java (original)
+++ lucene/dev/branches/LUCENE-2878/lucene/join/src/java/org/apache/lucene/search/join/ToChildBlockJoinQuery.java Sat Oct 27 21:09:49 2012
@@ -304,7 +304,7 @@ public class ToChildBlockJoinQuery exten
     }
 
     @Override
-    public IntervalIterator intervals(boolean collectIntervals) throws IOException {      // nocommit is that correct here?
+    public IntervalIterator intervals(boolean collectIntervals) throws IOException {
       return parentScorer.intervals(collectIntervals);
     }
   }

Modified: lucene/dev/branches/LUCENE-2878/lucene/queries/src/java/org/apache/lucene/queries/function/FunctionQuery.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/LUCENE-2878/lucene/queries/src/java/org/apache/lucene/queries/function/FunctionQuery.java?rev=1402871&r1=1402870&r2=1402871&view=diff
==============================================================================
--- lucene/dev/branches/LUCENE-2878/lucene/queries/src/java/org/apache/lucene/queries/function/FunctionQuery.java (original)
+++ lucene/dev/branches/LUCENE-2878/lucene/queries/src/java/org/apache/lucene/queries/function/FunctionQuery.java Sat Oct 27 21:09:49 2012
@@ -178,8 +178,7 @@ public class FunctionQuery extends Query
 
     @Override
     public IntervalIterator intervals(boolean collectIntervals) throws IOException {
-      throw new UnsupportedOperationException();
-      //nocommit - is that correct here?
+      throw new UnsupportedOperationException("AllScorer doesn't support interval iterators.");
     }
   }
 

Modified: lucene/dev/branches/LUCENE-2878/lucene/queries/src/java/org/apache/lucene/queries/function/ValueSourceScorer.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/LUCENE-2878/lucene/queries/src/java/org/apache/lucene/queries/function/ValueSourceScorer.java?rev=1402871&r1=1402870&r2=1402871&view=diff
==============================================================================
--- lucene/dev/branches/LUCENE-2878/lucene/queries/src/java/org/apache/lucene/queries/function/ValueSourceScorer.java (original)
+++ lucene/dev/branches/LUCENE-2878/lucene/queries/src/java/org/apache/lucene/queries/function/ValueSourceScorer.java Sat Oct 27 21:09:49 2012
@@ -90,8 +90,7 @@ public class ValueSourceScorer extends S
 
   @Override
   public IntervalIterator intervals(boolean collectIntervals) throws IOException {    
-    throw new UnsupportedOperationException();
-    //nocommit - is that correct here?
+    throw new UnsupportedOperationException("ValueSourceScorer doesn't support interval iterators.");
   }
 
   @Override