You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by pk...@apache.org on 2023/09/01 09:31:02 UTC

[nuttx] branch master updated: usrsock_server: fix coverity for recvfrom handle

This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
     new b30a389459 usrsock_server: fix coverity for recvfrom handle
b30a389459 is described below

commit b30a3894590b827ebe088040dde67ed98bd64409
Author: zhanghongyu <zh...@xiaomi.com>
AuthorDate: Wed Aug 30 10:04:49 2023 +0800

    usrsock_server: fix coverity for recvfrom handle
    
    req->usockid may not be in a valid range when ret less than zero and not -EAGAIN.
    
    Signed-off-by: zhanghongyu <zh...@xiaomi.com>
---
 drivers/usrsock/usrsock_rpmsg_server.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usrsock/usrsock_rpmsg_server.c b/drivers/usrsock/usrsock_rpmsg_server.c
index 151a771f1e..6e038796ba 100644
--- a/drivers/usrsock/usrsock_rpmsg_server.c
+++ b/drivers/usrsock/usrsock_rpmsg_server.c
@@ -642,7 +642,7 @@ static int usrsock_rpmsg_recvfrom_handler(FAR struct rpmsg_endpoint *ept,
             events, req->head.xid, totlen, iov[i].iov_len);
     }
 
-  if (retr >= 0 && events == 0)
+  if (retr >= 0 && (ret > 0 || ret == -EAGAIN) && events == 0)
     {
       usrsock_rpmsg_poll_setup(&priv->pfds[req->usockid],
                                priv->pfds[req->usockid].events | POLLIN);