You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/06/08 09:24:11 UTC

[PR] Fix relational delete node serialization [iotdb]

Caideyipi opened a new pull request, #17867:
URL: https://github.com/apache/iotdb/pull/17867

   ## Description
   
   This PR fixes relational delete node serialization so table-model delete data events preserve the database name consistently.
   
   - Write `databaseName` in `RelationalDeleteDataNode` WAL serialization to match WAL deserialization.
   - Include `databaseName` in `serializedSize()` and equality/hash code.
   - Cover non-null database name in the existing serialization test.
   
   Related to #17816.
   
   ## Tests
   
   - `mvn -pl iotdb-core/datanode spotless:apply`
   - `git diff --check`
   - `java -cp ... org.junit.runner.JUnitCore org.apache.iotdb.db.queryengine.plan.planner.plan.node.write.RelationalDeleteDataNodeTest`
   
   `mvn -pl iotdb-core/datanode -Dtest=RelationalDeleteDataNodeTest test` does not reach the test phase in this checkout because datanode compilation currently fails on unrelated `MemoryReservationManager` signature mismatches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix relational delete node serialization [iotdb]

Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #17867:
URL: https://github.com/apache/iotdb/pull/17867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org