Re: svn commit: r1871810 - in /httpd/httpd/trunk: CHANGESmodules/http2/h2_mplx.c modules/http2/h2_session.c modules/http2/h2_util.cmodules/http2/h2_util.h modules/http2/h2_version.h modules/http2/h2_workers.c modules/http2/mod_proxy_http2.c

[Steffen <in...@apachelounge.com>]

Current trunk 1.15.5  builds on windows with the warnings:


h2_conn_io.c(121,80): warning C4146: unary minus operator applied to 
unsigned type, result still unsigned
h2_from_h1.c(241,27): warning C4018: '<': signed/unsigned mismatch
h2_mplx.c(930,37): warning C4018: '>': signed/unsigned mismatch
h2_push.c(877,23): warning C4018: '<': signed/unsigned mismatch
h2_push.c(883,23): warning C4018: '<': signed/unsigned mismatch
h2_session.c(642,22): warning C4018: '<': signed/unsigned mismatch
h2_session.c(647,28): warning C4018: '>': signed/unsigned mismatch
h2_session.c(648,27): warning C4018: '<=': signed/unsigned mismatch
h2_stream.c(145,20): warning C4018: '>=': signed/unsigned mismatch
h2_stream.c(697,20): warning C4018: '>': signed/unsigned mismatch
h2_stream.c(708,32): warning C4018: '>': signed/unsigned mismatch
h2_stream.c(794,1): warning C4003: not enough arguments for 
function-like macro invocation 'APLOGNO'
h2_util.c(471,19): warning C4018: '<': signed/unsigned mismatch
h2_util.c(1248,21): warning C4244: 'function': conversion from 
'apr_off_t' to 'apr_size_t', possible loss of data
h2_util.c(1293,21): warning C4244: 'function': conversion from 
'apr_off_t' to 'apr_size_t', possible loss of data
h2_util.c(1398,17): warning C4244: 'function': conversion from 
'apr_off_t' to 'apr_size_t', possible loss of data



On Thursday 19/12/2019 at 12:59, Yann Ylavic  wrote:
> On Thu, Dec 19, 2019 at 10:39 AM <ic...@apache.org> wrote:
> []
>>
>>
>> Modified: httpd/httpd/trunk/modules/http2/h2_mplx.c
>> URL: 
>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_mplx.c?rev=1871810&r1=1871809&r2=1871810&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/http2/h2_mplx.c (original)
>> +++ httpd/httpd/trunk/modules/http2/h2_mplx.c Thu Dec 19 09:39:22 2019
> []
>>
>>
>> @@ -508,12 +511,11 @@ static void output_produced(void *ctx, h
>>            h2_stream *stream = ctx;
>>            h2_mplx *m = stream->session->mplx;
>>
>> -    check_data_for(m, stream, 1);
>> +    check_data_for(m, stream, 0);
>>    }
>
> This should be mplx_is_locked=1, no? It seems that h2_mplx_out_open()
> takes the lock, then calls out_open() => output_produced().