[GitHub] [spark] MaxGekk commented on a change in pull request #35655: [SPARK-38315][SQL] Add a config to control decoding of datetime as Java 8 classes

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #35655:
URL: https://github.com/apache/spark/pull/35655#discussion_r814818470



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/sources/TableScanSuite.scala
##########
@@ -109,6 +110,19 @@ case class AllDataTypesScan(
   }
 }
 
+class LegacyTimestampSource extends RelationProvider {

Review comment:
       I am not quite sure that I got your point. You proposed to add a config for `collect()` (which can control ONLY decoding, obviously) and to write a test using the DS write API? How (does `collect()` involve the write API)? Could you clarify, please.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org