You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by Shane Dell <sh...@apache.org> on 2022/11/28 19:54:08 UTC
[VOTE] Apache Daffodil VS Code Extension 1.2.0-rc2
Hello all,I'd like to call a vote to release Apache Daffodil VS Code 1.2.0-rc2.
All distribution packages, including signatures, digests, etc. can be
found at:
https://dist.apache.org/repos/dist/dev/daffodil/daffodil-vscode/1.2.0-rc2/
This release has been signed with PGP key
86DDE7B41291E380237934F007570D3ADC76D51B, corresponding
to shanedell@apache.org, which is included in the KEYS file here:
https://downloads.apache.org/daffodil/KEYS
The release candidate has been tagged in git with 1.2.0-rc2.
For reference, here is a list of all closed GitHub issues tagged with 1.2.0:
https://github.com/apache/daffodil-vscode/milestone/3?closed=1
Please review and vote. The vote will be open for at least 72 hours
(Thursday, 1 December 2022, 3:00pm EST).
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Thank you,
- Shane Dell
Re: [VOTE] Apache Daffodil VS Code Extension 1.2.0-rc2
Posted by Shane Dell <sh...@apache.org>.
Mike,
Good fine this was actually an issue in a file using the wrong variable name. It was checking config.daffodilDebugClassPath instead of config.daffodilDebugClasspath causing the classpath not to set. I will make an issue for this on GitHub.
On 2022/11/29 22:51:20 Mike Beckerle wrote:
> Verified the GPG signatures
> Verified the sha512 checksums
>
> Alas, -1 because I couldn't get my standard (since 1.1.0) "check out
> vscode" DFDL application to work.
>
> This could be pilot error, but I'm just trying to get PCAP+EthernetIP DFDL
> schemas to work and debug, which worked with 1.1.0, but I can't get it to
> work with 1.2.0.
>
> It's behaving as if the launch.json daffdilDebugClasspath doesn't work. It
> can't find an include file that is supplied for pcap.dfdl.xsd from the
> ethernetIP schema.
>
> Steps to reproduce:
>
> git clone the PCAP and ethernetIP DFDL schemas from github DFDLSchemas
> repositories.
>
> Make sure the two directories are named exactly "PCAP" and "ethernetIP" and
> are sibling directories. (These names will get used in attached launch.json)
>
> modify build.sbt in both to use Daffodil 3.4.0
>
> check out that they work from sbt:
> * cd ethernetIP ; sbt test ; sbt publishLocal // should publish version
> 1.2.0 of ethernetIP. All tests should pass.
> * cd ../PCAP ; sbt test // should pass all tests.
>
> Now, open VSCode and nstall the 1.2.0 vsix.
>
> Now open the PCAP folder in vscode.
>
> Use the attached launch.json.
>
> Either of the two launch configs should work. Both give the same problem:
>
> [image: image.png]
>
>
>
>
>
> On Mon, Nov 28, 2022 at 2:54 PM Shane Dell <sh...@apache.org> wrote:
>
> > Hello all,I'd like to call a vote to release Apache Daffodil VS Code
> > 1.2.0-rc2.
> >
> > All distribution packages, including signatures, digests, etc. can be
> > found at:
> > https://dist.apache.org/repos/dist/dev/daffodil/daffodil-vscode/1.2.0-rc2/
> >
> > This release has been signed with PGP key
> > 86DDE7B41291E380237934F007570D3ADC76D51B, corresponding
> > to shanedell@apache.org, which is included in the KEYS file here:
> > https://downloads.apache.org/daffodil/KEYS
> >
> > The release candidate has been tagged in git with 1.2.0-rc2.
> >
> > For reference, here is a list of all closed GitHub issues tagged with
> > 1.2.0:
> > https://github.com/apache/daffodil-vscode/milestone/3?closed=1
> >
> > Please review and vote. The vote will be open for at least 72 hours
> > (Thursday, 1 December 2022, 3:00pm EST).
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Thank you,
> >
> > - Shane Dell
> >
>
Re: [VOTE] Apache Daffodil VS Code Extension 1.2.0-rc2
Posted by Mike Beckerle <mb...@apache.org>.
I recommend RC3. But.... I really didn't check anything else after getting
blocked on this one. So I can't say whether there are other issues yet.
On Wed, Nov 30, 2022 at 1:47 PM Shane Dell <sh...@apache.org> wrote:
> Mike, did you notice any other issues that should be fixed or was this the
> main one? As for the Vote should it be left open or should I close it and
> do an rc3 since this bug you found is a pretty important item that should
> be working when debugging?
>
> On 2022/11/29 22:51:20 Mike Beckerle wrote:
> > Verified the GPG signatures
> > Verified the sha512 checksums
> >
> > Alas, -1 because I couldn't get my standard (since 1.1.0) "check out
> > vscode" DFDL application to work.
> >
> > This could be pilot error, but I'm just trying to get PCAP+EthernetIP
> DFDL
> > schemas to work and debug, which worked with 1.1.0, but I can't get it to
> > work with 1.2.0.
> >
> > It's behaving as if the launch.json daffdilDebugClasspath doesn't work.
> It
> > can't find an include file that is supplied for pcap.dfdl.xsd from the
> > ethernetIP schema.
> >
> > Steps to reproduce:
> >
> > git clone the PCAP and ethernetIP DFDL schemas from github DFDLSchemas
> > repositories.
> >
> > Make sure the two directories are named exactly "PCAP" and "ethernetIP"
> and
> > are sibling directories. (These names will get used in attached
> launch.json)
> >
> > modify build.sbt in both to use Daffodil 3.4.0
> >
> > check out that they work from sbt:
> > * cd ethernetIP ; sbt test ; sbt publishLocal // should publish version
> > 1.2.0 of ethernetIP. All tests should pass.
> > * cd ../PCAP ; sbt test // should pass all tests.
> >
> > Now, open VSCode and nstall the 1.2.0 vsix.
> >
> > Now open the PCAP folder in vscode.
> >
> > Use the attached launch.json.
> >
> > Either of the two launch configs should work. Both give the same problem:
> >
> > [image: image.png]
> >
> >
> >
> >
> >
> > On Mon, Nov 28, 2022 at 2:54 PM Shane Dell <sh...@apache.org> wrote:
> >
> > > Hello all,I'd like to call a vote to release Apache Daffodil VS Code
> > > 1.2.0-rc2.
> > >
> > > All distribution packages, including signatures, digests, etc. can be
> > > found at:
> > >
> https://dist.apache.org/repos/dist/dev/daffodil/daffodil-vscode/1.2.0-rc2/
> > >
> > > This release has been signed with PGP key
> > > 86DDE7B41291E380237934F007570D3ADC76D51B, corresponding
> > > to shanedell@apache.org, which is included in the KEYS file here:
> > > https://downloads.apache.org/daffodil/KEYS
> > >
> > > The release candidate has been tagged in git with 1.2.0-rc2.
> > >
> > > For reference, here is a list of all closed GitHub issues tagged with
> > > 1.2.0:
> > > https://github.com/apache/daffodil-vscode/milestone/3?closed=1
> > >
> > > Please review and vote. The vote will be open for at least 72 hours
> > > (Thursday, 1 December 2022, 3:00pm EST).
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> > > Thank you,
> > >
> > > - Shane Dell
> > >
> >
>
Re: [VOTE] Apache Daffodil VS Code Extension 1.2.0-rc2
Posted by Shane Dell <sh...@apache.org>.
Mike, did you notice any other issues that should be fixed or was this the main one? As for the Vote should it be left open or should I close it and do an rc3 since this bug you found is a pretty important item that should be working when debugging?
On 2022/11/29 22:51:20 Mike Beckerle wrote:
> Verified the GPG signatures
> Verified the sha512 checksums
>
> Alas, -1 because I couldn't get my standard (since 1.1.0) "check out
> vscode" DFDL application to work.
>
> This could be pilot error, but I'm just trying to get PCAP+EthernetIP DFDL
> schemas to work and debug, which worked with 1.1.0, but I can't get it to
> work with 1.2.0.
>
> It's behaving as if the launch.json daffdilDebugClasspath doesn't work. It
> can't find an include file that is supplied for pcap.dfdl.xsd from the
> ethernetIP schema.
>
> Steps to reproduce:
>
> git clone the PCAP and ethernetIP DFDL schemas from github DFDLSchemas
> repositories.
>
> Make sure the two directories are named exactly "PCAP" and "ethernetIP" and
> are sibling directories. (These names will get used in attached launch.json)
>
> modify build.sbt in both to use Daffodil 3.4.0
>
> check out that they work from sbt:
> * cd ethernetIP ; sbt test ; sbt publishLocal // should publish version
> 1.2.0 of ethernetIP. All tests should pass.
> * cd ../PCAP ; sbt test // should pass all tests.
>
> Now, open VSCode and nstall the 1.2.0 vsix.
>
> Now open the PCAP folder in vscode.
>
> Use the attached launch.json.
>
> Either of the two launch configs should work. Both give the same problem:
>
> [image: image.png]
>
>
>
>
>
> On Mon, Nov 28, 2022 at 2:54 PM Shane Dell <sh...@apache.org> wrote:
>
> > Hello all,I'd like to call a vote to release Apache Daffodil VS Code
> > 1.2.0-rc2.
> >
> > All distribution packages, including signatures, digests, etc. can be
> > found at:
> > https://dist.apache.org/repos/dist/dev/daffodil/daffodil-vscode/1.2.0-rc2/
> >
> > This release has been signed with PGP key
> > 86DDE7B41291E380237934F007570D3ADC76D51B, corresponding
> > to shanedell@apache.org, which is included in the KEYS file here:
> > https://downloads.apache.org/daffodil/KEYS
> >
> > The release candidate has been tagged in git with 1.2.0-rc2.
> >
> > For reference, here is a list of all closed GitHub issues tagged with
> > 1.2.0:
> > https://github.com/apache/daffodil-vscode/milestone/3?closed=1
> >
> > Please review and vote. The vote will be open for at least 72 hours
> > (Thursday, 1 December 2022, 3:00pm EST).
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Thank you,
> >
> > - Shane Dell
> >
>
Re: [VOTE] Apache Daffodil VS Code Extension 1.2.0-rc2
Posted by Mike Beckerle <mb...@apache.org>.
Verified the GPG signatures
Verified the sha512 checksums
Alas, -1 because I couldn't get my standard (since 1.1.0) "check out
vscode" DFDL application to work.
This could be pilot error, but I'm just trying to get PCAP+EthernetIP DFDL
schemas to work and debug, which worked with 1.1.0, but I can't get it to
work with 1.2.0.
It's behaving as if the launch.json daffdilDebugClasspath doesn't work. It
can't find an include file that is supplied for pcap.dfdl.xsd from the
ethernetIP schema.
Steps to reproduce:
git clone the PCAP and ethernetIP DFDL schemas from github DFDLSchemas
repositories.
Make sure the two directories are named exactly "PCAP" and "ethernetIP" and
are sibling directories. (These names will get used in attached launch.json)
modify build.sbt in both to use Daffodil 3.4.0
check out that they work from sbt:
* cd ethernetIP ; sbt test ; sbt publishLocal // should publish version
1.2.0 of ethernetIP. All tests should pass.
* cd ../PCAP ; sbt test // should pass all tests.
Now, open VSCode and nstall the 1.2.0 vsix.
Now open the PCAP folder in vscode.
Use the attached launch.json.
Either of the two launch configs should work. Both give the same problem:
[image: image.png]
On Mon, Nov 28, 2022 at 2:54 PM Shane Dell <sh...@apache.org> wrote:
> Hello all,I'd like to call a vote to release Apache Daffodil VS Code
> 1.2.0-rc2.
>
> All distribution packages, including signatures, digests, etc. can be
> found at:
> https://dist.apache.org/repos/dist/dev/daffodil/daffodil-vscode/1.2.0-rc2/
>
> This release has been signed with PGP key
> 86DDE7B41291E380237934F007570D3ADC76D51B, corresponding
> to shanedell@apache.org, which is included in the KEYS file here:
> https://downloads.apache.org/daffodil/KEYS
>
> The release candidate has been tagged in git with 1.2.0-rc2.
>
> For reference, here is a list of all closed GitHub issues tagged with
> 1.2.0:
> https://github.com/apache/daffodil-vscode/milestone/3?closed=1
>
> Please review and vote. The vote will be open for at least 72 hours
> (Thursday, 1 December 2022, 3:00pm EST).
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thank you,
>
> - Shane Dell
>