[GitHub] [arrow] pitrou commented on a change in pull request #10783: ARROW-13437: [C++] Relax FixedSizeList validation to allow excess child values

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #10783:
URL: https://github.com/apache/arrow/pull/10783#discussion_r676586176



##########
File path: cpp/src/arrow/array/array_test.cc
##########
@@ -487,6 +490,20 @@ TEST_F(TestArray, TestMakeArrayFromScalar) {
   }
 }
 
+TEST_F(TestArray, TestSlice) {

Review comment:
       Nit: call this `TestMakeArrayFromScalarSliced`?

##########
File path: cpp/src/arrow/array/array_list_test.cc
##########
@@ -1099,7 +1099,8 @@ TEST_F(TestFixedSizeListArray, BulkAppendInvalid) {
   }
 
   Done();
-  ASSERT_RAISES(Invalid, result_->ValidateFull());
+  // We appended too many values to the child array, but that's OK
+  ValidateBasicFixedSizeListArray(result_.get(), values, is_valid);

Review comment:
       Ok, but change the test name then?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org