[GitHub] [superset] gbusch commented on pull request #23064: feat: conditional coloring for big number chart

["gbusch (via GitHub)" <gi...@apache.org>]

gbusch commented on PR #23064:
URL: https://github.com/apache/superset/pull/23064#issuecomment-1509861876

   Sorry, was busy and then almost forgot about it...
   
   Colors are defined in this file: 
   superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx
   
   I renamed the colors to make it clearer that they refer to the theme colors and added possibility for darker colors (from theme). Does this make sense?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org