You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2020/07/08 02:39:00 UTC
[jira] [Commented] (HBASE-24693) regioninfo#isLast() has a logic
error
[ https://issues.apache.org/jira/browse/HBASE-24693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153190#comment-17153190 ]
Duo Zhang commented on HBASE-24693:
-----------------------------------
Actually EMPTY_START_ROW and EMPTY_STOP_ROW is the same...
So this will not effect correctness but it is a bit confusing to developers.
Mind opening a PR to fix it? [~Bo Cui]
Thanks.
> regioninfo#isLast() has a logic error
> -------------------------------------
>
> Key: HBASE-24693
> URL: https://issues.apache.org/jira/browse/HBASE-24693
> Project: HBase
> Issue Type: Bug
> Affects Versions: master, 2.2.3
> Reporter: Bo Cui
> Priority: Minor
>
> [https://github.com/apache/hbase/blob/90f4ff7d7c6997f61dbe40748b5c157879352acb/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java#L771]
> it should be
> {code:java}
> default boolean isLast() {
> return Bytes.equals(getEndKey(), HConstants.EMPTY_END_ROW);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)