[jira] [Commented] (FLINK-7013) Add shaded netty dependency

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108830#comment-16108830 ] 

ASF GitHub Bot commented on FLINK-7013:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4452

    [FLINK-7013] [shading] Introduce flink-shaded-netty-4

    This PR is based on #4425.
    
    ## What is the purpose of the change
    
    This PR integrates the shaded netty dependency from flink-shaded. Basically, replace all usages of netty with the shaded netty dependeny and remove all traves of the original dependeny.
    
    ## Brief change log
    
      - replace all netty/netty-router dependencies with flink-shaded-netty
      - replace all netty imports
      - modify illegal import checkstyle rule to forbid unshaded netty imports
      - add check in travis watchdog that no unshaded netty classes are present in flink-dist
    
    ## Verifying this change
    
    - check that compilation works
    - check artifacts for inclusion of shaded netty
    - check artifacts for exclusion of unshaded netty
    - check that we are not exposing a vanilla netty dependency with maven
    - start a cluster and run some examples
    - check that the web interface still works
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7013

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4452
    
----
commit cda79e8b318d146af910873b090f7e1f3543d6b1
Author: zentol <ch...@apache.org>
Date:   2017-06-13T15:02:03Z

    [FLINK-7305] [checkstyle] Allow imports from org.apache.flink.shaded + add new import block

commit af3ac36c00c9881f4692596dbc6791dfbc1705f0
Author: zentol <ch...@apache.org>
Date:   2017-06-27T12:27:16Z

    [FLINK-7013] Introduce flink-shaded-netty-4

----


> Add shaded netty dependency
> ---------------------------
>
>                 Key: FLINK-7013
>                 URL: https://issues.apache.org/jira/browse/FLINK-7013
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)