You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rayees Namathponnan <ra...@citrix.com> on 2013/06/30 09:29:00 UTC
Review Request 12200: Fixed issues while adding DC to zone in VM ware
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12200/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Fixed issues while adding DC to zone in VM ware,
Also script modified to skip adding host in vmware.
Diffs
-----
tools/marvin/marvin/deployDataCenter.py 961718a
Diff: https://reviews.apache.org/r/12200/diff/
Testing
-------
Tested
Thanks,
Rayees Namathponnan
Re: Review Request 12200: Fixed issues while adding DC to zone in VM ware
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12200/#review22767
-----------------------------------------------------------
Edison fixed this here
commit 810c64e38772719cba1c7e5cb4578c9e8c6a8d6d
Author: Edison Su <su...@gmail.com>
Date: Tue Jul 2 11:13:11 2013 -0700
fix marvin when deploy vmware setup
Discarding
- Prasanna Santhanam
On June 30, 2013, 7:29 a.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12200/
> -----------------------------------------------------------
>
> (Updated June 30, 2013, 7:29 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed issues while adding DC to zone in VM ware,
>
> Also script modified to skip adding host in vmware.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/deployDataCenter.py 961718a
>
> Diff: https://reviews.apache.org/r/12200/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request 12200: Fixed issues while adding DC to zone in VM ware
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12200/#review22581
-----------------------------------------------------------
tools/marvin/marvin/deployDataCenter.py
<https://reviews.apache.org/r/12200/#comment46297>
Only 1 vmwareDC can be added to a zone, hence we don't need to iterate over vmwareDcs collection. Better if we have vmwareDc object rather than collection vmwareDcs.
The above check for None is good.
- Sateesh Chodapuneedi
On June 30, 2013, 7:29 a.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12200/
> -----------------------------------------------------------
>
> (Updated June 30, 2013, 7:29 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed issues while adding DC to zone in VM ware,
>
> Also script modified to skip adding host in vmware.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/deployDataCenter.py 961718a
>
> Diff: https://reviews.apache.org/r/12200/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request 12200: Fixed issues while adding DC to zone in VM ware
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12200/#review22582
-----------------------------------------------------------
I think you were working on an old HEAD which is why most of the pep8 and storage related changes were removed. Please resubmit after pulling in latest
Also, don't forget to run a pep8 check on the file
$ pip install pep8
$ pep8 deployDataCenter.py
You can check for tab issues using tabnanny
$ python -m tabnanny tools
tools/marvin/marvin/deployDataCenter.py
<https://reviews.apache.org/r/12200/#comment46298>
Retain this as the new style class inheriting from `object`.
tools/marvin/marvin/deployDataCenter.py
<https://reviews.apache.org/r/12200/#comment46299>
These are required for adding object store and cache storage. Were these removed intentionally?
tools/marvin/marvin/deployDataCenter.py
<https://reviews.apache.org/r/12200/#comment46300>
These are required for adding object store and cache storage. Were these removed intentionally?
- Prasanna Santhanam
On June 30, 2013, 7:29 a.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12200/
> -----------------------------------------------------------
>
> (Updated June 30, 2013, 7:29 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed issues while adding DC to zone in VM ware,
>
> Also script modified to skip adding host in vmware.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/deployDataCenter.py 961718a
>
> Diff: https://reviews.apache.org/r/12200/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Rayees Namathponnan
>
>