You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/30 12:12:25 UTC
[GitHub] [shardingsphere-elasticjob-lite] nmyphp opened a new pull request #873: Use spring boot + JPA to deal with statistics dao
nmyphp opened a new pull request #873:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/873
Fixes #838.
Changes proposed in this pull request:
- Use spring boot + JPA refect RDBStatisticRepository
- Add DynamicDataSourceConfig for dynamic switch datasource
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] nmyphp commented on pull request #873: Use spring boot + JPA to deal with statistics dao
Posted by GitBox <gi...@apache.org>.
nmyphp commented on pull request #873:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/873#issuecomment-652171312
> Should the time style be TIMESTAMP? like @column(nullable = false, columnDefinition = "TIMESTAMP")
Thank you, I will test it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] nmyphp commented on pull request #873: Use spring boot + JPA to deal with statistics dao
Posted by GitBox <gi...@apache.org>.
nmyphp commented on pull request #873:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/873#issuecomment-652131081
> Please fix CI fail, the reason is for check style
sorry, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] Mark-WJQ commented on a change in pull request #873: Use spring boot + JPA to deal with statistics dao
Posted by GitBox <gi...@apache.org>.
Mark-WJQ commented on a change in pull request #873:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/873#discussion_r448094914
##########
File path: elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/domain/TaskResultStatistics.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.elasticjob.lite.console.domain;
+
+import java.util.Date;
+
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.GeneratedValue;
+import javax.persistence.GenerationType;
+import javax.persistence.Id;
+import javax.persistence.Table;
+
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+
+/**
+ * Task result statistics.
+ */
+@Getter
+@AllArgsConstructor
+@NoArgsConstructor
+@Entity
+@Table(name = "TASK_RESULT_STATISTICS")
Review comment:
TASK_RESULT_STATISTICS in the original project shuld be three tables task_result_statistics_minute,task_result_statistics_hour,task_result_statistics_day, now it merge to one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #873: Use spring boot + JPA to deal with statistics dao
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #873:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/873
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] Technoboy- commented on pull request #873: Use spring boot + JPA to deal with statistics dao
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #873:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/873#issuecomment-651845612
Hi, @nmyphp .
From the CI log, the format or code style of some classes are not satisfied.
This can be checked by running "mvn clean install" locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org