You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Steve Swinsburg (JIRA)" <ji...@apache.org> on 2008/10/17 11:48:44 UTC
[jira] Created: (WICKET-1878) ExternalLink should have title field
ExternalLink should have title field
------------------------------------
Key: WICKET-1878
URL: https://issues.apache.org/jira/browse/WICKET-1878
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4-M3, 1.3.4
Reporter: Steve Swinsburg
The ExternalLink componenet should either by default have a title field, or have another constructor that takes the title as a paremeter. Currently this is only achieved by using AttributeAppender and setting the title attribute onto the link.
eg current:
ExternalLink emailLink = new ExternalLink("mailToLink",new Model("mailto:" + emailAddress),new Model(emailAddress));
emailLink.add(new AttributeAppender("title", new Model(emailAddress), " "));
I propose the following constructor:
ExternalLink(java.lang.String id, java.lang.String href, java.lang.String label, java.lang.String title)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1878) ExternalLink should have title
field
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643227#action_12643227 ]
Erik van Oosten commented on WICKET-1878:
-----------------------------------------
Proposed solution: Won't fix.
Wicket should stay clean and mean. Adding these kinds of options all over the place won't help achive this goal.
Here is a custom component that reaches the comitters goal with a custom component.
public abstract class TitledLink extends Link {
public TitledLink(String id, String title) {
this(id, new Model<String>(title));
}
public TitledLink(String id, IModel<String> titleModel) {
super(id);
add(new AttributeModifier("title", true, titleModel));
}
}
> ExternalLink should have title field
> ------------------------------------
>
> Key: WICKET-1878
> URL: https://issues.apache.org/jira/browse/WICKET-1878
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Steve Swinsburg
>
> The ExternalLink component should either by default have a title field, or have another constructor that takes the title as a paremeter. Currently this is only achieved by using AttributeAppender and setting the title attribute onto the link.
> eg current:
> ExternalLink emailLink = new ExternalLink("mailToLink",new Model("mailto:" + emailAddress),new Model(emailAddress));
> emailLink.add(new AttributeAppender("title", new Model(emailAddress), " "));
> I propose the following constructor:
> ExternalLink(java.lang.String id, java.lang.String href, java.lang.String label, java.lang.String title)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1878) ExternalLink should have title
field
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640572#action_12640572 ]
Igor Vaynberg commented on WICKET-1878:
---------------------------------------
can we not just output the label as title? seems to be what you are doing.
> ExternalLink should have title field
> ------------------------------------
>
> Key: WICKET-1878
> URL: https://issues.apache.org/jira/browse/WICKET-1878
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Steve Swinsburg
>
> The ExternalLink component should either by default have a title field, or have another constructor that takes the title as a paremeter. Currently this is only achieved by using AttributeAppender and setting the title attribute onto the link.
> eg current:
> ExternalLink emailLink = new ExternalLink("mailToLink",new Model("mailto:" + emailAddress),new Model(emailAddress));
> emailLink.add(new AttributeAppender("title", new Model(emailAddress), " "));
> I propose the following constructor:
> ExternalLink(java.lang.String id, java.lang.String href, java.lang.String label, java.lang.String title)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1878) ExternalLink should have title
field
Posted by "Jonas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640940#action_12640940 ]
Jonas commented on WICKET-1878:
-------------------------------
The 'title' attribute is OPTIONAL! I think it would be a mistake to add this to the API - the solution with the AttributeAppender works fine. If someone wants this behaviour, he can roll his own (trivial) subclass of ExternalLink, which automatically adds the AttributeAppender.
So I suggest a "Won't fix" as resolution of this issue.
> ExternalLink should have title field
> ------------------------------------
>
> Key: WICKET-1878
> URL: https://issues.apache.org/jira/browse/WICKET-1878
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Steve Swinsburg
>
> The ExternalLink component should either by default have a title field, or have another constructor that takes the title as a paremeter. Currently this is only achieved by using AttributeAppender and setting the title attribute onto the link.
> eg current:
> ExternalLink emailLink = new ExternalLink("mailToLink",new Model("mailto:" + emailAddress),new Model(emailAddress));
> emailLink.add(new AttributeAppender("title", new Model(emailAddress), " "));
> I propose the following constructor:
> ExternalLink(java.lang.String id, java.lang.String href, java.lang.String label, java.lang.String title)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1878) ExternalLink should have title
field
Posted by "Steve Swinsburg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640946#action_12640946 ]
Steve Swinsburg commented on WICKET-1878:
-----------------------------------------
This is why I proposed the additional constructor so people can choose to automatically implement the title attribute by using that constructor. My example above was exactlty that, just an example, not how I wanted it implemented - so just adding the label as a title would not be the nicest implementation.
If you think the title attribute is optional, try talking to some disabled people who use screen readers. Again I am not saying it should be there by default, but an additional constructor would be nice.
For accessibility reasons, these things need to be addressed.
> ExternalLink should have title field
> ------------------------------------
>
> Key: WICKET-1878
> URL: https://issues.apache.org/jira/browse/WICKET-1878
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Steve Swinsburg
>
> The ExternalLink component should either by default have a title field, or have another constructor that takes the title as a paremeter. Currently this is only achieved by using AttributeAppender and setting the title attribute onto the link.
> eg current:
> ExternalLink emailLink = new ExternalLink("mailToLink",new Model("mailto:" + emailAddress),new Model(emailAddress));
> emailLink.add(new AttributeAppender("title", new Model(emailAddress), " "));
> I propose the following constructor:
> ExternalLink(java.lang.String id, java.lang.String href, java.lang.String label, java.lang.String title)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1878) ExternalLink should have title field
Posted by "Steve Swinsburg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Swinsburg updated WICKET-1878:
------------------------------------
Description:
The ExternalLink component should either by default have a title field, or have another constructor that takes the title as a paremeter. Currently this is only achieved by using AttributeAppender and setting the title attribute onto the link.
eg current:
ExternalLink emailLink = new ExternalLink("mailToLink",new Model("mailto:" + emailAddress),new Model(emailAddress));
emailLink.add(new AttributeAppender("title", new Model(emailAddress), " "));
I propose the following constructor:
ExternalLink(java.lang.String id, java.lang.String href, java.lang.String label, java.lang.String title)
was:
The ExternalLink componenet should either by default have a title field, or have another constructor that takes the title as a paremeter. Currently this is only achieved by using AttributeAppender and setting the title attribute onto the link.
eg current:
ExternalLink emailLink = new ExternalLink("mailToLink",new Model("mailto:" + emailAddress),new Model(emailAddress));
emailLink.add(new AttributeAppender("title", new Model(emailAddress), " "));
I propose the following constructor:
ExternalLink(java.lang.String id, java.lang.String href, java.lang.String label, java.lang.String title)
> ExternalLink should have title field
> ------------------------------------
>
> Key: WICKET-1878
> URL: https://issues.apache.org/jira/browse/WICKET-1878
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Steve Swinsburg
>
> The ExternalLink component should either by default have a title field, or have another constructor that takes the title as a paremeter. Currently this is only achieved by using AttributeAppender and setting the title attribute onto the link.
> eg current:
> ExternalLink emailLink = new ExternalLink("mailToLink",new Model("mailto:" + emailAddress),new Model(emailAddress));
> emailLink.add(new AttributeAppender("title", new Model(emailAddress), " "));
> I propose the following constructor:
> ExternalLink(java.lang.String id, java.lang.String href, java.lang.String label, java.lang.String title)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1878) ExternalLink should have title field
Posted by "Steve Swinsburg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Swinsburg closed WICKET-1878.
-----------------------------------
Resolution: Later
For now, the Javadocs should be updated to show people how to add the attribute in themselves. This is being tracked here:
WICKET-1899
> ExternalLink should have title field
> ------------------------------------
>
> Key: WICKET-1878
> URL: https://issues.apache.org/jira/browse/WICKET-1878
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Reporter: Steve Swinsburg
>
> The ExternalLink component should either by default have a title field, or have another constructor that takes the title as a paremeter. Currently this is only achieved by using AttributeAppender and setting the title attribute onto the link.
> eg current:
> ExternalLink emailLink = new ExternalLink("mailToLink",new Model("mailto:" + emailAddress),new Model(emailAddress));
> emailLink.add(new AttributeAppender("title", new Model(emailAddress), " "));
> I propose the following constructor:
> ExternalLink(java.lang.String id, java.lang.String href, java.lang.String label, java.lang.String title)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.